RE: FYI: Merge in progress...

[YhLu]

self.firstparentdevicelink()

How about IORESOURCE_FIXED ?

static void pnp_set_resource(device_t dev, struct resource *resource)
{
        if (!(resource->flags & IORESOURCE_ASSIGNED)) {
                printk_err("ERROR: %s %02x not allocated\n",
                        dev_path(dev), resource->index);
                return; 
        }

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] 
Sent: Monday, October 18, 2004 2:22 PM
To: YhLu
Cc: Ronald G. Minnich; Li-Ta Lo; 'LinuxBIOS'
Subject: Re: FYI: Merge in progress...

YhLu  writes:
> It should config.g bug, there is some un consistent.

It could be. I should have fixed this Saturday, but...

Looking Hmm...
> For dev33 and it sibling
> should be .bus = &_dev4.link[2],
> instead of 
>    .bus = &_dev4.link[0],

Good catch.  We do not yet have the link of the parent device set
properly in the .bus field.  It is always hard coded to 0 :(

Ok the fix looks easy, committed.

Hopefully I have not missed any other cases...

Eric

FYI: Merge in progress...

YhLu  writes:
> self.firstparentdevicelink()
>
> How about IORESOURCE_FIXED ?

Good point. I guess I should have looked at chip.c when I was doing 
that part of the conversion.  I have just added IORESOURCE_ASSIGNED to the flags.

I was so happy it booted I forgot to look for error messages :)

I will get the trivial fix for that commited in a moment.
> static void pnp_set_resource(device_t dev, struct resource *resource)
> {
>         if (!(resource->flags & IORESOURCE_ASSIGNED)) {
>                 printk_err("ERROR: %s %02x not allocated\n",
>                         dev_path(dev), resource->index);
>                 return; 
>         }

Eric