Re: [coreboot] Naming for identical chips with different model numbers due to different package variants

[Felix Held]

Hi!
> some vendor will come up with a way to break a naming scheme.

That why I choose NCT6776D and not NCT6776 as name.
NCT6776D and NCT6776F have a common datasheet and the only difference I 
could spot was the package. But the manufacturer might release a chip 
with a different suffix and slightly different functionality, which 
would probably break stuff, when I call the chip just NCT6776.
Also the suffix is part of the name.

I think I keep NCT6776D as name and change the chip description to
CHIP_NAME("NUVOTON NCT6776D/F Super I/O")
Seems to be the best solution to me.

Regards
Felix

Naming for identical chips with different model numbers due to different package variants

[Peter Stuge]

Felix Held wrote:
> the suffix is part of the name.

No it isn't. The suffix is part of the part number. The part number
is not the same thing as the chip name.
> I think I keep NCT6776D as name and change the chip description to
> CHIP_NAME("NUVOTON NCT6776D/F Super I/O")
> Seems to be the best solution to me.

Please don't do that. Please fix the name to correspond to the real
world. The code you are writing is communicating with a piece of
hardware that is expected to behave a certain way. Which package
the hardware comes in is utterly irrelevant for the behavior of the
hardware in this case, so please do not garble the name with that noise.

Thank you

//Peter

Naming for identical chips with different model numbers due to different package variants

[Felix Held]

Hi Peter!
> The code you are writing is communicating with a piece of
> hardware that is expected to behave a certain way. Which package
> the hardware comes in is utterly irrelevant for the behavior of the
> hardware in this case, so please do not garble the name with that noise.

Then I should rename the files to nct6776 and change the name to 
"NUVOTON NCT6776 Super I/O", but add a comment in the file that this is 
for the NCT6776D and NCT6776F parts? Haven't seen any devices with 
another suffix, but I'd say that it would be better to add some kind of 
note to prevent possible confusion in the future.

Regards
Felix

Naming for identical chips with different model numbers due to different package variants

[David Hendricks]

On Tue, Jun 3, 2014 at 12:07 PM, Felix Held 
wrote:
> Hi Peter!
>
> The code you are writing is communicating with a piece of
> > hardware that is expected to behave a certain way. Which package
> > the hardware comes in is utterly irrelevant for the behavior of the
> > hardware in this case, so please do not garble the name with that noise.
>
> Then I should rename the files to nct6776 and change the name to "NUVOTON
> NCT6776 Super I/O", but add a comment in the file that this is for the
> NCT6776D and NCT6776F parts? Haven't seen any devices with another suffix,
> but I'd say that it would be better to add some kind of note to prevent
> possible confusion in the future.

The Flashrom folks have a way of dealing with this:
http://www.flashrom.org/pipermail/flashrom/2012-July/009598.html

Personally, I'd just use a little 'x' in place of D or F in this case.