I just did an emergency commit

[ron minnich]

Alix1c won't boot with the zero decompress code. So I have disabled it
in a simple way:

Index: util/lar/stream.c
===================================================================
--- util/lar/stream.c   (revision 602)
+++ util/lar/stream.c   (working copy)
@@ -148,6 +148,7 @@
                        continue;
                }
                thisalgo = zeroes;
+               thisalgo = algo;
                if (verbose())
                        fprintf(stderr,  "New section addr %#x size %#x\n",
                        (u32)shdr[i].sh_addr, (u32)shdr[i].sh_size);

I think the code is using the wrong address on decompress, but I have
no idea and I want to rest.

FWIW, all the changes I put in for the dtc work seem to work fine.

BTW, we need to put svn rev in the coreboot banner, if anyone wants to try.

It's amazing how the simplest, most obvious, can't fail patches are
the ones that chew up 3 hours of debug time :-)

Thanks

ron

[PATCH] Fix zeroes decompression algo

[Carl-Daniel Hailfinger]

On 16.02.2008 07:41, ron minnich wrote:
> Alix1c won't boot with the zero decompress code. So I have disabled it
> in a simple way:

[...]
> I think the code is using the wrong address on decompress, but I have
> no idea and I want to rest.

Indeed, r601 broke all targets, you were just lucky that qemu didn't
explode as well.
It's the seemingly easy patches which break booting. With your hint, I
found the bug. Myles made a small, but important mistake with the memset
for the "zeroes" decompression.
The memset zeroed the archive instead of the destination. No wonder it
did explode.
This patch fixes it and also reverts the emergency commit r604 because
that one is no longer necessary.

Signed-off-by: Carl-Daniel Hailfinger

Index: LinuxBIOSv3-zerofixup/lib/lar.c
===================================================================
--- LinuxBIOSv3-zerofixup/lib/lar.c	(Revision 604)
+++ LinuxBIOSv3-zerofixup/lib/lar.c	(Arbeitskopie)
@@ -172,7 +172,7 @@
 #endif
    /* zeroes */
    if (archive->compression == 3) {
-		memset(archive->start, 0, archive->reallen);
+		memset(where, 0, archive->reallen);
    	return 0;
    }
    printk(BIOS_INFO, "LAR: Compression algorithm #%i not supported!\n", archive->compression);
Index: LinuxBIOSv3-zerofixup/util/lar/stream.c
===================================================================
--- LinuxBIOSv3-zerofixup/util/lar/stream.c	(Revision 604)
+++ LinuxBIOSv3-zerofixup/util/lar/stream.c	(Arbeitskopie)
@@ -148,7 +148,6 @@
    		continue;
    	}
    	thisalgo = zeroes;
-		thisalgo = algo;
    	if (verbose())
    		fprintf(stderr,  "New section addr %#x size %#x\n",
    		(u32)shdr[i].sh_addr, (u32)shdr[i].sh_size);

[PATCH] Fix zeroes decompression algo

[Stefan Reinauer]

* Carl-Daniel Hailfinger  [080216 13:55]:
> Signed-off-by: Carl-Daniel Hailfinger

Acked-by: Stefan Reinauer
> Index: LinuxBIOSv3-zerofixup/lib/lar.c
>
> --- LinuxBIOSv3-zerofixup/lib/lar.c	(Revision 604)
> +++ LinuxBIOSv3-zerofixup/lib/lar.c	(Arbeitskopie)
> @@ -172,7 +172,7 @@
>  #endif
>    /* zeroes */
>    if (archive->compression == 3) {
> memset(archive->start, 0, archive->reallen);
> memset(where, 0, archive->reallen);
> return 0;
> }
> printk(BIOS_INFO, "LAR: Compression algorithm #%i not supported!\n", archive->compression);
> Index: LinuxBIOSv3-zerofixup/util/lar/stream.c
>
> --- LinuxBIOSv3-zerofixup/util/lar/stream.c	(Revision 604)
> +++ LinuxBIOSv3-zerofixup/util/lar/stream.c	(Arbeitskopie)
> @@ -148,7 +148,6 @@
>    		continue;
>    	}
>    	thisalgo = zeroes;
> thisalgo = algo;
> if (verbose())
> 	fprintf(stderr,  "New section addr %#x size %#x\n",
> 	(u32)shdr[i].sh_addr, (u32)shdr[i].sh_size);

[PATCH] Fix zeroes decompression algo

[Carl-Daniel Hailfinger]

On 16.02.2008 15:40, Stefan Reinauer wrote:
> Carl-Daniel Hailfinger  [080216 13:55]:
> > Signed-off-by: Carl-Daniel Hailfinger
>
> Acked-by: Stefan Reinauer

Ron? I'm holding off a commit until you had the chance to test on
hardware. The fix seems obvious, though.

Regards,
Carl-Daniel

[PATCH] Fix zeroes decompression algo

[ron minnich]

Acked-by: Ronald G. Minnich

Tested on the Alix1c, boots fine, ethernet and IDE working.

thanks

ron

[PATCH] Fix zeroes decompression algo

[Carl-Daniel Hailfinger]

On 16.02.2008 17:55, ron minnich wrote:
> Acked-by: Ronald G. Minnich
>
> Tested on the Alix1c, boots fine, ethernet and IDE working.

Thanks for testing!
Committed in r605.

Regards,
Carl-Daniel