Fix Kconfig dependencies and update defconfigs.
A few questions remain: - Should CONFIG_SMP be selectable on GeodeLX and Qemu? Might make sense for debugging. - Should CONFIG_IOAPIC be selectable on GeodeLX and Qemu? Maybe for Qemu. - Should CONFIG_USBDEBUG_DIRECT be selectable on GeodeLX and Qemu? I don't think so.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Index: corebootv3-Kconfig_dependencies/mainboard/pcengines/alix1c/defconfig =================================================================== --- corebootv3-Kconfig_dependencies/mainboard/pcengines/alix1c/defconfig (Revision 782) +++ corebootv3-Kconfig_dependencies/mainboard/pcengines/alix1c/defconfig (Arbeitskopie) @@ -1,7 +1,7 @@ # # Automatically generated make config: don't edit -# coreboot version: 3.0.0 -# Sun Feb 24 11:45:09 2008 +# coreboot version: 3.0.782 +# Mon Aug 18 13:55:17 2008 #
# @@ -18,10 +18,12 @@ # CONFIG_VENDOR_ADL is not set # CONFIG_VENDOR_AMD is not set # CONFIG_VENDOR_ARTECGROUP is not set +# CONFIG_VENDOR_GIGABYTE is not set # CONFIG_VENDOR_EMULATION is not set CONFIG_VENDOR_PCENGINES=y CONFIG_MAINBOARD_DIR="pcengines/alix1c" CONFIG_BOARD_PCENGINES_ALIX1C=y +# CONFIG_BOARD_PCENGINES_ALIX2C3 is not set # CONFIG_COREBOOT_ROMSIZE_KB_128 is not set # CONFIG_COREBOOT_ROMSIZE_KB_256 is not set CONFIG_COREBOOT_ROMSIZE_KB_512=y @@ -33,8 +35,11 @@ CONFIG_CPU_AMD_GEODELX=y CONFIG_OPTION_TABLE=y CONFIG_PIRQ_TABLE=y +# CONFIG_SMP is not set +# CONFIG_IOAPIC is not set CONFIG_CARBASE=0x80000 CONFIG_CARSIZE=0x8000 +# CONFIG_USBDEBUG_DIRECT is not set
# # Compression Index: corebootv3-Kconfig_dependencies/mainboard/pcengines/alix2c3/defconfig =================================================================== --- corebootv3-Kconfig_dependencies/mainboard/pcengines/alix2c3/defconfig (Revision 782) +++ corebootv3-Kconfig_dependencies/mainboard/pcengines/alix2c3/defconfig (Arbeitskopie) @@ -1,7 +1,7 @@ # # Automatically generated make config: don't edit -# coreboot version: 3.0."656"' -# Wed Apr 9 20:59:03 2008 +# coreboot version: 3.0.782 +# Mon Aug 18 13:55:18 2008 #
# @@ -17,6 +17,7 @@ # CONFIG_VENDOR_ADL is not set # CONFIG_VENDOR_AMD is not set # CONFIG_VENDOR_ARTECGROUP is not set +# CONFIG_VENDOR_GIGABYTE is not set # CONFIG_VENDOR_EMULATION is not set CONFIG_VENDOR_PCENGINES=y CONFIG_MAINBOARD_DIR="pcengines/alix2c3" @@ -33,8 +34,11 @@ CONFIG_CPU_AMD_GEODELX=y CONFIG_OPTION_TABLE=y CONFIG_PIRQ_TABLE=y +# CONFIG_SMP is not set +# CONFIG_IOAPIC is not set CONFIG_CARBASE=0x80000 CONFIG_CARSIZE=0x8000 +# CONFIG_USBDEBUG_DIRECT is not set
# # Compression Index: corebootv3-Kconfig_dependencies/mainboard/emulation/qemu-x86/defconfig =================================================================== --- corebootv3-Kconfig_dependencies/mainboard/emulation/qemu-x86/defconfig (Revision 782) +++ corebootv3-Kconfig_dependencies/mainboard/emulation/qemu-x86/defconfig (Arbeitskopie) @@ -1,7 +1,7 @@ # # Automatically generated make config: don't edit -# coreboot version: 3.0.0 -# Thu Mar 13 07:13:17 2008 +# coreboot version: 3.0.782 +# Mon Aug 18 13:55:12 2008 #
# @@ -17,6 +17,7 @@ # CONFIG_VENDOR_ADL is not set # CONFIG_VENDOR_AMD is not set # CONFIG_VENDOR_ARTECGROUP is not set +# CONFIG_VENDOR_GIGABYTE is not set CONFIG_VENDOR_EMULATION=y # CONFIG_VENDOR_PCENGINES is not set CONFIG_MAINBOARD_DIR="emulation/qemu-x86" @@ -31,8 +32,11 @@ CONFIG_ARCH="x86" CONFIG_CPU_I586=y CONFIG_OPTION_TABLE=y +# CONFIG_SMP is not set +# CONFIG_IOAPIC is not set CONFIG_CARBASE=0x8f000 CONFIG_CARSIZE=0x1000 +# CONFIG_USBDEBUG_DIRECT is not set
# # Compression Index: corebootv3-Kconfig_dependencies/device/Kconfig =================================================================== --- corebootv3-Kconfig_dependencies/device/Kconfig (Revision 782) +++ corebootv3-Kconfig_dependencies/device/Kconfig (Arbeitskopie) @@ -97,11 +97,13 @@
config PCI_64BIT_PREF_MEM bool "64 bit prefetchable memory addresses" + depends CPU_AMD_K8 help Enable support for 64-bit prefetchable memory addresses in PCI.
config HW_MEM_HOLE_SIZEK hex "HW memory hole size in KB" + depends CPU_AMD_K8 default 0x1000 help Some chipsets support setting up a "hole" at the top of memory. It is essentially Index: corebootv3-Kconfig_dependencies/arch/x86/Kconfig =================================================================== --- corebootv3-Kconfig_dependencies/arch/x86/Kconfig (Revision 782) +++ corebootv3-Kconfig_dependencies/arch/x86/Kconfig (Arbeitskopie) @@ -93,12 +93,14 @@ config LOGICAL_CPUS hex + depends CPU_AMD_K8 default 1 help How many logical CPUs there are. Fix me.
config MAX_PHYSICAL_CPUS hex + depends CPU_AMD_K8 default 1 help Max number of physical CPUs (sockets)
On Mon, Aug 18, 2008 at 5:08 AM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
Fix Kconfig dependencies and update defconfigs.
A few questions remain:
- Should CONFIG_SMP be selectable on GeodeLX and Qemu? Might make sense
for debugging.
only if you can make some test in hardware so that you know you are not SMP. Otherwise, how can the AP scan other CPUs and find out there are not any?
- Should CONFIG_IOAPIC be selectable on GeodeLX and Qemu? Maybe for Qemu.
not sure on LX but it is unlikely?
- Should CONFIG_USBDEBUG_DIRECT be selectable on GeodeLX and Qemu? I
don't think so.
not sure. Does hardware support it?
ron
On 18.08.2008 17:43, ron minnich wrote:
On Mon, Aug 18, 2008 at 5:08 AM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
Fix Kconfig dependencies and update defconfigs.
A few questions remain:
- Should CONFIG_SMP be selectable on GeodeLX and Qemu? Might make sense
for debugging.
only if you can make some test in hardware so that you know you are not SMP. Otherwise, how can the AP scan other CPUs and find out there are not any?
It seems the K8 code is using CONFIG_LOGICAL_CPUS for that.
CONFIG_SMP does only control spinlocks and enables the LAPIC unconditionally.
- Should CONFIG_IOAPIC be selectable on GeodeLX and Qemu? Maybe for Qemu.
not sure on LX but it is unlikely?
Jordan says the LX doesn't support it.
- Should CONFIG_USBDEBUG_DIRECT be selectable on GeodeLX and Qemu? I
don't think so.
not sure. Does hardware support it?
The Geode CS5536 companion doesn't.
Updated patch checked in.
Regards, Carl-Daniel
On Mon, Aug 18, 2008 at 9:48 AM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
It seems the K8 code is using CONFIG_LOGICAL_CPUS for that.
I think the config logical cpus is for multicore. The name is confusing and I intend to change it.
CONFIG_SMP does only control spinlocks and enables the LAPIC unconditionally.
- Should CONFIG_IOAPIC be selectable on GeodeLX and Qemu? Maybe for Qemu.
not sure on LX but it is unlikely?
Jordan says the LX doesn't support it.
so the option should not be available.
ron
ron minnich wrote:
On Mon, Aug 18, 2008 at 9:48 AM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
It seems the K8 code is using CONFIG_LOGICAL_CPUS for that.
I think the config logical cpus is for multicore. The name is confusing and I intend to change it.
CONFIG_SMP does only control spinlocks and enables the LAPIC unconditionally.
- Should CONFIG_IOAPIC be selectable on GeodeLX and Qemu? Maybe for Qemu.
not sure on LX but it is unlikely?
Jordan says the LX doesn't support it.
so the option should not be available.
Those options are part of the hardware description, not real user options. They're there only because of short comings of our current dts scheme.
On 18.08.2008 18:57, Stefan Reinauer wrote:
ron minnich wrote:
On Mon, Aug 18, 2008 at 9:48 AM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
It seems the K8 code is using CONFIG_LOGICAL_CPUS for that.
I think the config logical cpus is for multicore. The name is confusing and I intend to change it.
CONFIG_SMP does only control spinlocks and enables the LAPIC unconditionally.
- Should CONFIG_IOAPIC be selectable on GeodeLX and Qemu? Maybe for Qemu.
not sure on LX but it is unlikely?
Jordan says the LX doesn't support it.
so the option should not be available.
Those options are part of the hardware description, not real user options. They're there only because of short comings of our current dts scheme.
If they are not user options, they shouldn't be selectable at all.
Regards, Carl-Daniel
Carl-Daniel Hailfinger wrote:
On 18.08.2008 18:57, Stefan Reinauer wrote:
ron minnich wrote:
On Mon, Aug 18, 2008 at 9:48 AM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
It seems the K8 code is using CONFIG_LOGICAL_CPUS for that.
I think the config logical cpus is for multicore. The name is confusing and I intend to change it.
CONFIG_SMP does only control spinlocks and enables the LAPIC unconditionally.
- Should CONFIG_IOAPIC be selectable on GeodeLX and Qemu? Maybe for Qemu.
not sure on LX but it is unlikely?
Jordan says the LX doesn't support it.
so the option should not be available.
Those options are part of the hardware description, not real user options. They're there only because of short comings of our current dts scheme.
If they are not user options, they shouldn't be selectable at all.
Not in the user interface. Indeed.
And, correctly, they were not selectable by the user.
Please, guys, don't fix stuff that ain't broken.
On Mon, Aug 18, 2008 at 10:02 AM, Stefan Reinauer stepan@coresystems.de wrote:
Carl-Daniel Hailfinger wrote:
On 18.08.2008 18:57, Stefan Reinauer wrote:
ron minnich wrote:
On Mon, Aug 18, 2008 at 9:48 AM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
It seems the K8 code is using CONFIG_LOGICAL_CPUS for that.
I think the config logical cpus is for multicore. The name is confusing and I intend to change it.
CONFIG_SMP does only control spinlocks and enables the LAPIC unconditionally.
> - Should CONFIG_IOAPIC be selectable on GeodeLX and Qemu? Maybe for Qemu. > > > > not sure on LX but it is unlikely?
Jordan says the LX doesn't support it.
so the option should not be available.
Those options are part of the hardware description, not real user options. They're there only because of short comings of our current dts scheme.
If they are not user options, they shouldn't be selectable at all.
Not in the user interface. Indeed.
And, correctly, they were not selectable by the user.
Please, guys, don't fix stuff that ain't broken.
I didn't see that they were selectable by the user.
Not all Kconfig variables are selectable by the user; they should be there nonetheless, I assume. Let me know if I made a mistake in some of the setup. We can fix the non-broken stuff I "fixed".
ron
Acked-by: Ronald G. Minnich rminnich@gmail.com
On 18.08.2008 17:44, ron minnich wrote:
Acked-by: Ronald G. Minnich rminnich@gmail.com
Thanks, r784.
Regards, Carl-Daniel
-
Carl-Daniel Hailfinger -
ron minnich -
Stefan Reinauer