[PATCH] v2: abuild: Add -r|--remove option to abuild

[Uwe Hermann]

See patch.

Uwe.

[Carl-Daniel Hailfinger]

On 17.12.2008 15:22, Uwe Hermann wrote:
> Add -r|--remove option to force abuild to remove the output directory
> after every board build, in order to save disk space if you don't need
> the actual output files.
>
> Signed-off-by: Uwe Hermann

Changing the -r option to keep the build log and the final ROM image
would be nice. That way, you can still look at the logs after a complete
abuild run.

Regards,
Carl-Daniel

[Peter Stuge]

Uwe Hermann wrote:
> Add -r|--remove option to force abuild to remove the output directory
> after every board build, in order to save disk space if you don't need
> the actual output files.
>
> Signed-off-by: Uwe Hermann

See below.

Acked-by: Peter Stuge
> VENDOR=$1
> MAINBOARD=$2

Request "${1}" and "${2}"
> if [ "$remove" == "true" ]; then

Should this really be == and not just a single = ?
> printf "Removing build dir for board $VENDOR $MAINBOARD...\n"
> rm -rf $TARGET/${VENDOR}_${MAINBOARD}

Likewise request "${TARGET}/${VENDOR}_${MAINBOARD}"

//Peter

[Uwe Hermann]

On Thu, Dec 18, 2008 at 01:41:54AM +0100, Peter Stuge wrote:
> Uwe Hermann wrote:
> > Add -r|--remove option to force abuild to remove the output directory
> > after every board build, in order to save disk space if you don't need
> > the actual output files.
> >
> > Signed-off-by: Uwe Hermann
>
> See below.
>
> Acked-by: Peter Stuge

Thanks, long-overdue commit in r4119 (build-tested again today to make
sure nothing broke in the mean time).
> > VENDOR=$1
> > MAINBOARD=$2
>
> Request "${1}" and "${2}"
> > if [ "$remove" == "true" ]; then
>
> Should this really be == and not just a single = ?
> > printf "Removing build dir for board $VENDOR $MAINBOARD...\n"
> > rm -rf $TARGET/${VENDOR}_${MAINBOARD}
>
> Likewise request "${TARGET}/${VENDOR}_${MAINBOARD}"

Will look into these issues and test/fix them in a separate patch.

Uwe.

[Carl-Daniel Hailfinger]

On 15.04.2009 18:08, Uwe Hermann wrote:
> On Thu, Dec 18, 2008 at 01:41:54AM +0100, Peter Stuge wrote:
> > Uwe Hermann wrote:
> > > Add -r|--remove option to force abuild to remove the output directory
> > > after every board build, in order to save disk space if you don't need
> > > the actual output files.
> > >
> > > Signed-off-by: Uwe Hermann
> >
> > See below.
> >
> > Acked-by: Peter Stuge
>
> Thanks, long-overdue commit in r4119 (build-tested again today to make
> sure nothing broke in the mean time).

Could you save the logs as well?

Regards,
Carl-Daniel

[Stefan Reinauer]

Sorry, I completely missed this one.. There was an option to do this 
already: -a
The help text says:

build previously succeeded ports as well

This option has been in there for several years.

Could we back this one out again?

Stefan

Uwe Hermann schrieb:
> On Thu, Dec 18, 2008 at 01:41:54AM +0100, Peter Stuge wrote:
> > Uwe Hermann wrote:
> > > Add -r|--remove option to force abuild to remove the output directory
> > > after every board build, in order to save disk space if you don't need
> > > the actual output files.
> > >
> > > Signed-off-by: Uwe Hermann
> >
> > See below.
> >
> > Acked-by: Peter Stuge
>
> Thanks, long-overdue commit in r4119 (build-tested again today to make
> sure nothing broke in the mean time).
> > > VENDOR=$1
> > > MAINBOARD=$2
> >
> > Request "${1}" and "${2}"
> > > if [ "$remove" == "true" ]; then
> >
> > Should this really be == and not just a single = ?
> > > printf "Removing build dir for board $VENDOR $MAINBOARD...\n"
> > > rm -rf $TARGET/${VENDOR}_${MAINBOARD}
> >
> > Likewise request "${TARGET}/${VENDOR}_${MAINBOARD}"
>
> Will look into these issues and test/fix them in a separate patch.
>
> Uwe.

[Stefan Reinauer]

Pardon my last mail.. I completely missed the point. The option is 
indeed _very_ useful. Please don't back out.

Uwe Hermann schrieb:
> On Thu, Dec 18, 2008 at 01:41:54AM +0100, Peter Stuge wrote:
> > Uwe Hermann wrote:
> > > Add -r|--remove option to force abuild to remove the output directory
> > > after every board build, in order to save disk space if you don't need
> > > the actual output files.
> > >
> > > Signed-off-by: Uwe Hermann
> >
> > See below.
> >
> > Acked-by: Peter Stuge
>
> Thanks, long-overdue commit in r4119 (build-tested again today to make
> sure nothing broke in the mean time).
> > > VENDOR=$1
> > > MAINBOARD=$2
> >
> > Request "${1}" and "${2}"
> > > if [ "$remove" == "true" ]; then
> >
> > Should this really be == and not just a single = ?
> > > printf "Removing build dir for board $VENDOR $MAINBOARD...\n"
> > > rm -rf $TARGET/${VENDOR}_${MAINBOARD}
> >
> > Likewise request "${TARGET}/${VENDOR}_${MAINBOARD}"
>
> Will look into these issues and test/fix them in a separate patch.
>
> Uwe.