Re: [LinuxBIOS] r2666 - trunk/LinuxBIOSv2/src/mainboard/iei/nova4899r

[Peter Stuge]

On Tue, May 15, 2007 at 06:55:26AM +0000, [e-mail] wrote:
> const struct irq_routing_table intel_irq_routing_table = {

^^^^^
?

//Peter

[LinuxBIOS] r2666 - trunk/LinuxBIOSv2/src/mainboard/iei/nova4899r

[Luis Correia]

Hi!

On 5/15/07, Peter Stuge  wrote:
> On Tue, May 15, 2007 at 06:55:26AM +0000, [e-mail] wrote:
> > const struct irq_routing_table intel_irq_routing_table = {
>                               ^^^^^
>
> ?

good point!

I was so happy to see it work that i never noticed, i'll fix it soon
Luis

[LinuxBIOS] r2666 - trunk/LinuxBIOSv2/src/mainboard/iei/nova4899r

[Uwe Hermann]

On Tue, May 15, 2007 at 10:58:59AM +0100, Luis Correia wrote:
> > > const struct irq_routing_table intel_irq_routing_table = {
> >                               ^^^^^

I'm not so sure about this. Does the name matter at all? Grepping
through the code, I see that almost all boards use the
intel_irq_routing_table name. Shouldn't we keep it then? Maybe this is
because Intel "invented" this format or something?

agami/aruma/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
amd/rumba/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
amd/serengeti_cheetah/irq_tables.c:     struct irq_routing_table *pirq;
amd/norwich/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
amd/norwich/irq_tables.c:       struct irq_routing_table *pirq_tbl;
amd/norwich/irq_tables.c:       pirq_tbl = (struct irq_routing_table *)(addr);
arima/hdama/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
artecgroup/dbe61/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = 
asi/mb_5blmp/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
broadcom/blast/irq_tables.c:    struct irq_routing_table *pirq;
dell/s1850/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
densitron/dpx114/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
digitallogic/msm800sev/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
digitallogic/msm800sev/irq_tables.c:       struct irq_routing_table *pirq_tbl;
digitallogic/msm800sev/irq_tables.c:       pirq_tbl = (struct irq_routing_table *)(addr);
digitallogic/adl855pc/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
digitallogic/msm586seg/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
eaglelion/5bcm/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
emulation/qemu-i386/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
gigabyte/m57sli/irq_tables.c:   struct irq_routing_table *pirq;
ibm/e326/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
ibm/e325/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
iei/nova4899r/irq_tables.c:const struct irq_routing_table pirq_routing_table = {
intel/xe7501devkit/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
intel/jarrell/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
iwill/dk8_htx/irq_tables.c:     struct irq_routing_table *pirq;
iwill/dk8s2/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
iwill/dk8x/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
lippert/frontrunner/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
msi/ms9282/irq_tables.c:       struct irq_routing_table *pirq;
msi/ms9185/irq_tables.c:       struct irq_routing_table *pirq;
newisys/khepri/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
nvidia/l1_2pvv/irq_tables.c:    struct irq_routing_table *pirq;
olpc/btest/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
olpc/rev_a/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
sunw/ultra40/irq_tables.c:      struct irq_routing_table *pirq;
supermicro/x6dai_g/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
supermicro/h8dmr/irq_tables.c:  struct irq_routing_table *pirq;
supermicro/x6dhe_g/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
supermicro/x6dhe_g2/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
supermicro/x6dhr_ig/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
supermicro/x6dhr_ig2/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
technologic/ts5300/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
tyan/s2912/irq_tables.c:        struct irq_routing_table *pirq;
tyan/s2850/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
tyan/s2735/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
tyan/s2880/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
tyan/s2881/irq_tables.c:        struct irq_routing_table *pirq;
tyan/s2882/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
tyan/s2882/irq_tables.c:        struct irq_routing_table *pirq;
tyan/s2891/irq_tables.c:        struct irq_routing_table *pirq;
tyan/s4880/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
tyan/s2892/irq_tables.c:        struct irq_routing_table *pirq;
tyan/s2875/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
tyan/s4882/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
tyan/s2885/irq_tables.c:        struct irq_routing_table *pirq;
tyan/s2895/irq_tables.c:        struct irq_routing_table *pirq;
via/epia-m/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
via/epia/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {

Uwe.

[LinuxBIOS] r2666 - trunk/LinuxBIOSv2/src/mainboard/iei/nova4899r

[Luis Correia]

Hi!

Uwe, it is all the same to me.
Forget the patch then.

Luis Correia

On 5/17/07, Uwe Hermann  wrote:
> On Tue, May 15, 2007 at 10:58:59AM +0100, Luis Correia wrote:
> > > > const struct irq_routing_table intel_irq_routing_table = {
> > >                               ^^^^^
>
> I'm not so sure about this. Does the name matter at all? Grepping
> through the code, I see that almost all boards use the
> intel_irq_routing_table name. Shouldn't we keep it then? Maybe this is
> because Intel "invented" this format or something?
>
> agami/aruma/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> amd/rumba/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> amd/serengeti_cheetah/irq_tables.c:     struct irq_routing_table *pirq;
> amd/norwich/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> amd/norwich/irq_tables.c:       struct irq_routing_table *pirq_tbl;
> amd/norwich/irq_tables.c:       pirq_tbl = (struct irq_routing_table *)(addr);
> arima/hdama/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> artecgroup/dbe61/irq_tables.c:const struct irq_routing_table intel_irq_routing_table =
> asi/mb_5blmp/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> broadcom/blast/irq_tables.c:    struct irq_routing_table *pirq;
> dell/s1850/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> densitron/dpx114/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> digitallogic/msm800sev/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> digitallogic/msm800sev/irq_tables.c:       struct irq_routing_table *pirq_tbl;
> digitallogic/msm800sev/irq_tables.c:       pirq_tbl = (struct irq_routing_table *)(addr);
> digitallogic/adl855pc/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> digitallogic/msm586seg/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> eaglelion/5bcm/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> emulation/qemu-i386/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> gigabyte/m57sli/irq_tables.c:   struct irq_routing_table *pirq;
> ibm/e326/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> ibm/e325/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> iei/nova4899r/irq_tables.c:const struct irq_routing_table pirq_routing_table = {
> intel/xe7501devkit/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> intel/jarrell/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> iwill/dk8_htx/irq_tables.c:     struct irq_routing_table *pirq;
> iwill/dk8s2/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> iwill/dk8x/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> lippert/frontrunner/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> msi/ms9282/irq_tables.c:       struct irq_routing_table *pirq;
> msi/ms9185/irq_tables.c:       struct irq_routing_table *pirq;
> newisys/khepri/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> nvidia/l1_2pvv/irq_tables.c:    struct irq_routing_table *pirq;
> olpc/btest/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> olpc/rev_a/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> sunw/ultra40/irq_tables.c:      struct irq_routing_table *pirq;
> supermicro/x6dai_g/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> supermicro/h8dmr/irq_tables.c:  struct irq_routing_table *pirq;
> supermicro/x6dhe_g/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> supermicro/x6dhe_g2/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> supermicro/x6dhr_ig/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> supermicro/x6dhr_ig2/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> technologic/ts5300/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> tyan/s2912/irq_tables.c:        struct irq_routing_table *pirq;
> tyan/s2850/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> tyan/s2735/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> tyan/s2880/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> tyan/s2881/irq_tables.c:        struct irq_routing_table *pirq;
> tyan/s2882/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> tyan/s2882/irq_tables.c:        struct irq_routing_table *pirq;
> tyan/s2891/irq_tables.c:        struct irq_routing_table *pirq;
> tyan/s4880/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> tyan/s2892/irq_tables.c:        struct irq_routing_table *pirq;
> tyan/s2875/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> tyan/s4882/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> tyan/s2885/irq_tables.c:        struct irq_routing_table *pirq;
> tyan/s2895/irq_tables.c:        struct irq_routing_table *pirq;
> via/epia-m/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> via/epia/irq_tables.c:const struct irq_routing_table intel_irq_routing_table = {
> Uwe.
>
> http://www.hermann-uwe.de  | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFGTEFTXdVoV3jWIbQRAguKAKCHCHrjYFI3gemUogKFsnVYUKp1pwCfWnKB
> G22WpLc7jvCAKsvhO9GgZu8=
> =OjzW
> -----END PGP SIGNATURE-----