Something broke between revision 5574 and 5576

[mbertens]

Hi Mylyes,

i send this mail with two log files. 
- revision 5575 worked fine
- revision 5576 and beyond it crashed.

it has to do with the changes made to device.c

If you need more information let me known

Marc

[Myles Watson]

> i send this mail with two log files.
> revision 5575 worked fine
> revision 5576 and beyond it crashed.
>
> it has to do with the changes made to device.c

malloc 001201c8
PCI: 00:0f.0 [104c/ac1c] ops

I'm surprised that my changes added ops to your Cardbus controller.  There
are a lot of differences in the logs related to that device.

If you do svn diff from your working 5575 tree and your 5576 tree, are the
diffs the same?  If you can minimize the differences, it will make it a lot
easier to track down.

Thanks,
Myles

[mbertens]

On Fri, 2010-05-28 at 16:41 -0600, Myles Watson wrote:
> > i send this mail with two log files.
> > revision 5575 worked fine
> > revision 5576 and beyond it crashed.
> >
> > it has to do with the changes made to device.c
>
> malloc 001201c8
> PCI: 00:0f.0 [104c/ac1c] ops
>
> I'm surprised that my changes added ops to your Cardbus controller.  There
> are a lot of differences in the logs related to that device.

Yeah wrong log.
> If you do svn diff from your working 5575 tree and your 5576 tree, are the
> diffs the same?  If you can minimize the differences, it will make it a lot
> easier to track down.

I did a build with 5576 just now and it booted, i was very supriced. So
i need to investigate it more. to see where the breaking point is. i
will do it later to day, first i have to work a little :-)
> Thanks,
> Myles

[mbertens]

On Fri, 2010-05-28 at 16:41 -0600, Myles Watson wrote:
> > i send this mail with two log files.
> > revision 5575 worked fine
> > revision 5576 and beyond it crashed.
> >
> > it has to do with the changes made to device.c
>
> malloc 001201c8
> PCI: 00:0f.0 [104c/ac1c] ops
>
> I'm surprised that my changes added ops to your Cardbus controller.  There
> are a lot of differences in the logs related to that device.

I just made a mess, so i apologize for the scare. Currently running 5596
on the Nokia IP530 and all is well.
> If you do svn diff from your working 5575 tree and your 5576 tree, are the
> diffs the same?  If you can minimize the differences, it will make it a lot
> easier to track down.
>
> Thanks,
> Myles

Marc

[Myles Watson]

> On Fri, 2010-05-28 at 16:41 -0600, Myles Watson wrote:
> > > i send this mail with two log files.
> > > revision 5575 worked fine
> > > revision 5576 and beyond it crashed.
> > >
> > > it has to do with the changes made to device.c
> >
> > malloc 001201c8
> > PCI: 00:0f.0 [104c/ac1c] ops
> >
> > I'm surprised that my changes added ops to your Cardbus controller.
>
> There
> > are a lot of differences in the logs related to that device.
>
> I just made a mess, so i apologize for the scare. Currently running 5596
> on the Nokia IP530 and all is well.

I'm glad it's working for you.

Thanks,
Myles

[mbertens]

On Sat, 2010-05-29 at 18:17 -0600, Myles Watson wrote:
> > On Fri, 2010-05-28 at 16:41 -0600, Myles Watson wrote:
> > > > i send this mail with two log files.
> > > > revision 5575 worked fine
> > > > revision 5576 and beyond it crashed.
> > > >
> > > > it has to do with the changes made to device.c
> > >
> > > malloc 001201c8
> > > PCI: 00:0f.0 [104c/ac1c] ops
> > >
> > > I'm surprised that my changes added ops to your Cardbus controller.
> >
> > There

I figured out what caused the problem, i added 'device_operations'
structure '.read_resources' set to 'pci_dev_read_resources'. I set the
parameter to NULL and the problem was gone.

static struct device_operations ti_pci1225_ops  = {
    .read_resources   = NULL,	
    .set_resources    = pci_dev_set_resources,
    .enable_resources = pci_dev_enable_resources,
    .init             = ti_pci1225_init,
    .scan_bus         = 0,
};

is the 'pci_dev_read_resources' and mandarory function, and therefor do
i need to write a specif for the PCMCIA/Cardbus controller?
> > > are a lot of differences in the logs related to that device.
> >
> > I just made a mess, so i apologize for the scare. Currently running 5596
> > on the Nokia IP530 and all is well.
>
> I'm glad it's working for you.
>
> Thanks,
> Myles

Marc