[LinuxBIOS] [flashrom] request for review: VT8233A support

[Peter Lemenkov]

Hello All!
Looking at the lspci output I created simple patch for adding VT8233A
support. Unfortunately I can't find out what flash-chip is on my
mainboard (it's far away from me so I can perform only "software"
look) but maybe someone else tests whether this patch works or not?

Unfortunately guys from Via still don't answer on my request for datasheets...

[Carl-Daniel Hailfinger]

On 21.10.2007 15:09, Peter Lemenkov wrote:
> Hello All!
> Looking at the lspci output I created simple patch for adding VT8233A
> support. Unfortunately I can't find out what flash-chip is on my
> mainboard (it's far away from me so I can perform only "software"
> look) but maybe someone else tests whether this patch works or not?
>
> Unfortunately guys from Via still don't answer on my request for datasheets...

If you sign off and write a short changelog, I'll ack and commit.

Regards,
Carl-Daniel

[Stefan Reinauer]

* Carl-Daniel Hailfinger  [071022 18:24]:
> On 21.10.2007 15:09, Peter Lemenkov wrote:
> > Hello All!
> > Looking at the lspci output I created simple patch for adding VT8233A
> > support. Unfortunately I can't find out what flash-chip is on my
> > mainboard (it's far away from me so I can perform only "software"
> > look) but maybe someone else tests whether this patch works or not?

Does "flashrom" not detect the chip with your patch? So your patch is
not working like that?
> > Unfortunately guys from Via still don't answer on my request for datasheets...
>
> If you sign off and write a short changelog, I'll ack and commit.

... in which case it should not be committed...

[Peter Lemenkov]

2007/10/22, Stefan Reinauer :
> Does "flashrom" not detect the chip with your patch? So your patch is
> not working like that?

I don't know. I experimenting on one of my computers which cannot be
reached easily, so I can' see what flashchip they use (m/b - Gigabyte
7VRX and I failed to find BoM for it), so I call for help - maybe
someone has m/b with VT8233A inside.

[Peter Lemenkov]

2007/10/22, Carl-Daniel Hailfinger :
> On 21.10.2007 15:09, Peter Lemenkov wrote:
> > Hello All!
> > Looking at the lspci output I created simple patch for adding VT8233A
> > support. Unfortunately I can't find out what flash-chip is on my
> > mainboard (it's far away from me so I can perform only "software"
> > look) but maybe someone else tests whether this patch works or not?
> > Unfortunately guys from Via still don't answer on my request for datasheets...
> If you sign off and write a short changelog, I'll ack and commit.

OK.
This patch adds preliminary support for Via VT8233A chip. Its based on
information gathered using lspci and therefore not tested.

Signed-off-by: Peter Lemenkov

[Carl-Daniel Hailfinger]

On 22.10.2007 19:11, Peter Lemenkov wrote:
> 2007/10/22, Carl-Daniel Hailfinger :
> > On 21.10.2007 15:09, Peter Lemenkov wrote:
> > > Hello All!
> > > Looking at the lspci output I created simple patch for adding VT8233A
> > > support. Unfortunately I can't find out what flash-chip is on my
> > > mainboard (it's far away from me so I can perform only "software"
> > > look) but maybe someone else tests whether this patch works or not?
> > > Unfortunately guys from Via still don't answer on my request for datasheets...
> > If you sign off and write a short changelog, I'll ack and commit.
>
> OK.
> This patch adds preliminary support for Via VT8233A chip. Its based on
> information gathered using lspci and therefore not tested.
>
> Signed-off-by: Peter Lemenkov

If you test it and it works, I will commit. As long as that is not sure,
the patch has to wait.

Carl-Daniel

[Peter Lemenkov]

2007/10/22, Carl-Daniel Hailfinger :
> If you test it and it works,

[root@Nostromo ~]# ./flashrom
Calibrating delay loop... OK.
No LinuxBIOS table found.
Found chipset "VT8233A", enabling flash write... OK.
generic_spi_command called, but no SPI chipset detected
No EEPROM/flash device found.
[root@Nostromo ~]#

Looks like I can prepare it for writing. Can someone test it further?
Looking through some docs I found that VT8233A is similar to VT8231 in
case of dealing with flashchips so it would be easy to test...

[Carl-Daniel Hailfinger]

On 22.10.2007 22:18, Peter Lemenkov wrote:
> 2007/10/22, Carl-Daniel Hailfinger :
> > If you test it and it works,
>
> [root@Nostromo ~]# ./flashrom
> Calibrating delay loop... OK.
> No LinuxBIOS table found.
> Found chipset "VT8233A", enabling flash write... OK.
> generic_spi_command called, but no SPI chipset detected
> No EEPROM/flash device found.
> [root@Nostromo ~]#

Try flashrom -V
> Looks like I can prepare it for writing. Can someone test it further?

No, the only thing you did was set some bit in some register. We have no
idea if that works on the VT8233A chipset. The "enabling flash write"
message just means we were able to set a bit in a register, nothing more.
> Looking through some docs I found that VT8233A is similar to VT8231 in
> case of dealing with flashchips so it would be easy to test...

Regards,
Carl-Daniel