See patch.
At the very least the IDE legacy port access must be enabled to be able to use FILO. The rest is optional, but I see no reason to not enable it per default.
Uwe.
* Uwe Hermann uwe@hermann-uwe.de [071130 03:21]:
See patch.
At the very least the IDE legacy port access must be enabled to be able to use FILO. The rest is optional, but I see no reason to not enable it per default.
should this maybe be a cmos option instead? Some old drives (being present in old machines) might not work with the setting.
Stefan
Uwe.
http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
Enable IDE legacy port access and UDMA/33 for all 440BX based boards per default, for now. If there are problems with UDMA on some of them we might selectively disable UDMA there.
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de
Index: src/mainboard/a-trend/atc-6220/Config.lb
--- src/mainboard/a-trend/atc-6220/Config.lb (Revision 2994) +++ src/mainboard/a-trend/atc-6220/Config.lb (Arbeitskopie) @@ -130,6 +130,11 @@ device pci 7.3 on end # ACPI register "ide0_enable" = "1" register "ide1_enable" = "1"
register "ide_legacy_enable" = "1"
register "ide0_drive0_udma33_enable" = "1"
register "ide0_drive1_udma33_enable" = "1"
register "ide1_drive0_udma33_enable" = "1"
end endregister "ide1_drive1_udma33_enable" = "1"
end Index: src/mainboard/gigabyte/ga-6bxc/Config.lb =================================================================== --- src/mainboard/gigabyte/ga-6bxc/Config.lb (Revision 2994) +++ src/mainboard/gigabyte/ga-6bxc/Config.lb (Arbeitskopie) @@ -128,6 +128,11 @@ device pci 7.3 on end # ACPI register "ide0_enable" = "1" register "ide1_enable" = "1"
register "ide_legacy_enable" = "1"
register "ide0_drive0_udma33_enable" = "1"
register "ide0_drive1_udma33_enable" = "1"
register "ide1_drive0_udma33_enable" = "1"
end endregister "ide1_drive1_udma33_enable" = "1"
end Index: src/mainboard/biostar/m6tba/Config.lb =================================================================== --- src/mainboard/biostar/m6tba/Config.lb (Revision 2994) +++ src/mainboard/biostar/m6tba/Config.lb (Arbeitskopie) @@ -124,6 +124,11 @@ device pci 7.3 on end # ACPI register "ide0_enable" = "1" register "ide1_enable" = "1"
register "ide_legacy_enable" = "1"
register "ide0_drive0_udma33_enable" = "1"
register "ide0_drive1_udma33_enable" = "1"
register "ide1_drive0_udma33_enable" = "1"
end endregister "ide1_drive1_udma33_enable" = "1"
end Index: src/mainboard/azza/pt-6ibd/Config.lb =================================================================== --- src/mainboard/azza/pt-6ibd/Config.lb (Revision 2994) +++ src/mainboard/azza/pt-6ibd/Config.lb (Arbeitskopie) @@ -130,6 +130,11 @@ device pci 7.3 on end # ACPI register "ide0_enable" = "1" register "ide1_enable" = "1"
register "ide_legacy_enable" = "1"
register "ide0_drive0_udma33_enable" = "1"
register "ide0_drive1_udma33_enable" = "1"
register "ide1_drive0_udma33_enable" = "1"
end endregister "ide1_drive1_udma33_enable" = "1"
end Index: src/mainboard/tyan/s1846/Config.lb =================================================================== --- src/mainboard/tyan/s1846/Config.lb (Revision 2994) +++ src/mainboard/tyan/s1846/Config.lb (Arbeitskopie) @@ -126,6 +126,11 @@ device pci 7.3 on end # ACPI register "ide0_enable" = "1" register "ide1_enable" = "1"
register "ide_legacy_enable" = "1"
register "ide0_drive0_udma33_enable" = "1"
register "ide0_drive1_udma33_enable" = "1"
register "ide1_drive0_udma33_enable" = "1"
end endregister "ide1_drive1_udma33_enable" = "1"
end Index: src/mainboard/compaq/deskpro_en_sff_p600/Config.lb =================================================================== --- src/mainboard/compaq/deskpro_en_sff_p600/Config.lb (Revision 2994) +++ src/mainboard/compaq/deskpro_en_sff_p600/Config.lb (Arbeitskopie) @@ -134,6 +134,11 @@ device pci 14.3 on end # ACPI register "ide0_enable" = "1" register "ide1_enable" = "1"
register "ide_legacy_enable" = "1"
register "ide0_drive0_udma33_enable" = "1"
register "ide0_drive1_udma33_enable" = "1"
register "ide1_drive0_udma33_enable" = "1"
end endregister "ide1_drive1_udma33_enable" = "1"
end Index: src/mainboard/asus/p2b/Config.lb =================================================================== --- src/mainboard/asus/p2b/Config.lb (Revision 2994) +++ src/mainboard/asus/p2b/Config.lb (Arbeitskopie) @@ -130,6 +130,11 @@ device pci 4.3 on end # ACPI register "ide0_enable" = "1" register "ide1_enable" = "1"
register "ide_legacy_enable" = "1"
register "ide0_drive0_udma33_enable" = "1"
register "ide0_drive1_udma33_enable" = "1"
register "ide1_drive0_udma33_enable" = "1"
end endregister "ide1_drive1_udma33_enable" = "1"
end Index: src/mainboard/asus/p2b-f/Config.lb =================================================================== --- src/mainboard/asus/p2b-f/Config.lb (Revision 2994) +++ src/mainboard/asus/p2b-f/Config.lb (Arbeitskopie) @@ -130,6 +130,11 @@ device pci 4.3 on end # ACPI register "ide0_enable" = "1" register "ide1_enable" = "1"
register "ide_legacy_enable" = "1"
register "ide0_drive0_udma33_enable" = "1"
register "ide0_drive1_udma33_enable" = "1"
register "ide1_drive0_udma33_enable" = "1"
end endregister "ide1_drive1_udma33_enable" = "1"
end Index: src/mainboard/asus/p3b-f/Config.lb =================================================================== --- src/mainboard/asus/p3b-f/Config.lb (Revision 2994) +++ src/mainboard/asus/p3b-f/Config.lb (Arbeitskopie) @@ -131,6 +131,11 @@ device pci 4.3 on end # ACPI register "ide0_enable" = "1" register "ide1_enable" = "1"
register "ide_legacy_enable" = "1"
register "ide0_drive0_udma33_enable" = "1"
register "ide0_drive1_udma33_enable" = "1"
register "ide1_drive0_udma33_enable" = "1"
end endregister "ide1_drive1_udma33_enable" = "1"
end
-- linuxbios mailing list linuxbios@linuxbios.org http://www.linuxbios.org/mailman/listinfo/linuxbios
On Fri, Nov 30, 2007 at 09:14:57AM +0100, Stefan Reinauer wrote:
- Uwe Hermann uwe@hermann-uwe.de [071130 03:21]:
See patch.
At the very least the IDE legacy port access must be enabled to be able to use FILO. The rest is optional, but I see no reason to not enable it per default.
should this maybe be a cmos option instead? Some old drives (being present in old machines) might not work with the setting.
On the long run, yes. IMO we should automatically "extract" a CMOS option out of these config variables. All of them make run-time decisions in the code already -> perfect for CMOS options.
For now I'd like to commit as is, there's no CMOS support on 440BX boards anyway at the moment, and ide_legacy_enable = 1 is really needed to be able to use FILO.
Uwe.
Updated patch. It enableѕ legacy I/O port access, but disables UDMA/33 per default as we don't know if the user's devices support it.
Uwe.
On 17.12.2007 22:05, Uwe Hermann wrote:
Enable IDE legacy port access for all 440BX based boards per default, as this is needed (at the very least) to make FILO work on these boards.
Disable UDMA/33 per default, which is slower but the safe choice, as we don't know which IDE devices a user has attached, and some don't support UDMA/33 very well or at all.
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Regards, Carl-Daniel
On Mon, Dec 17, 2007 at 10:11:16PM +0100, Carl-Daniel Hailfinger wrote:
On 17.12.2007 22:05, Uwe Hermann wrote:
Enable IDE legacy port access for all 440BX based boards per default, as this is needed (at the very least) to make FILO work on these boards.
Disable UDMA/33 per default, which is slower but the safe choice, as we don't know which IDE devices a user has attached, and some don't support UDMA/33 very well or at all.
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Thanks, r3010.
Uwe.