windows XP boots with ACPI HAL

[Rudolf Marek]

Hi all,

I had a time and finally Windows XP boots with Coreboot + Seabios. In fact it 
was a clean install of WXP SP2. All went fine, windows work.

I'm attaching two patches. The first (acpi-fixes2) fixes the ACPI related 
problems. Some of them were identified previously by Kevin. I had just solve 
right _CRS reporting for PCI0 (as required by windows). This is accomplished 
with the k8-utils.asl code from Aruma. There was some problem, which I fixed 
simply by deleting that section of the code. I used acpiexec from ACPICA tools 
to debug the ACPI code (acpica-unix-20081204/tools/acpiexec).

What was the missing part? Windows requires right _CRS reporting of PCI0 bus. 
Windows needs to know platform independent way, how is I/O routed on PCI0 bus 
(and other busses). For K8 it means to read the I/O and MMIO routing registers 
(same as k8resdump provides) and make it ACPI object. This was perhaps done 
previously on Aruma board. The actual PCI regs are read in acpi-k8 in modelf and 
stored as SSDT table. The k8-util.asl code will construct the resources from 
that SSDT table. The only catch was that it orinally added for SB also a 
resource from TOM to PCI0_min. Which was invalid. This part was simply deleted 
as I did not need it and it was wrong anyway.

The k8-util file is copyright by AMD but no licence. I just deleted small part 
so I did not added myself there.

The attached patch fixes:
The FADT bootarch flags
Blacklists MSI for this chipset (maybe not needed)
Adds modified amdk8_util.asl
Adds the SSDT table to chain of tables
Aligns the FACS correctly (this should be done for other boards)
Adds the _CRS method to Asus M2V-MX SE acpi DSDT.
Fixes the FACS table length.

The second patch just monitors what else is needed to be able to boot SeaBIOS 
with ACPI and K8M890 VGA ROM.

Signed-off-by: Rudolf Marek

Thanks,
Rudolf

[Myles Watson]

> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]]
> On Behalf Of Rudolf Marek
> Sent: Sunday, December 21, 2008 3:37 PM
> To: Coreboot
> Cc: Kevin O'Connor
> Subject: [coreboot] windows XP boots with ACPI HAL
>
> Hi all,
>
> I had a time and finally Windows XP boots with Coreboot + Seabios. In fact
> it
> was a clean install of WXP SP2. All went fine, windows work.
>
> I'm attaching two patches. The first (acpi-fixes2) fixes the ACPI related
> problems. Some of them were identified previously by Kevin. I had just
> solve
> right _CRS reporting for PCI0 (as required by windows). This is
> accomplished
> with the k8-utils.asl code from Aruma. There was some problem, which I
> fixed
> simply by deleting that section of the code. I used acpiexec from ACPICA
> tools
> to debug the ACPI code (acpica-unix-20081204/tools/acpiexec).
>
> What was the missing part? Windows requires right _CRS reporting of PCI0
> bus.
> Windows needs to know platform independent way, how is I/O routed on PCI0
> bus
> (and other busses). For K8 it means to read the I/O and MMIO routing
> registers
> (same as k8resdump provides) and make it ACPI object. This was perhaps
> done
> previously on Aruma board. The actual PCI regs are read in acpi-k8 in
> modelf and
> stored as SSDT table. The k8-util.asl code will construct the resources
> from
> that SSDT table. The only catch was that it orinally added for SB also a
> resource from TOM to PCI0_min. Which was invalid. This part was simply
> deleted
> as I did not need it and it was wrong anyway.
>
> The k8-util file is copyright by AMD but no licence. I just deleted small
> part
> so I did not added myself there.
>
> The attached patch fixes:
> The FADT bootarch flags
> Blacklists MSI for this chipset (maybe not needed)

How could you test this?
> Adds modified amdk8_util.asl
> Adds the SSDT table to chain of tables
> Aligns the FACS correctly (this should be done for other boards)

Should we put your align macros somewhere so all boards can use them?
> Adds the _CRS method to Asus M2V-MX SE acpi DSDT.
> Fixes the FACS table length.
>
> The second patch just monitors what else is needed to be able to boot
> SeaBIOS
> with ACPI and K8M890 VGA ROM.
>
> Signed-off-by: Rudolf Marek

Can we be sure about blacklisting MSI?

Everything else:
Acked-by: Myles Watson

Thanks,
Myles

[Rudolf Marek]

> > The attached patch fixes:
> > The FADT bootarch flags
> > Blacklists MSI for this chipset (maybe not needed)
>
> How could you test this?

Well with some PCIe device which uses MSI. MSI had some bug on K8T890. MSI is 
not mandatory.
> > Adds modified amdk8_util.asl
> > Adds the SSDT table to chain of tables
> > Aligns the FACS correctly (this should be done for other boards)
>
> Should we put your align macros somewhere so all boards can use them?

Yes perhaps. I will change that.
> Can we be sure about blacklisting MSI?

Yes we can. It does no harm.

Rudolf

[ron minnich]

On Tue, Dec 23, 2008 at 8:27 AM, Rudolf Marek  wrote:
> Yes we can. It does no harm.

I'm sorry, I don't understand this comment w.r.t. "blacklisting" MSI.
MSI will work correctly, right?

ron

[Rudolf Marek]

ron minnich wrote:
> On Tue, Dec 23, 2008 at 8:27 AM, Rudolf Marek  wrote:
> > Yes we can. It does no harm.
>
> I'm sorry, I don't understand this comment w.r.t. "blacklisting" MSI.
> MSI will work correctly, right?

The K8T890 had some bug. This board has no card which can do MSI. So I cannot 
test. I think we can "blacklist" this and when I test this - unblacklist that again.

Rudolf

[Rudolf Marek]

Ok its commited. I fixed bit indent and one small typo. Also I moved the ALIGN 
macro to our macro store.

Committed revision 3840.
Thanks,
Rudolf

[Peter Stuge]

Rudolf Marek wrote:
> Committed revision 3840.

Very cool indeed! Thanks a lot!

Now, how can we create all that ACPI stuff automatically? :)

//Peter

[Carl-Daniel Hailfinger]

On 23.12.2008 18:35, Rudolf Marek wrote:
> Ok its commited. I fixed bit indent and one small typo. Also I moved
> the ALIGN macro to our macro store.

Awesome! Thanks for getting Vista to run, even if you don't like it
personally.

Regards,
Carl-Daniel

[Rudolf Marek]

Hi all,

Thanks for your all your thank you to me ;)

Rudolf

[aaron lwe]

On Mon, Dec 22, 2008 at 6:36 AM, Rudolf Marek  wrote:
> Hi all,
>
> I had a time and finally Windows XP boots with Coreboot + Seabios. In fact
> it was a clean install of WXP SP2. All went fine, windows work.

Hi Rudolf,
Several months ago, I've tried ADLO(when SeaBIOS just showed up) with
coreboot and make it install without ACPI, none of the pci devices are
recognized by Windows. And if added ACPI table, XP would simply refuse
to install.
Now you made it work, this is really good news and pretty cool!