Re: [coreboot] New patch to review for coreboot: 1c4e003 Fixed broken MTRR for >4GB memory on AMD K8 fam 0fh rev <=E - coreboot

6 Oct 2011

      On 10/06/2011 06:51 PM, yhlu wrote:
...
On Thu, Oct 6, 2011 at 9:26 AM, Oskar Enokssongerrit@coreboot.org  wrote:
...

  // Test if this CPU is a Fam 0Fh rev. F or later

  const int is_revF =

          ((cpuid_eax(0x80000001)&0x00000f00)>>8>= 0xf) ||

          (((cpuid_eax(0x80000001)&0x00000f00)>>8 == 0xf)&&

           ((cpuid_eax(0x80000001)&0x000f0000)>>16>= 0x4));

  if(is_revF)

          printk(BIOS_DEBUG, "Detected CPU Fam 0Fh rev.F or later\n");

should be configuration option instead of run-time checking.
There is no MB that will support revE and revF at same time. they are
different sockets
Yinghai
So, is it CONFIG_K8_REV_F_SUPPORT == 1 I should use?