[PATCH] v3: create dbe61 dts equivalent to v2 Config.lb

[Carl-Daniel Hailfinger]

Modify the artecgroup/dbe61 dts to be equivalent to v2 Config.lb. The 
target does not yet compile due to initram breakage, but the breakage is 
really old.

Signed-off-by: Carl-Daniel Hailfinger

Index: LinuxBIOSv3-dbe61/mainboard/artecgroup/dbe61/dts
===================================================================
--- LinuxBIOSv3-dbe61/mainboard/artecgroup/dbe61/dts	(revision 607)
+++ LinuxBIOSv3-dbe61/mainboard/artecgroup/dbe61/dts	(working copy)
@@ -84,8 +84,26 @@
    	pci@1,0 {
    		/config/("northbridge/amd/geodelx/pci");
    	};
-		pci@1,1 {
+		pci@15,0 {
    		/config/("southbridge/amd/cs5536/dts");
+			/* Interrupt enables for LPC bus.
+			 *  Each bit is an IRQ 0-15. */
+			lpc_serirq_enable = "0x00001002";
+			/* LPC IRQ polarity. Each bit is an IRQ 0-15. */
+			lpc_serirq_polarity = "0x0000effd";
+			/* 0:continuous 1:quiet */
+			lpc_serirq_mode = "1";
+			/* GPIO(0-0x20) for INT D:C:B:A, 0xFF=none. 
+			 * See virtual PIC spec. */
+			enable_gpio_int_route = "0x0D0C0700";
+			/* COM1 settings */
+			com1_enable = "0";
+			com1_address = "0x2f8";
+			com1_irq = "3";
+			/* COM2 settings */
+			com2_enable = "1";
+			com2_address = "0x3f8";
+			com2_irq = "4";
    	};
    };
 };

[Marc Jones]

Carl-Daniel Hailfinger wrote:
> Modify the artecgroup/dbe61 dts to be equivalent to v2 Config.lb. The 
> target does not yet compile due to initram breakage, but the breakage is 
> really old.
>
> Signed-off-by: Carl-Daniel Hailfinger

We(I) need to work with Artec on the initram breakage at some point....

Acked-by: Marc Jones

[PATCH] v3: create dbe61 dts equivalent to v2 Config.lb

[ron minnich]

I'm going to start on the artec this week as well. Marc, you have one, right?

ron

[Marc Jones]

ron minnich wrote:
> I'm going to start on the artec this week as well. Marc, you have one, right?
>
> ron

Yes, in v2 we never got through the memory settings correct.
Marc

[PATCH] v3: create dbe61 dts equivalent to v2 Config.lb

[ron minnich]

On Feb 18, 2008 9:11 AM, Marc Jones  wrote:
> Yes, in v2 we never got through the memory settings correct.

OK, does it use SMBUS or not?

I'm ready to go, will set it up on workbench tonight. I am going to
pause alix1c for a bit as it is working so well, it gets a rest as a
reward. BTW, alix1c is a real joy to develop for, due to LPC FLASH
board you can get. It's a really great board -- though I expect the
thincan to be just as good.

ron

[PATCH] v3: create dbe61 dts equivalent to v2 Config.lb

[Carl-Daniel Hailfinger]

On 18.02.2008 18:11, Marc Jones wrote:
> ron minnich wrote:
> > I'm going to start on the artec this week as well. Marc, you have one, right?
>
> Yes, in v2 we never got through the memory settings correct.

The dbe61 initram code in v3 seems to be in a rather bad shape. Is there 
any reason we can't drop it and use the alix1c initram code as template?

Regards,
Carl-Daniel

[PATCH] v3: create dbe61 dts equivalent to v2 Config.lb

[ron minnich]

On Feb 18, 2008 9:28 AM, Carl-Daniel Hailfinger
 wrote:
> The dbe61 initram code in v3 seems to be in a rather bad shape. Is there
> any reason we can't drop it and use the alix1c initram code as template?

That seems like a reasonable idea to me.

The alix1c code is pretty flexible.

ron

[Marc Jones]

ron minnich wrote:
> On Feb 18, 2008 9:28 AM, Carl-Daniel Hailfinger
>  wrote:
> > The dbe61 initram code in v3 seems to be in a rather bad shape. Is there
> > any reason we can't drop it and use the alix1c initram code as template?
>
> That seems like a reasonable idea to me.
>
> The alix1c code is pretty flexible.
>
> ron

The dbe61 doesn't have a SPD for the memory, so I started to go the 
table route but never got it working. I think we can figure it out from 
a working ROM.  The other special thing they do is use the DDC pins on 
the VGA connector for serial. Using the alix1c initram would be a good 
place to start because it is so clean and simple.

Marc

[PATCH] v3: create dbe61 dts equivalent to v2 Config.lb

[Carl-Daniel Hailfinger]

On 18.02.2008 18:53, Marc Jones wrote:
> ron minnich wrote:
> > On Feb 18, 2008 9:28 AM, Carl-Daniel Hailfinger wrote:
> > > The dbe61 initram code in v3 seems to be in a rather bad shape. Is there
> > > any reason we can't drop it and use the alix1c initram code as template?
> >
> > That seems like a reasonable idea to me.
> >
> > The alix1c code is pretty flexible.
>
> The dbe61 doesn't have a SPD for the memory, so I started to go the 
> table route but never got it working. I think we can figure it out from 
> a working ROM.  The other special thing they do is use the DDC pins on 
> the VGA connector for serial. Using the alix1c initram would be a good 
> place to start because it is so clean and simple.

I just used the alix1c initram code for the dbe61 and the patch below it 
at least compiled. That's quite a bit of progress.

Regards,
Carl-Daniel

Add northbridge/amd/geodelx/raminit.c to the Artecgroup DBE61 makefile.
Completely replace DBE61 initram code by Alix.1C initram code.

svn rm mainboard/artecgroup/dbe61/initram.c

svn cp mainboard/pcengines/alix1c/initram.c mainboard/artecgroup/dbe61/initram.c

Signed-off-by: Carl-Daniel Hailfinger

Index: LinuxBIOSv3-dbe61/mainboard/artecgroup/dbe61/Makefile
===================================================================
--- LinuxBIOSv3-dbe61/mainboard/artecgroup/dbe61/Makefile	(revision 609)
+++ LinuxBIOSv3-dbe61/mainboard/artecgroup/dbe61/Makefile	(working copy)
@@ -22,6 +22,7 @@
 STAGE0_MAINBOARD_OBJ := $(obj)/mainboard/$(MAINBOARDDIR)/stage1.o

INITRAM_OBJ =   $(src)/mainboard/$(MAINBOARDDIR)/initram.c \
+		$(src)/northbridge/amd/geodelx/raminit.c \
    	$(src)/arch/x86/geodelx/geodelx.c

STAGE2_MAINBOARD_OBJ =

[PATCH] v3: create dbe61 dts equivalent to v2 Config.lb

[ron minnich]

Acked-off-by: Ronald G. Minnich <[e-mail]

Thanks!

ron

[PATCH] v3: create dbe61 dts equivalent to v2 Config.lb

[Carl-Daniel Hailfinger]

On 18.02.2008 21:23, ron minnich wrote:
> Acked-by: Ronald G. Minnich
>
> Thanks!

Thanks for reviewing! Committed in r610.

Regards,
Carl-Daniel

[PATCH] v3: create dbe61 dts equivalent to v2 Config.lb

[Peter Stuge]

On Mon, Feb 18, 2008 at 10:53:07AM -0700, Marc Jones wrote:
> The other special thing they do is use the DDC pins on the VGA
> connector for serial.

Is this their idea or from the 5536?

Anyway, I got the pins for last LinuxTag where I made a cable for
Stefan. Let me know if you need and I'll dig them up.

//Peter

[Marc Jones]

Peter Stuge wrote:
> On Mon, Feb 18, 2008 at 10:53:07AM -0700, Marc Jones wrote:
> > The other special thing they do is use the DDC pins on the VGA
> > connector for serial.
>
> Is this their idea or from the 5536?
>
> Anyway, I got the pins for last LinuxTag where I made a cable for
> Stefan. Let me know if you need and I'll dig them up.
>
> //Peter

It is a 5536 feature. I was just noting that it needs to be setup and 
that it is a little more challenging to debug. You need a special dongle.

Marc

[PATCH] v3: create dbe61 dts equivalent to v2 Config.lb

[Mart Raudsepp]

Ühel kenal päeval, E, 2008-02-18 kell 17:41, kirjutas Marc Jones:
> Peter Stuge wrote:
> > On Mon, Feb 18, 2008 at 10:53:07AM -0700, Marc Jones wrote:
> > > The other special thing they do is use the DDC pins on the VGA
> > > connector for serial.
> >
> > Is this their idea or from the 5536?
> >
> > Anyway, I got the pins for last LinuxTag where I made a cable for
> > Stefan. Let me know if you need and I'll dig them up.
> >
> > //Peter
>
> It is a 5536 feature. I was just noting that it needs to be setup and 
> that it is a little more challenging to debug. You need a special dongle.

Note that on the DBE62 we have the possibility to optionally have a
daughterboard that has a dedicated serial port. For these, having the
DDC work (serial port not set up on DDC pins) would be the preferred
way. Sometimes that's the preferred way for other boards too, to have
nicely working DDC.
So basically it would be nice if setting up the serial port on DDC pins
would be a configurable thing.

Regards,
Mart Raudsepp,
Artec Design LLC

[PATCH] v3: create dbe61 dts equivalent to v2 Config.lb

[ron minnich]

On Feb 18, 2008 11:01 PM, Mart Raudsepp  wrote:
> So basically it would be nice if setting up the serial port on DDC pins
> would be a configurable thing.

configurable each time you boot, or configurable when you build?

For "each time you boot", could we use CMOS settings?

ron

[PATCH] v3: create dbe61 dts equivalent to v2 Config.lb

[Mart Raudsepp]

Ühel kenal päeval, E, 2008-02-18 kell 23:08, kirjutas ron minnich:
> On Feb 18, 2008 11:01 PM, Mart Raudsepp  wrote:
> > So basically it would be nice if setting up the serial port on DDC pins
> > would be a configurable thing.
>
> configurable each time you boot, or configurable when you build?

Configurable when you build right now
> For "each time you boot", could we use CMOS settings?

We don't have a RTC/CMOS battery in all models, so I think it wouldn't
work out for all cases. However a means to override the build default
defined setup in CMOS settings sounds nice for the models where that
setting can be stored.

[PATCH] v3: create dbe61 dts equivalent to v2 Config.lb

[Peter Stuge]

On Tue, Feb 19, 2008 at 09:17:17AM +0200, Mart Raudsepp wrote:
> > > So basically it would be nice if setting up the serial port on
> > > DDC pins would be a configurable thing.

As it should be! The 5536 code needs to learn how to control it, and
there could be a setting in the dts - for starters.

Or should the setting be in Kconfig? Hm. Both are good candidates.
> > For "each time you boot", could we use CMOS settings?
>
> We don't have a RTC/CMOS battery in all models, so I think it
> wouldn't work out for all cases. However a means to override the
> build default defined setup in CMOS settings sounds nice for the
> models where that setting can be stored.

I've also been thinking about storing boot settings in the flash
rather than battery-backed NVRAM.

//Peter

[PATCH] v3: create dbe61 dts equivalent to v2 Config.lb

[ron minnich]

I think we should store boot settings in a LAR file.

Just simple keyword value pairs
serial=

etc. etc.

The question is, when do we read/parse/act on this file? We could do
it at any time.

E.g. the serial port stuff could be done in initram, etc.

ron

[PATCH] v3: create dbe61 dts equivalent to v2 Config.lb

[Carl-Daniel Hailfinger]

On 18.02.2008 17:46, Marc Jones wrote:
> Carl-Daniel Hailfinger wrote:
> > Modify the artecgroup/dbe61 dts to be equivalent to v2 Config.lb. The 
> > target does not yet compile due to initram breakage, but the breakage is 
> > really old.
> >
> > Signed-off-by: Carl-Daniel Hailfinger
>
> We(I) need to work with Artec on the initram breakage at some point....
>
> Acked-by: Marc Jones

Thanks, r609.

Regards,
Carl-Daniel