Fwd: mkelfImage

[Martin-Éric Racine]

---------- Forwarded message ----------
From: Martin-Éric Racine 
Date: Jul 19, 2007 7:59 PM
Subject: mkelfImage
To: Eric Biederman , Joshua Aune

Greetings,

Being in the process of packaging mkelfImage for Debian and Ubuntu, I
 came across a few issues that definitely will prevent this software
 from being accepted by the FTP Master.

Thankfully, most of them are easily fixed:

* News should be called ChangeLog and include the name of whoever made
 each change.
 * Each source file (c, h, S) must include proper copyright notice and
 credits at the top.
 * The build fails unless it is ./configure'd twice, because it misses
 Makefile.conf.
 * Makefile.conf would preferably be replaced by more traditional
 Makefile.am and Mafefile.in to really be portable.
 * config.log and various other files that should be cleaned before
 shipping were found in the archive for mkelfImage 2.7 on the lnxi FTP
 server.
 * The filename of the archive should be all lowercase.

However, a more serious problem is that it fails to compile using
 recent GCC and glibc6.

Would it be possible for this package to be updated keeping in mind
 the above issues?

Best regards,

[Stefan Reinauer]

* Martin-Éric Racine  [080215 19:34]:
> Thankfully, most of them are easily fixed:
> News should be called ChangeLog and include the name of whoever made
>
> each change.
> Each source file (c, h, S) must include proper copyright notice and
>
> credits at the top.
> The build fails unless it is ./configure'd twice, because it misses
>
> Makefile.conf.
> Makefile.conf would preferably be replaced by more traditional
>
> Makefile.am and Mafefile.in to really be portable.
> config.log and various other files that should be cleaned before
>
> shipping were found in the archive for mkelfImage 2.7 on the lnxi FTP
>  server.
> The filename of the archive should be all lowercase.

Is there a patch available for these issues? We pulled mkelfImage into
svn now, so we could fix it there.
> However, a more serious problem is that it fails to compile using
>  recent GCC and glibc6.

any details? I had no problems compiling it with 
GNU C Library stable release version 2.7 (20071106)
gcc version 4.3.0 20080131 (experimental) [trunk revision 131976] (SUSE Linux)

Stefan

[Roman Kononov]

On 2008-02-19 07:36 Stefan Reinauer said the following:
> any details? I had no problems compiling it with 
> GNU C Library stable release version 2.7 (20071106)
> gcc version 4.3.0 20080131 (experimental) [trunk revision 131976] (SUSE Linux)

This is what I get building it on the default installation of Ubuntu.

Roman
------------------------------------
~/mkelfImage-2.7>uname -a
Linux aaa 2.6.22-14-generic #1 SMP Tue Feb 12 02:46:46 UTC 2008 x86_64 
GNU/Linux

~/mkelfImage-2.7>cat /etc/issue
Ubuntu 7.10

~/mkelfImage-2.7>dpkg --status libc6 | grep Version
Version: 2.6.1-1ubuntu10

~/mkelfImage-2.7>gcc --version
gcc (GCC) 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2)

~/mkelfImage-2.7>./configure
...

~/mkelfImage-2.7>make
mkdir -p objdir/main
gcc -O2 -Wall -DVERSION='"2.7"' -DRELEASE_DATE='"27 March 2006"' -I 
include  -DPACKAGE_NAME="" -DPACKAGE_TARNAME="" 
-DPACKAGE_VERSION="" -DPACKAGE_STRING="" -DPACKAGE_BUGREPORT="" 
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_ZLIB_H=1 
  -c main/mkelfImage.c -o objdir/main/mkelfImage.o
mkdir -p objdir/linux-i386
gcc -m32 -Os -ffreestanding -Wall -W -Wno-format -DVERSION='"2.7"' 
-DRELEASE_DATE='"27 March 2006"' -I include -I arch/i386/include -c -o 
objdir/linux-i386/convert_params.o linux-i386/convert_params.c
linux-i386/convert_params.c:15: warning: pointer targets in 
initialization differ in signedness
linux-i386/convert_params.c: In function ‘append_command_line’:
linux-i386/convert_params.c:492: warning: pointer targets in passing 
argument 1 of ‘strnlen’ differ in signedness
linux-i386/convert_params.c:493: warning: pointer targets in assignment 
differ in signedness
linux-i386/convert_params.c: In function ‘count_elf_notes’:
linux-i386/convert_params.c:818: warning: pointer targets in assignment 
differ in signedness
linux-i386/convert_params.c:819: warning: pointer targets in assignment 
differ in signedness
linux-i386/convert_params.c: In function ‘find_elf_note’:
linux-i386/convert_params.c:850: warning: pointer targets in assignment 
differ in signedness
linux-i386/convert_params.c:851: warning: pointer targets in assignment 
differ in signedness
linux-i386/convert_params.c: In function ‘convert_elf_command_line’:
linux-i386/convert_params.c:874: warning: pointer targets in passing 
argument 2 of ‘append_command_line’ differ in signedness
linux-i386/convert_params.c: At top level:
linux-i386/convert_params.c:884: warning: pointer targets in 
initialization differ in signedness
linux-i386/convert_params.c: In function ‘convert_elf_boot’:
linux-i386/convert_params.c:890: warning: pointer targets in assignment 
differ in signedness
linux-i386/convert_params.c:891: warning: pointer targets in assignment 
differ in signedness
linux-i386/convert_params.c: In function ‘bootloader_query_firmware_class’:
linux-i386/convert_params.c:1224: warning: pointer targets in assignment 
differ in signedness
linux-i386/convert_params.c: In function ‘initialize_linux_params’:
linux-i386/convert_params.c:1466: warning: pointer targets in passing 
argument 1 of ‘strnlen’ differ in signedness
mkdir -p objdir/linux-i386
ld -static --warn-multiple-gp --warn-common -T linux-i386/convert.lds -o 
objdir/linux-i386/convert objdir/linux-i386/head.o 
objdir/linux-i386/convert_params.o
objdir/linux-i386/convert_params.o: In function `printf':
convert_params.c:(.text+0x662): undefined reference to `__stack_chk_fail'
make: *** [objdir/linux-i386/convert] Error 1

[Stefan Reinauer]

* Roman Kononov  [080219 16:12]:
> On 2008-02-19 07:36 Stefan Reinauer said the following:
> > any details? I had no problems compiling it with GNU C Library stable 
> > release version 2.7 (20071106)
> > gcc version 4.3.0 20080131 (experimental) [trunk revision 131976] (SUSE Linux)
>
> This is what I get building it on the default installation of Ubuntu.

Ah, Ubuntu's broken gcc needs -fno-stack-protector

[Martin-Éric Racine]

On 2/19/08, Stefan Reinauer  wrote:
> Roman Kononov  [080219 16:12]:
> > On 2008-02-19 07:36 Stefan Reinauer said the following:
> > > any details? I had no problems compiling it with GNU C Library stable
> > > release version 2.7 (20071106)
> > > gcc version 4.3.0 20080131 (experimental) [trunk revision 131976] (SUSE Linux)
> >
> > This is what I get building it on the default installation of Ubuntu.
>
> Ah, Ubuntu's broken gcc needs -fno-stack-protector

As far as I know, this has already been implemented in Debian. Ubuntu
might be lagging behind on this particular issue.

[Jordan Crouse]

On 19/02/08 19:09 +0200, Martin-Éric Racine wrote:
> On 2/19/08, Stefan Reinauer  wrote:
> > Roman Kononov  [080219 16:12]:
> > > On 2008-02-19 07:36 Stefan Reinauer said the following:
> > > > any details? I had no problems compiling it with GNU C Library stable
> > > > release version 2.7 (20071106)
> > > > gcc version 4.3.0 20080131 (experimental) [trunk revision 131976] (SUSE Linux)
> > >
> > > This is what I get building it on the default installation of Ubuntu.
> >
> > Ah, Ubuntu's broken gcc needs -fno-stack-protector
>
> As far as I know, this has already been implemented in Debian. Ubuntu
> might be lagging behind on this particular issue.

We understand the problem very clearly, thank you.  But this isn't something
to be solved in the mkelfimage package.

Jordan

[Martin-Éric Racine]

On 2/19/08, Jordan Crouse  wrote:
> On 19/02/08 19:09 +0200, Martin-Éric Racine wrote:
> > On 2/19/08, Stefan Reinauer  wrote:
> > > Roman Kononov  [080219 16:12]:
> > > > On 2008-02-19 07:36 Stefan Reinauer said the following:
> > > > > any details? I had no problems compiling it with GNU C Library stable
> > > > > release version 2.7 (20071106)
> > > > > gcc version 4.3.0 20080131 (experimental) [trunk revision 131976] (SUSE Linux)
> > > >
> > > > This is what I get building it on the default installation of Ubuntu.
> > >
> > > Ah, Ubuntu's broken gcc needs -fno-stack-protector
> >
> > As far as I know, this has already been implemented in Debian. Ubuntu
> > might be lagging behind on this particular issue.
>
> We understand the problem very clearly, thank you.  But this isn't something
> to be solved in the mkelfimage package.

Indeed, but it's still a good idea to remind Ubuntu that their choices
break some packages' build and to expect them to fix it themselves.

[Martin-Éric Racine]

On 2/19/08, Stefan Reinauer  wrote:
> Martin-Éric Racine  [080215 19:34]:
> > Thankfully, most of them are easily fixed:
> > News should be called ChangeLog and include the name of whoever made
> >
> > each change.
> > Each source file (c, h, S) must include proper copyright notice and
> >
> > credits at the top.
> > The build fails unless it is ./configure'd twice, because it misses
> >
> > Makefile.conf.
> > Makefile.conf would preferably be replaced by more traditional
> >
> > Makefile.am and Mafefile.in to really be portable.
> > config.log and various other files that should be cleaned before
> >
> > shipping were found in the archive for mkelfImage 2.7 on the lnxi FTP
> >  server.
> > The filename of the archive should be all lowercase.
>
> Is there a patch available for these issues? We pulled mkelfImage into
> svn now, so we could fix it there.

Good to know. I can patch a few of these issues, but not all of them,
as I'm not exactly an autotools guru. I'll pull from SVN and get
started.
> > However, a more serious problem is that it fails to compile using
> >  recent GCC and glibc6.
>
> any details? I had no problems compiling it with
> GNU C Library stable release version 2.7 (20071106)
> gcc version 4.3.0 20080131 (experimental) [trunk revision 131976] (SUSE Linux)

See the other reply for a sample log of this failure.