CAR vs. non-CAR ck804 bringup

[Myles Watson]

I'd like to unify the ck804_early_setup[_car].c files.  The differences are
very minor, as you can see from ck804.  This patch applies after removing
the CK804B defines since they are copies of other defines (with the same
values) car_white.diff.

Questions:
1. What is PANTA, and why is it commented out in CAR but enabled in the
other?
2. Why was SATA on dev 7 enabled in non-CAR but not CAR?

I've tried it out on the s2892, but since I don't know exactly what to
test...

Signed-off-by: Myles Watson

Thanks,
Myles

[Myles Watson]

On Wed, Jul 8, 2009 at 4:12 PM, Myles Watson  wrote:
> I'd like to unify the ck804_early_setup[_car].c files.  The differences are
> very minor, as you can see from ck804.  This patch applies after removing
> the CK804B defines since they are copies of other defines (with the same
> values) car_white.diff.

clear as mud.

car_white.diff is the patch which just rearranges things.  car_code.diff has
the actual differences.

Thanks,
Myles

[ron minnich]

On Wed, Jul 8, 2009 at 3:12 PM, Myles Watson wrote:
> Questions:
> What is PANTA, and why is it commented out in CAR but enabled in the
>
> other?

A dead system/company. One of the coreboot guys worked there very
briefly. Not to worry about.
> Why was SATA on dev 7 enabled in non-CAR but not CAR?

not sure.

ron

[Myles Watson]

On Wed, Jul 8, 2009 at 4:17 PM, ron minnich  wrote:
> On Wed, Jul 8, 2009 at 3:12 PM, Myles Watson wrote:
> > Questions:
> > What is PANTA, and why is it commented out in CAR but enabled in the
> >
> > other?
>
> A dead system/company. One of the coreboot guys worked there very
> briefly. Not to worry about.

So if a setting is commented out with //PANTA, we should uncomment it?  I'm
assuming that means it needed to be commented out for a PANTA system.

Thanks,
Myles

[ron minnich]

On Wed, Jul 8, 2009 at 3:19 PM, Myles Watson wrote:
> So if a setting is commented out with //PANTA, we should uncomment it?  I'm
> assuming that means it needed to be commented out for a PANTA system.

that sounds right, but yinghai can tell us for sure.

ron