Add support for K8T890CF, VT8237A and ASUS M2V board.
Needs crosschecking on VT8237R and VT8237S, since I had to touch some common codepaths like in src/southbridge/via/vt8237r/vt8237r_early_smbus.c Also because of the changed PCIe init code.
Stupid issues that caused way too much (~1 day) headscratching until fixed: - I forgot to add the pci id in vt8237r_lpc.c: It was booting, but interrupts didn't work - I didn't have the 13.0 and 13.1 bridges in devicetree.cb: Linux saw the 13.0 bridge, but not the coreboot device scan. When enabling the 13.1 bridge, VGA init failed, since coreboot didn't see and initialize the bridge.
Tested: - Linux boot (ACPI, APIC and LAPIC enabled) with acpi/mptables-enabled coreboot - HPET (detected and seems to work) - Serial port works - PCI slot irq routing works - PCIe slot irq routing works - MMCONFIG for extended pcie config space works - Booting from IDE HDD/CDROM works - Seabios won't boot from SATA, but both SATA controllers work in Linux - All 8 USB ports work
FIXME: - PCIe doesn't get initialized on cold boot, only works when warm rebooting into Coreboot from Machine booted by AMI BIOS Someone with Datasheets needs to have a look I think - Onboard sound spews lots of "hda-intel: spurious response" messages and times out eventually. So for now we disable the bridge - VLINK settings works for me, but I don't have Datasheets
Signed-Off-By: Tobias Diedrich ranma+coreboot@tdiedrich.de ---
Tobias Diedrich wrote:
Add support for K8T890CF, VT8237A and ASUS M2V board.
I would very much like to have a series of different patches rather than a single big one for this. It allows people to review your changes in bite size chunks in case they do not have very many hours of free time available.
Tested:
Nice!
FIXME:
- PCIe doesn't get initialized on cold boot, only works when warm rebooting into Coreboot from Machine booted by AMI BIOS Someone with Datasheets needs to have a look I think
I think this needs to be sorted out. Can you look into what registers are different from coreboot-only to AMI or even AMI-reset-coreboot?
- Onboard sound spews lots of "hda-intel: spurious response" messages and times out eventually. So for now we disable the bridge
This is also not so nice. Can it be fixed? Who knows a bit about the azalia stuff? I think there is known good azalia setup in the i945 code. Maybe compare that with what the code for the via does?
- VLINK settings works for me, but I don't have Datasheets
Again maybe you can play with VLINK settings in AMI BIOS and compare northbridge config space values?
This is really close to being completely done! It would be awesome to have the last issues ironed out, and a series of patches to make review manageable.
//Peter