[LinuxBIOS] [flashrom] patch: more verbose output in case of known vendor but unknown chip-id

[Peter Lemenkov]

Hello All!
This patch just adds a small banner with message to user. I think its
a good idea to ask user to send us a message about situation with
known vendor id but unknown chip id.

Signed-off-by: Peter Lemenkov 
---

[Carl-Daniel Hailfinger]

On 22.10.2007 21:29, Peter Lemenkov wrote:
> Hello All!
> This patch just adds a small banner with message to user. I think its
> a good idea to ask user to send us a message about situation with
> known vendor id but unknown chip id.
>
> Signed-off-by: Peter Lemenkov

This patch will not do what you want. It will issue that warning for
almost every probed chip.

I agree that the idea is nice, but you have to restructure probing for
this to work well. Basically, you can't probe for specific chips
anymore, but you have to change the probing routines to return the chip
ID they found and compare them centrally. This not only decreases
probing time, it also increases the chance to spot unsupported chips.

Regards,
Carl-Daniel

[LinuxBIOS] [flashrom] patch: more verbose output in case of known vendor but unknown chip-id

[Peter Lemenkov]

2007/10/23, Carl-Daniel Hailfinger :
> This patch will not do what you want. It will issue that warning for
> almost every probed chip.
>
> I agree that the idea is nice, but you have to restructure probing for
> this to work well. Basically, you can't probe for specific chips
> anymore, but you have to change the probing routines to return the chip
> ID they found and compare them centrally. This not only decreases
> probing time, it also increases the chance to spot unsupported chips.

OK, I'll rewrite it.