Re: [LinuxBIOS] [PATCH] flashrom: Support for MCP55 and SST49LFXXXC chips

[Lu, Yinghai]

>      {0x10de, 0x0261, "NVidia MCP51", enable_flash_ck804},
> // {0x10de, 0x0261, "NVIDIA C51",   enable_flash_ck804}, // YHLU

Flash is on mcp51 instead of c51.

YH

-----Original Message-----
From: linuxbios-bounces+yinghai.lu=[e-mail]
[mailto:linuxbios-bounces+yinghai.lu=[e-mail]] On Behalf Of
Carl-Daniel Hailfinger
Sent: Tuesday, January 23, 2007 2:53 PM
To: Uwe Hermann
Cc: [e-mail]
Subject: Re: [LinuxBIOS] [PATCH] flashrom: Support for MCP55 and
SST49LFXXXC chips

Hi Uwe,

Uwe Hermann wrote:
> Add support for the SST-49LF004C, SST-49LF008C, SST-49LF016C in

flashrom.
> Also add suport for NVIDIA MCP55.
>
> I tried to extract only the relevant changes out of Yinghai's code.
> Please review (especially check whether I forgot some code) and test
> whether it works.
> --- util/flashrom/flash_enable.c	(Revision 2536)
> +++ util/flashrom/flash_enable.c	(Arbeitskopie)
> @@ -432,9 +472,13 @@
>      {0x10de, 0x0260, "NVidia MCP51", enable_flash_ck804},
>      {0x10de, 0x0261, "NVidia MCP51", enable_flash_ck804},
> // {0x10de, 0x0261, "NVIDIA C51",   enable_flash_ck804}, // YHLU
>     {0x10de, 0x0262, "NVidia MCP51", enable_flash_ck804},
>     {0x10de, 0x0263, "NVidia MCP51", enable_flash_ck804},

Why did you comment out this PCI ID combination?

Regards,
Carl-Daniel

[LinuxBIOS] [PATCH] flashrom: Support for MCP55 and SST49LFXXXC chips

[Carl-Daniel Hailfinger]

Hello Yinghai,

Lu, Yinghai wrote:
> >      {0x10de, 0x0261, "NVidia MCP51", enable_flash_ck804},
> > // {0x10de, 0x0261, "NVIDIA C51",   enable_flash_ck804}, // YHLU
>
> Flash is on mcp51 instead of c51.

So we can safely delete this line?

Regards,
Carl-Daniel