See patch.
Uwe.
On 17.06.2009 01:39, Uwe Hermann wrote:
Move all printing code to print.c.
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de
Index: flash.h
--- flash.h (Revision 599) +++ flash.h (Arbeitskopie) @@ -272,6 +272,12 @@
+#define OK 0 +#define NT 1 /* Not tested */
Hm. Didn't we have these #defines elsewhere already?
Index: chipset_enable.c
--- chipset_enable.c (Revision 599) +++ chipset_enable.c (Arbeitskopie) @@ -948,9 +948,6 @@ return 0; }
-#define OK 0 -#define NT 1 /* Not tested */
I see. Simple move. OK.
Index: print.c
--- print.c (Revision 0) +++ print.c (Revision 0) @@ -0,0 +1,229 @@ +/*
- This file is part of the flashrom project.
- Copyright (C) 2009 Uwe Hermann uwe@hermann-uwe.de
I believe the flashbuses_to_text and some of the PREW handling code is from me.
+#ifndef MAX +#define MAX(a, b) ((a) > (b) ? (a) : (b)) +#endif
Kill MAX. We now have min() and max() functions in the source.
With the comments above considered, this is Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Regards, Carl-Daniel
On Wed, Jun 17, 2009 at 12:20:53PM +0200, Carl-Daniel Hailfinger wrote:
- Copyright (C) 2009 Uwe Hermann uwe@hermann-uwe.de
I believe the flashbuses_to_text and some of the PREW handling code is from me.
Oops, true. Fixed now.
Kill MAX. We now have min() and max() functions in the source.
Done.
With the comments above considered, this is Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Thanks, r601.
Uwe.