[superiotool][PATCH] : fix W83977TF CR index value in ACPI LDN v4

[Noone Nowhere]

From: Ioannis Barkas  and Nikos Barkas

Index: util/superiotool/winbond.c
===================================================================
--- util/superiotool/winbond.c	(revision 4355)
+++ util/superiotool/winbond.c	(working copy)
@@ -285,7 +285,7 @@
    		 0x01,0x01,0x01,0x01,0x01,0x01,0x01,0x00,EOT}},
    	{0xa, "ACPI",
    		{0x30,0x60,0x61,0x62,0x63,0x64,0x65,0x70,0xe0,0xe1,
-			 0x02,0xe3,0xe4,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,
+			 0xe2,0xe3,0xe4,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,
    		 0xf7,0xfe,0xff,EOT},
    		{0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
    		 NANA,MISC,RSVD,0x00,0x00,0x00,0x00,0x00,0x00,0x00,

Signed-off-by: Ioannis Barkas 
Signed-off-by: Nikos Barkas

---
More interesting things will be posted soon...
...but we will need at least one wiki account for sure this time at coreboot.org
(we have already contacted Stefan Reinauer and Ronald Minnich for an
account but got nothing after 2 e-mails quite some time ago...).

The patching procedure is undocumented:
How do you receive patches, from svn, from the mailiing list, or by
any other means?
How do we get an svn account or something similar.
If patches are received from the list, why on earth do we need to subscribe
to the list in order to contribute?

Update:
v4 is compared for svn revision 4355 (the only change was the revision
number though...)

[Carl-Daniel Hailfinger]

Hi Ioannis,
hi Nikos,

thanks for your patch.
Unfortunately, my data sheet for this chip is too old to find any of the
values for ACPI. Uwe will probably review your patch soon. He knows
these Winbond SuperI/O chips very well.

On 12.06.2009 11:04, Noone Nowhere wrote:
> More interesting things will be posted soon...
> ...but we will need at least one wiki account for sure this time at coreboot.org
> (we have already contacted Stefan Reinauer and Ronald Minnich for an
> account but got nothing after 2 e-mails quite some time ago...).

Stefan and Ron get thousands of mails per day. Either your mail ended up
in a spam filter (a sender name of "Nooone Nowhere" may cause that) or
they simply overlooked it in the mail flood.
> The patching procedure is undocumented:
> How do you receive patches, from svn, from the mailiing list, or by
> any other means?

Patches are usually sent to the mailing list.
> How do we get an svn account or something similar.

You don't need a svn account to contribute. It is possible to check out
our svn tree anonymously and send diffs (like you did).
Direct check ins to our svn tree are not possible because all patches
have to be reviewed on the mailing list first.
http://www.coreboot.org/Development_Guidelines has some info, but it
surely could be extended a bit.
> If patches are received from the list, why on earth do we need to subscribe
> to the list in order to contribute?

The mailing list is moderated to keep spam out (hundreds of spam mails
per day are stopped by that). If someone is not subscribed, his/her post
will usually be approved by a moderator after a few hours, so
subscribing is not strictly needed.

Regards,
Carl-Daniel

[superiotool][PATCH] : fix W83977TF CR index value in ACPI LDN v4

[Uwe Hermann]

On Fri, Jun 12, 2009 at 12:04:20PM +0300, Noone Nowhere wrote:
> From: Ioannis Barkas  and Nikos Barkas
> Index: util/superiotool/winbond.c
>
> --- util/superiotool/winbond.c	(revision 4355)
> +++ util/superiotool/winbond.c	(working copy)
> @@ -285,7 +285,7 @@
>    		 0x01,0x01,0x01,0x01,0x01,0x01,0x01,0x00,EOT}},
>    	{0xa, "ACPI",
>    		{0x30,0x60,0x61,0x62,0x63,0x64,0x65,0x70,0xe0,0xe1,
> 	 0x02,0xe3,0xe4,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,
> 	 0xe2,0xe3,0xe4,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,
>  0xf7,0xfe,0xff,EOT},
> {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
>  NANA,MISC,RSVD,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
>
> Signed-off-by: Ioannis Barkas 
> Signed-off-by: Nikos Barkas

Thanks, fixed in r4356.

Uwe.

[Stefan Reinauer]

On 12.06.2009 11:04 Uhr, Noone Nowhere wrote:
> More interesting things will be posted soon...
> ...but we will need at least one wiki account for sure this time at coreboot.org
> (we have already contacted Stefan Reinauer and Ronald Minnich for an
> account but got nothing after 2 e-mails quite some time ago...).

Interesting. I can't find any trace of emails with the two email
addresses you specified. When was this?

We usually don't hand out Wiki accounts unless people bring reasons what
they need the account for. We do have dozens of non-contributing
accounts in the Wiki that were very anxious in the beginning and then
never contributed, so we want to avoid increasing that number.

All the best,

Stefan