[LinuxBIOS] [PATCH] buildrom: make menuconfig support

[Uwe Hermann]

See patch.

Uwe.

[LinuxBIOS] buildrom: make menuconfig support

[Jordan Crouse]

On 12/09/07 23:37 +0200, Uwe Hermann wrote:
> See patch.
> Uwe.
>
> http://www.hermann-uwe.de  | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
> Add support for 'make menuconfig' in buildrom. Until now,
> only 'make oldconfig' would work.
>
> Signed-off-by: Uwe Hermann

Acked-by: Jordan Crouse

Thanks Uwe!
> Index: scripts/kconfig/lxdialog/Makefile
>
> --- scripts/kconfig/lxdialog/Makefile	(Revision 34)
> +++ scripts/kconfig/lxdialog/Makefile	(Arbeitskopie)
> @@ -1,11 +1,13 @@
>  # Makefile to build lxdialog package
>  #
>
> +CONFIG_SHELL := sh
>
> check-lxdialog  := ./check-lxdialog.sh
>
> HOSTCC ?= gcc
>
> -# Use reursively expanded variables so we do not call gcc unless
> +# Use recursively expanded variables so we do not call gcc unless
>  # we really need to do so. (Do not call gcc as part of make mrproper)
>  HOST_EXTRACFLAGS = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ccflags)
>  HOST_LOADLIBES   = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC))
> @@ -22,5 +24,9 @@
>  lxdialog-objs := checklist.o menubox.o textbox.o yesno.o inputbox.o \
>    	 util.o lxdialog.o msgbox.o
>
> -lxdialog: $(lxdialog-objs)
> $(CC) -o lxdialog $(lxdialog-objs)
>
> +lxdialog: dochecklxdialog $(lxdialog-objs)
> $(CC) $(HOST_LOADLIBES) -o lxdialog $(lxdialog-objs)
>
> +%.o: %.c
> $(Q)$(HOSTCC) $(HOST_EXTRACFLAGS) $^ -c -o $@
> Index: Makefile
>
> --- Makefile	(Revision 34)
> +++ Makefile	(Arbeitskopie)
> @@ -94,4 +94,10 @@
>
> defconfig: $(KCONFIG_DIR)/conf
>    @$(KCONFIG_DIR)/conf -d $(BASE_DIR)/Config.in
>
> +menuconfig:
> @make -C $(KCONFIG_DIR)/lxdialog lxdialog
> @make -C $(KCONFIG_DIR) mconf
> @$(KCONFIG_DIR)/mconf $(BASE_DIR)/Config.in
>
> endif
>

[Ward Vandewege]

On Wed, Sep 12, 2007 at 11:37:54PM +0200, Uwe Hermann wrote:
> See patch.
> Uwe.
>
> http://www.hermann-uwe.de  | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
> Add support for 'make menuconfig' in buildrom. Until now,
> only 'make oldconfig' would work.
>
> Signed-off-by: Uwe Hermann

Acked-by: Ward Vandewege

[Uwe Hermann]

On Wed, Sep 12, 2007 at 06:04:29PM -0400, Ward Vandewege wrote:
> > Add support for 'make menuconfig' in buildrom. Until now,
> > only 'make oldconfig' would work.
> >
> > Signed-off-by: Uwe Hermann
> Acked-by: Jordan Crouse 
> Acked-by: Ward Vandewege

Thanks, r35.

Uwe.

[Tom Sylla]

Hm, what about at least a tiny update to README that says that
menuconfig is available? (it currently says to use oldconfig)

On 9/12/07, Uwe Hermann  wrote:
> See patch.
> Uwe.
>
> http://www.hermann-uwe.de  | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFG6FwxXdVoV3jWIbQRAhWvAJ90GkxvCNZyIUXG+udXVsgVPxDaXgCgiub5
> RAzlHgsXp3pu91Pl/7Ah2AI=
> =K+Zb
> -----END PGP SIGNATURE-----

[Uwe Hermann]

On Wed, Sep 12, 2007 at 06:43:37PM -0400, Tom Sylla wrote:
> Hm, what about at least a tiny update to README that says that
> menuconfig is available? (it currently says to use oldconfig)

Good point. Done.

Uwe.