[LinuxBIOS] [PATCH] v2:

[Carl-Daniel Hailfinger]

Add a debug message to keyboard init. This helped isolate at least one
case of keyboard failure (the keyboard initialization was never hit).

Signed-off-by: Carl-Daniel Hailfinger

--- 
Index: LinuxBIOSv2/src/pc80/keyboard.c
===================================================================
--- LinuxBIOSv2/src/pc80/keyboard.c	(Revision 2849)
+++ LinuxBIOSv2/src/pc80/keyboard.c	(Arbeitskopie)
@@ -27,6 +27,7 @@
 {
    unsigned char regval;

+	printk_err("Keyboard init...\n");
    /* send cmd = 0xAA, self test 8042 */
    outb(0xaa, 0x64);

[Uwe Hermann]

On Fri, Oct 12, 2007 at 03:32:28AM +0200, Carl-Daniel Hailfinger wrote:
> Add a debug message to keyboard init. This helped isolate at least one
> case of keyboard failure (the keyboard initialization was never hit).
>
> Signed-off-by: Carl-Daniel Hailfinger
> Index: LinuxBIOSv2/src/pc80/keyboard.c
>
> --- LinuxBIOSv2/src/pc80/keyboard.c	(Revision 2849)
> +++ LinuxBIOSv2/src/pc80/keyboard.c	(Arbeitskopie)
> @@ -27,6 +27,7 @@
>  {
>    unsigned char regval;
> printk_err("Keyboard init...\n");

Yep, but this should be DEBUG or INFO, not ERROR, I think?

Uwe.

[Carl-Daniel Hailfinger]

On 12.10.2007 12:39, Uwe Hermann wrote:
> On Fri, Oct 12, 2007 at 03:32:28AM +0200, Carl-Daniel Hailfinger wrote:
> > Add a debug message to keyboard init. This helped isolate at least one
> > case of keyboard failure (the keyboard initialization was never hit).
> >
> > Signed-off-by: Carl-Daniel Hailfinger
> > Index: LinuxBIOSv2/src/pc80/keyboard.c
> >
> > --- LinuxBIOSv2/src/pc80/keyboard.c	(Revision 2849)
> > +++ LinuxBIOSv2/src/pc80/keyboard.c	(Arbeitskopie)
> > @@ -27,6 +27,7 @@
> >  {
> >    unsigned char regval;
> > printk_err("Keyboard init...\n");
>
> Yep, but this should be DEBUG or INFO, not ERROR, I think?

Yes. I'll resend.

Carl-Daniel

[LinuxBIOS] [PATCH] v2: keyboard init debug message

[Carl-Daniel Hailfinger]

Add a debug message to keyboard init. This helped isolate at least one
case of keyboard failure (the keyboard initialization was never hit).

Signed-off-by: Carl-Daniel Hailfinger

---

Index: LinuxBIOSv2/src/pc80/keyboard.c
===================================================================
--- LinuxBIOSv2/src/pc80/keyboard.c	(Revision 2849)
+++ LinuxBIOSv2/src/pc80/keyboard.c	(Arbeitskopie)
@@ -27,6 +27,7 @@
 {
    unsigned char regval;

+	printk_debug("Keyboard init...\n");
    /* send cmd = 0xAA, self test 8042 */
    outb(0xaa, 0x64);

[LinuxBIOS] [PATCH] v2: keyboard init debug message

[Stefan Reinauer]

* Carl-Daniel Hailfinger  [071012 23:10]:
> Add a debug message to keyboard init. This helped isolate at least one
> case of keyboard failure (the keyboard initialization was never hit).
>
> Signed-off-by: Carl-Daniel Hailfinger

Acked-by: Stefan Reinauer
> Index: LinuxBIOSv2/src/pc80/keyboard.c
>
> --- LinuxBIOSv2/src/pc80/keyboard.c	(Revision 2849)
> +++ LinuxBIOSv2/src/pc80/keyboard.c	(Arbeitskopie)
> @@ -27,6 +27,7 @@
>  {
>    unsigned char regval;
> printk_debug("Keyboard init...\n");
> /* send cmd = 0xAA, self test 8042 */
> outb(0xaa, 0x64);

[LinuxBIOS] [PATCH] v2: keyboard init debug message

[Carl-Daniel Hailfinger]

On 17.10.2007 19:17, Stefan Reinauer wrote:
> Carl-Daniel Hailfinger  [071012 23:10]:
> > Add a debug message to keyboard init. This helped isolate at least one
> > case of keyboard failure (the keyboard initialization was never hit).
> >
> > Signed-off-by: Carl-Daniel Hailfinger
>
> Acked-by: Stefan Reinauer

r2869

Carl-Daniel