Re: [coreboot] How to work with Chrome EC? (was: Successful build with GCC 7.2 and IASL 20170831 for coreboot 4.7)

[Paul Kocialkowski]

Hi,

Le lundi 02 octobre 2017 à 13:47 -0700, Vadim Bendebury a écrit :
> the entry threshold is a big high, but I am sure the Chome OS EC team would
> appreciate your contributions.

Actually, I have been contributing to various Chromium OS project over the years
and never had to setup the whole cros environment.

Not only is it possible to build the software outside of the cros build system
(e.g. such as it's done in the coreboot build system directly or through my
build system[0]), but it's also possible to send patches for review without it.

The Chromium Review Gerrit[1] works pretty much like the coreboot one, except
that it may use https and a cookie rather than ssh and a pubkey for pushing. So
once the account is setup on Gerrit (requires a Google account AFAIK), you can
simply push to projects like that:

git push https://chromium-review.googlesource.com/chromiumos/platform/ec master:refs/for/master

And that usually works well for me. Just keep in mind that you need to include
custom tags, such as Change-Id, TEST= and BUG= in the commit message.

Cheers,

Paul

[0]: https://git.code.paulk.fr/gitweb/?p=libettereboot.git;a=summary
[1]: https://chromium-review.googlesource.com/
> On Mon, Oct 2, 2017 at 12:04 AM, Paul Menzel <[e-mail]
> t> wrote:
> > Dear coreboot folks,
> >
> > GCC 7.2 found several issues in the Chromium EC code base, like #770209
> > [4], and I prepared  patches, but unfortunately, I do not know how to
> > push them for review.
> > The instructions don’t work for me [5]. I can’t find the manifest
> >
> > file, which seems to be required by the utility `repo`.
> > Also, in the preferences menu of the Google Chromium review system,
> >
> > I cannot find a way to upload my SSH key.
> > Is there a mailing list for the Chromium Embedded Controller
> >
> > development?
> >
> > Thanks,
> >
> > Paul
> >
> > [4] https://bugs.chromium.org/p/chromium/issues/detail?id=770209
> > [5] https://dev.chromium.org/chromium-os/ec-development
> > [6] https://chromium-review.googlesource.com/admin/projects/chromiumos/platf
> > orm/ec,access
> > --
> > coreboot mailing list: [e-mail]
> > https://mail.coreboot.org/mailman/listinfo/coreboot

How to work with Chrome EC? (was: Successful build with GCC 7.2 and IASL 20170831 for coreboot 4.7)

[Vadim Bendebury]

yes, there is not much special about Chrome OS chroot, but it makes things
easier and applies the pre-upload checks if the repo utility is used. The
same checks could be run manually, and outside chroot, but this would
require some discipline.

I mentioned cros sdk because Paul said he was missing the repo  manifest.

--vb

On Tue, Oct 3, 2017 at 2:10 AM, Paul Kocialkowski  wrote:
> Hi,
>
> Le lundi 02 octobre 2017 à 13:47 -0700, Vadim Bendebury a écrit :
> > the entry threshold is a big high, but I am sure the Chome OS EC team
>
> would
> > appreciate your contributions.
>
> Actually, I have been contributing to various Chromium OS project over the
> years
> and never had to setup the whole cros environment.
>
> Not only is it possible to build the software outside of the cros build
> system
> (e.g. such as it's done in the coreboot build system directly or through my
> build system[0]), but it's also possible to send patches for review
> without it.
>
> The Chromium Review Gerrit[1] works pretty much like the coreboot one,
> except
> that it may use https and a cookie rather than ssh and a pubkey for
> pushing. So
> once the account is setup on Gerrit (requires a Google account AFAIK), you
> can
> simply push to projects like that:
>
> git push https://chromium-review.googlesource.com/chromiumos/platform/ec
> master:refs/for/master
>
> And that usually works well for me. Just keep in mind that you need to
> include
> custom tags, such as Change-Id, TEST= and BUG= in the commit message.
>
> Cheers,
>
> Paul
> > On Mon, Oct 2, 2017 at 12:04 AM, Paul Menzel <paulepanter@users.
>
> sourceforge.ne
> > t> wrote:
> > > Dear coreboot folks,
> > >
> > > GCC 7.2 found several issues in the Chromium EC code base, like #770209
> > > [4], and I prepared  patches, but unfortunately, I do not know how to
> > > push them for review.
> > > The instructions don’t work for me [5]. I can’t find the manifest
> > >
> > > file, which seems to be required by the utility `repo`.
> > > Also, in the preferences menu of the Google Chromium review system,
> > >
> > > I cannot find a way to upload my SSH key.
> > > Is there a mailing list for the Chromium Embedded Controller
> > >
> > > development?
> > >
> > > Thanks,
> > >
> > > Paul
> > >
> > > [4] https://bugs.chromium.org/p/chromium/issues/detail?id=770209
> > > [5] https://dev.chromium.org/chromium-os/ec-development
> > > [6] https://chromium-review.googlesource.com/admin/
>
> projects/chromiumos/platf
> > > orm/ec,access
> > >
> > > coreboot mailing list: [e-mail]
> > > https://mail.coreboot.org/mailman/listinfo/coreboot
>
> Website: https://www.paulk.fr/
> Coding blog: https://code.paulk.fr/
> Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/