[PATCH] remove namestring trickery

[Rudolf Marek]

Hello,

The  namestring handling in ACPIgen was a big trickery. We were pasing the 
strings as it was a bytestream already. This was a reason for instead of
_PR one had to write _PR_

Or _SB.PCI0 was in fact _SB_PCI0.

This patch adds a proper namestring generation to our ACPIgen generator.
Its used for Name and Scope and Processor now. As bonus, it allows to create a 
multi name paths too. Like Scope(\ALL.YOUR.BASE).

Signed-off-by: Rudolf Marek

I have no board now, so I cannot test it on real HW. I did some tests which a 
ACPIgen testbench which I'm attaching for future reference.

I dont know what happen to fam10 code, but I think it will need similar change.

Rudolf

[Stefan Reinauer]

On 20.06.2009 15:36 Uhr, Rudolf Marek wrote:
> Hello,
>
> The  namestring handling in ACPIgen was a big trickery. We were pasing
> the strings as it was a bytestream already. This was a reason for
> instead of
> _PR one had to write _PR_

So the proper name of the processor scope is _PR, not _PR_, or PR?
> Or _SB.PCI0 was in fact _SB_PCI0.
>
> This patch adds a proper namestring generation to our ACPIgen generator.
> Its used for Name and Scope and Processor now. As bonus, it allows to
> create a multi name paths too. Like Scope(\ALL.YOUR.BASE).
>
> Signed-off-by: Rudolf Marek

Acked-by: Stefan Reinauer

[Rudolf Marek]

> So the proper name of the processor scope is _PR, not _PR_, or PR?

Yes its _PR. The _PR_ is in fact "raw" encoded name. With  _ for padding to 4 bytes.
> Acked-by: Stefan Reinauer

Thanks

But I need to test this on some hw. Did you?

Rudolf

[Peter Stuge]

Rudolf Marek wrote:
> But I need to test this on some hw. Did you?

I can test it if I get an image.

//Peter

[Harald Gutmann]

On Saturday 20 June 2009 15:36:13 Rudolf Marek wrote:
> Hello,
>
> The  namestring handling in ACPIgen was a big trickery. We were pasing the
> strings as it was a bytestream already. This was a reason for instead of
> _PR one had to write _PR_
>
> Or _SB.PCI0 was in fact _SB_PCI0.
>
> This patch adds a proper namestring generation to our ACPIgen generator.
> Its used for Name and Scope and Processor now. As bonus, it allows to
> create a multi name paths too. Like Scope(\ALL.YOUR.BASE).
>
> Signed-off-by: Rudolf Marek

Acked-by: Harald Gutmann

I didn't review the whole patch, but it seems to be fine.
The tests I did on hardware went all like they should.
> I have no board now, so I cannot test it on real HW. I did some tests which
> a ACPIgen testbench which I'm attaching for future reference.

I've tested this patch on M57SLI.
The SSDT.dsl tables from a plain cb-v2 rev. 4367 and the same rev. with this 
patch are attached.

PowerNow remains working, like it should, and there are no differences after 
patching cb in the SSDT.dsl tables.
> I dont know what happen to fam10 code, but I think it will need similar
> change.
>
> Rudolf

Regards,
Harald

[Rudolf Marek]

Thanks for the test.

Its in as Committed revision 4368.

Rudolf