[PATCH] i82801xx IRQ Fix Up

[Joseph Smith]

This is a patch to use another IRQ besides IRQ12 to fix conflicts with
i8042 - PS/2 Mouse, most commonly assigned IRQ12 by the SuperIO. It took me
this long to catch this because I usually use a USB mouse.

Signed-off-by: Joseph Smith

[Joseph Smith]

On Thu, 30 Apr 2009 21:32:55 -0400, Joseph Smith 
wrote:
> This is a patch to use another IRQ besides IRQ12 to fix conflicts with
> i8042 - PS/2 Mouse, most commonly assigned IRQ12 by the SuperIO. It took
> me
> this long to catch this because I usually use a USB mouse.
>
> Signed-off-by: Joseph Smith

This one too?

[Myles Watson]

> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]]
> On Behalf Of Joseph Smith
> Sent: Thursday, April 30, 2009 10:33 PM
> To: coreboot
> Subject: Re: [coreboot] [PATCH] i82801xx IRQ Fix Up
>
> On Thu, 30 Apr 2009 21:32:55 -0400, Joseph Smith 
> wrote:
> > This is a patch to use another IRQ besides IRQ12 to fix conflicts with
> > i8042 - PS/2 Mouse, most commonly assigned IRQ12 by the SuperIO. It took
> > me
> > this long to catch this because I usually use a USB mouse.
> >
> > Signed-off-by: Joseph Smith
>
> This one too?

I was going to look up IRQ 4 first.  I don't pretend to know too much about
IRQs.

Myles

[Myles Watson]

On Thu, Apr 30, 2009 at 10:38 PM, Myles Watson  wrote:
> > -----Original Message-----
> > From: [e-mail] [mailto:[e-mail]]
> > On Behalf Of Joseph Smith
> > Sent: Thursday, April 30, 2009 10:33 PM
> > To: coreboot
> > Subject: Re: [coreboot] [PATCH] i82801xx IRQ Fix Up
> >
> > On Thu, 30 Apr 2009 21:32:55 -0400, Joseph Smith 
> > wrote:
> > > This is a patch to use another IRQ besides IRQ12 to fix conflicts with
> > > i8042 - PS/2 Mouse, most commonly assigned IRQ12 by the SuperIO. It took
> > > me
> > > this long to catch this because I usually use a USB mouse.
> > >
> > > Signed-off-by: Joseph Smith
> >
> > This one too?
>
> I was going to look up IRQ 4 first.  I don't pretend to know too much about
> IRQs.

Acked-by: Myles Watson
> From what I could tell it should be fine.

Thanks,
Myles

[Joseph Smith]

On Thu, 30 Apr 2009 22:45:28 -0600, Myles Watson  wrote:
> On Thu, Apr 30, 2009 at 10:38 PM, Myles Watson  wrote:
> > > -----Original Message-----
> > > From: [e-mail]
>
> [mailto:[e-mail]]
> > > On Behalf Of Joseph Smith
> > > Sent: Thursday, April 30, 2009 10:33 PM
> > > To: coreboot
> > > Subject: Re: [coreboot] [PATCH] i82801xx IRQ Fix Up
> > >
> > > On Thu, 30 Apr 2009 21:32:55 -0400, Joseph Smith 
> > > wrote:
> > > > This is a patch to use another IRQ besides IRQ12 to fix conflicts
>
> with
> > > > i8042 - PS/2 Mouse, most commonly assigned IRQ12 by the SuperIO. It
>
> took
> > > > me
> > > > this long to catch this because I usually use a USB mouse.
> > > >
> > > > Signed-off-by: Joseph Smith
> > >
> > > This one too?
> >
> > I was going to look up IRQ 4 first.  I don't pretend to know too much
>
> about
> > IRQs.
>
> Acked-by: Myles Watson
>
> From what I could tell it should be fine.

Thanks again r4246

[Joseph Smith]

On Thu, 30 Apr 2009 22:38:22 -0600, "Myles Watson" 
wrote:
> > -----Original Message-----
> > From: [e-mail]
>
> [mailto:[e-mail]]
> > On Behalf Of Joseph Smith
> > Sent: Thursday, April 30, 2009 10:33 PM
> > To: coreboot
> > Subject: Re: [coreboot] [PATCH] i82801xx IRQ Fix Up
> >
> > On Thu, 30 Apr 2009 21:32:55 -0400, Joseph Smith 
> > wrote:
> > > This is a patch to use another IRQ besides IRQ12 to fix conflicts with
> > > i8042 - PS/2 Mouse, most commonly assigned IRQ12 by the SuperIO. It
>
> took
> > > me
> > > this long to catch this because I usually use a USB mouse.
> > >
> > > Signed-off-by: Joseph Smith
> >
> > This one too?
>
> I was going to look up IRQ 4 first.  I don't pretend to know too much
> about
> IRQs.

It is shared with COM2, and doesn't seem to cause any conflicts.

[Stefan Reinauer]

On 01.05.2009 3:32 Uhr, Joseph Smith wrote:
> This is a patch to use another IRQ besides IRQ12 to fix conflicts with
> i8042 - PS/2 Mouse, most commonly assigned IRQ12 by the SuperIO. It took me
> this long to catch this because I usually use a USB mouse.

Good spot!
> Index: src/southbridge/intel/i82801xx/i82801xx_lpc.c
>
> --- src/southbridge/intel/i82801xx/i82801xx_lpc.c	(revision 4240)
> +++ src/southbridge/intel/i82801xx/i82801xx_lpc.c	(working copy)
> @@ -58,14 +58,16 @@
>   */
>
> #define PIRQA 0x03
> -#define PIRQB 0x05
> -#define PIRQC 0x06
> -#define PIRQD 0x07
> -#define PIRQE 0x09
> -#define PIRQF 0x0A
> -#define PIRQG 0x0B
> -#define PIRQH 0x0C
> +#define PIRQB 0x04
> +#define PIRQC 0x05
> +#define PIRQD 0x06
> +#define PIRQE 0x07
> +#define PIRQF 0x09
> +#define PIRQG 0x0A
> +#define PIRQH 0x0B

Hard coding these looks like it could work on one board and fail on
another. For the i82801gx I added these to the chip's config structure,
so they can be set in the device tree of the mainboard's config.lb.
Maybe that's what you want here, too?

Stefan

[Joseph Smith]

On Fri, 01 May 2009 11:15:41 +0200, Stefan Reinauer 
wrote:
> On 01.05.2009 3:32 Uhr, Joseph Smith wrote:
> > This is a patch to use another IRQ besides IRQ12 to fix conflicts with
> > i8042 - PS/2 Mouse, most commonly assigned IRQ12 by the SuperIO. It took
>
> me
> > this long to catch this because I usually use a USB mouse.
>
> Good spot!
> > Index: src/southbridge/intel/i82801xx/i82801xx_lpc.c
> >
> > --- src/southbridge/intel/i82801xx/i82801xx_lpc.c	(revision 4240)
> > +++ src/southbridge/intel/i82801xx/i82801xx_lpc.c	(working copy)
> > @@ -58,14 +58,16 @@
> >   */
> >
> > #define PIRQA 0x03
> > -#define PIRQB 0x05
> > -#define PIRQC 0x06
> > -#define PIRQD 0x07
> > -#define PIRQE 0x09
> > -#define PIRQF 0x0A
> > -#define PIRQG 0x0B
> > -#define PIRQH 0x0C
> > +#define PIRQB 0x04
> > +#define PIRQC 0x05
> > +#define PIRQD 0x06
> > +#define PIRQE 0x07
> > +#define PIRQF 0x09
> > +#define PIRQG 0x0A
> > +#define PIRQH 0x0B
>
> Hard coding these looks like it could work on one board and fail on
> another. For the i82801gx I added these to the chip's config structure,
> so they can be set in the device tree of the mainboard's config.lb.
> Maybe that's what you want here, too?

That's awsome. I never noticed that. Yes we really should setup all boards
like this and get rid of these defines in i82801xx_lpc.c. I never really
liked it. One question, where do you have the "pirqx_routing" defined? We
should really work on a patch for all mainboards that use i82801xx.