[PATCH]Even more mptables conversion

[Patrick Georgi]

Hi,

some more mptables conversions, abuild tested, but not boot tested.
This time:
arima/hdama
broadcom/blast
dell/s1850
getac/p470
gigabyte/ga_2761gxdk
gigabyte/m57sli
hp/dl145_g1
hp/dl145_g3
hp/dl165_g6_fam10
ibase/mb899
ibm/e325
ibm/e326
intel/d945gclf
iwill/dk8_htx
iwill/dk8s2
iwill/dk8x
msi/ms7135
msi/ms7260
msi/ms9185
msi/ms9282
msi/ms9652_fam10
newisys/khepri
nvidia/l1_2pvv
roda/rk886ex
sunw/ultra40
tyan/s2881
tyan/s2882
tyan/s2885
tyan/s2891
tyan/s2892
tyan/s2895
tyan/s2912
tyan/s2912_fam10

Signed-off-by: Patrick Georgi

[Uwe Hermann]

On Sat, Nov 20, 2010 at 01:42:23PM +0100, Patrick Georgi wrote:
> some more mptables conversions, abuild tested, but not boot tested.

Acked-by: Uwe Hermann
> Index: src/mainboard/iwill/dk8_htx/get_bus_conf.c
>
> --- src/mainboard/iwill/dk8_htx/get_bus_conf.c	(Revision 6099)
> +++ src/mainboard/iwill/dk8_htx/get_bus_conf.c	(Arbeitskopie)
> @@ -109,11 +109,6 @@
>          dev = dev_find_slot(m->bus_8111_0, PCI_DEVFN(sysconf.sbdn,0));
>          if (dev) {
>                  m->bus_8111_1 = pci_read_config8(dev, PCI_SECONDARY_BUS);
> -#if CONFIG_HT_CHAIN_END_UNITID_BASE >= CONFIG_HT_CHAIN_UNITID_BASE
>            m->bus_isa    = pci_read_config8(dev, PCI_SUBORDINATE_BUS);
>            m->bus_isa++;
>
> -//		printk(BIOS_DEBUG, "bus_isa=%d\n",bus_isa);
> -#endif

Is this handled properly by the new code? It doesn't check for this
CONFIG_HT_CHAIN_END_UNITID_BASE >= CONFIG_HT_CHAIN_UNITID_BASE condition
anymore, right?

Uwe.

[Patrick Georgi]

Am 21.11.2010 13:39, schrieb Uwe Hermann:
> > -#if CONFIG_HT_CHAIN_END_UNITID_BASE >= CONFIG_HT_CHAIN_UNITID_BASE
> >            m->bus_isa    = pci_read_config8(dev, PCI_SUBORDINATE_BUS);
> >            m->bus_isa++;
> >
> > -//		printk(BIOS_DEBUG, "bus_isa=%d\n",bus_isa);
> > -#endif
>
> Is this handled properly by the new code? It doesn't check for this
> CONFIG_HT_CHAIN_END_UNITID_BASE >= CONFIG_HT_CHAIN_UNITID_BASE condition
> anymore, right?

That distinction seems merely about which of the 8111/8131 chips have
higher bus numbers, and then gives bus_isa the highest bus id + 1.

The generic code just picks the highest available pci bus id in the
device tree and adds 1, so things should be fine.

One example where the code above would fail is when you plug in a riser
card (which exposes its own bus, incl. id) - this will break all
assumptions the various bus id collectors (like the one above) have.
We specifically cover that case (riser card) in the kontron/986lcd-m
code, which was the main motivation for me to start to clean this up.

Patrick