Re: [coreboot] PATCH: Add support for Virtensys 2uRack and Napoli

[Myles Watson]

On Mon, Jun 14, 2010 at 8:23 AM, Edwin Beasant
 wrote:
> Add Virtensys as a Manufacturer to the build sytem, and add their products.
>
> Virtensys products use AMD Geode LX in configuration very similar to AMD
> Norwich designs.
>
> Virtensys boards differ in the following ways from the reference
> implementation.
>
> No PCI Physical Slots.
> Intel 1Gig Ethernet onboard.
> Pericom PCI->PCIe bridge onboard.
> Napoli represents the Blade range of products
> 2uRack represents the 2u Rackable products.
>
> Signed-off-by: Edwin Beasant [e-mail]

A couple of questions:

1.  Does this support make them both work perfectly?  Is there
anything left to fix?
2.  Why do we need a cmos.layout file if HAVE_OPTION_TABLE is N?
3.  Can we get rid of the commented out lines in the cmos.layout file
if it needs to stay?

Sorry I don't have the hardware to test, so I have to have more
information about how it's working before wanting to Ack.

Thanks,
Myles