Re: [coreboot] [patch] Build error with top of tree V2

[Marc Jones]

Clay Jones wrote:
> I found the problem. The wrong ar command was being used because the
> make file does not have " $(CROSS_COMPILE)" in front of the ar command.

I think this might fix the problem. You will need to run buildtarget 
again. I hope some of the make experts to chime in on this.

Marc

[patch] Build error with top of tree V2

[Uwe Hermann]

On Wed, Feb 06, 2008 at 10:29:32AM -0700, Marc Jones wrote:
> Cross compile flags were missing for ar to create coreboot.a.
>
> Signed-off-by: Marc Jones
> Index: coreboot-v2/src/config/Config.lb
>
> --- coreboot-v2.orig/src/config/Config.lb	2008-02-06 10:17:43.000000000 -0700
> +++ coreboot-v2/src/config/Config.lb	2008-02-06 10:17:22.000000000 -0700
> @@ -35,7 +35,7 @@
>  makerule coreboot.a
>          depends "$(OBJECTS)"
>          action  "rm -f coreboot.a"
>    action  "ar cr coreboot.a $(OBJECTS)"
>    action  "$(CROSS_COMPILE) ar cr coreboot.a $(OBJECTS)"
>
> end

Untested, but I'm pretty sure that there should _not_ be a space in there.

Better:
           action  "$(CROSS_COMPILE)ar cr coreboot.a $(OBJECTS)"

Someone should actually test this, though.

Uwe.

[patch] Build error with top of tree V2

[Clay Jones]

That is the right place but you need to remove the space after the )
like this

+        action  "$(CROSS_COMPILE) ar cr coreboot.a $(OBJECTS)"

To

+        action  "$(CROSS_COMPILE)ar cr coreboot.a $(OBJECTS)"

-----Original Message-----
From: Marc Jones [mailto:[e-mail]] 
Sent: Wednesday, February 06, 2008 9:30 AM
To: Clay Jones
Cc: [e-mail]
Subject: Re: [coreboot] [patch] Build error with top of tree V2

Clay Jones wrote:
> I found the problem. The wrong ar command was being used because the
> make file does not have " $(CROSS_COMPILE)" in front of the ar

command.
>

I think this might fix the problem. You will need to run buildtarget 
again. I hope some of the make experts to chime in on this.

Marc

[patch] Build error with top of tree V2

[Stefan Reinauer]

* Marc Jones  [080206 18:29]:
> Cross compile flags were missing for ar to create coreboot.a.
>
> Signed-off-by: Marc Jones

r3100.