Hi,
I'm looking at a huge tpm merge commit. +625, -748
So the question how can we merge this? As long we don't have further testing, it's hard to decide. We won't catch all bugs. May be chromeos have a tpm testing?
And also reorganize the commit into smaller ones are very hard and I think it's not the effort worthy. Because merging two apis into one is a big thing.
The only other way I can imagine merge I don't know how easy it is, having 3 apis lying in the tree. The 2 "old" apis and the new merged one. Extending the new api until it's working.
Can we freeze the tpm apis for now? It would give zaolin more time to fix the problems and give the reviewer also more time to look over?!
Best, lynxis
https://review.coreboot.org/#/c/10542/
On Wed, 9 Mar 2016 23:55:03 +0100 Alexander Couzens lynxis@fe80.eu wrote:
So the question how can we merge this? As long we don't have further testing, it's hard to decide. We won't catch all bugs. May be chromeos have a tpm testing?
How do you test a TPM? Would dumping its PCR sufficent?
(I've been trying to add TPM support on the X60/X60T[1]).
References: ----------- [1]My goal was to have that laptop fully supported, and to learn about TPMs.
Denis.