It is guaranteed that, if I changed only the commit message, the results of a previous build ("success +1 / failure -1") will be repeated for a change. So it is probably a waste of resources to rebuild even for this case, and could be more efficient to just repeat the previous results.
There are a few lint tests that check the commit message.
Patrick
Mike Banon mikebdp2@gmail.com schrieb am Sa., 23. Feb. 2019, 16:31:
It is guaranteed that, if I changed only the commit message, the results of a previous build ("success +1 / failure -1") will be repeated for a change. So it is probably a waste of resources to rebuild even for this case, and could be more efficient to just repeat the previous results. _______________________________________________ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-leave@coreboot.org
On Sat, Feb 23, 2019 at 6:38 PM Patrick Georgi pgeorgi@google.com wrote:
There are a few lint tests that check the commit message.
https://review.coreboot.org/c/coreboot/+/31308/2..3 - between 2 and 3 only the commit message changed, but here is the full console log of Jenkins build bot - https://qa.coreboot.org/job/coreboot-gerrit/89565/consoleFull - and if I am not mistaken he rebuilt the coreboot for all the boards...
It's more reliable to not add special cases and more recently the queue was never long enough to warrant any such risk.
Mike Banon mikebdp2@gmail.com schrieb am Sa., 23. Feb. 2019, 16:44:
On Sat, Feb 23, 2019 at 6:38 PM Patrick Georgi pgeorgi@google.com wrote:
There are a few lint tests that check the commit message.
https://review.coreboot.org/c/coreboot/+/31308/2..3 - between 2 and 3 only the commit message changed, but here is the full console log of Jenkins build bot - https://qa.coreboot.org/job/coreboot-gerrit/89565/consoleFull - and if I am not mistaken he rebuilt the coreboot for all the boards...
-
Mike Banon -
Patrick Georgi