New Defects reported by Coverity Scan for coreboot

Hi,

Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.

2 new defect(s) introduced to coreboot found with Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)

** CID 1501187:  Control flow issues  (DEADCODE)
/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c: 40 in mp_get_processor_info()

________________________________________________________________________________________________________
*** CID 1501187:  Control flow issues  (DEADCODE)
/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c: 40 in mp_get_processor_info()
34     	if (processor_number >= MIN(get_cpu_count(), CONFIG_MAX_CPUS))
35     		return FSP_NOT_FOUND;
36     
37     	extern struct cpu_info cpu_infos[];
38     	struct cpu_info *info = &cpu_infos[processor_number];
39     	if (!info)
> > > CID 1501187:  Control flow issues  (DEADCODE)
> > > Execution cannot reach this statement: "return 2147483655U;".

40     		return FSP_DEVICE_ERROR;
41     
42     	if (processor_info_buffer == NULL)
43     		return FSP_INVALID_PARAMETER;
44     	apicid = info->cpu->path.apic.apic_id;
45

** CID 1501186:    (DEADCODE)
/src/mainboard/google/herobrine/mainboard.c: 105 in mainboard_needs_pcie_init()
/src/mainboard/google/herobrine/mainboard.c: 102 in mainboard_needs_pcie_init()

________________________________________________________________________________________________________
*** CID 1501186:    (DEADCODE)
/src/mainboard/google/herobrine/mainboard.c: 105 in mainboard_needs_pcie_init()
99     	uint32_t sku = sku_id() & sku_bits_mask;
100     
101     	if (sku == CROS_SKU_UNKNOWN) {
102     		printk(BIOS_WARNING, "Unknown SKU (%#x); assuming PCIe", sku);
103     		return true;
104     	} else if (sku == CROS_SKU_UNPROVISIONED) {
> > > CID 1501186:    (DEADCODE)
> > > Execution cannot reach this statement: "printk(4, "Unprovisioned SK...".

105     		printk(BIOS_WARNING, "Unprovisioned SKU (%#x); assuming PCIe", sku);
106     		return true;
107     	}
108     
109     	if ((sku % 3) == 2)
110     		return true;
/src/mainboard/google/herobrine/mainboard.c: 102 in mainboard_needs_pcie_init()
96     	 * each tristate, so we can represent numbers up to 27, or 5 bits
97     	 */
98     	uint32_t sku_bits_mask = 0xff;
99     	uint32_t sku = sku_id() & sku_bits_mask;
100     
101     	if (sku == CROS_SKU_UNKNOWN) {
> > > CID 1501186:    (DEADCODE)
> > > Execution cannot reach this statement: "printk(4, "Unknown SKU (%#x...".

102     		printk(BIOS_WARNING, "Unknown SKU (%#x); assuming PCIe", sku);
103     		return true;
104     	} else if (sku == CROS_SKU_UNPROVISIONED) {
105     		printk(BIOS_WARNING, "Unprovisioned SKU (%#x); assuming PCIe", sku);
106     		return true;
107     	}

________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0...