[PATCH] Stop build if coreboot.rom.bootblock is larger than the area allocated to the bootblock

[Patrick Georgi]

Hi,

attached patch fixes an oversight in cbfstool related to bootblock handling.
With this patch, cbfstool reacts to a too large bootblock file by 
stopping with an error code. Before, it did "whatever" (besides printing 
a warning).

Signed-off-by: Patrick Georgi

Index: util/cbfstool/util.c
===================================================================
--- util/cbfstool/util.c	(revision 4328)
+++ util/cbfstool/util.c	(working copy)
@@ -222,7 +222,8 @@
    rom->header->align = htonl(align);
    rom->header->offset = htonl(0);

-	add_bootblock(rom, bootblockname);
+	if (add_bootblock(rom, bootblockname) == -1)
+		return -1;

/* Write the cbfs master header address at the end of the ROM. */

[PATCH] Stop build if coreboot.rom.bootblock is larger than the area allocated to the bootblock

[Peter Stuge]

Patrick Georgi wrote:
> Hi,
>
> attached patch fixes an oversight in cbfstool related to bootblock 
> handling.
> With this patch, cbfstool reacts to a too large bootblock file by stopping 
> with an error code. Before, it did "whatever" (besides printing a warning).
>
> Signed-off-by: Patrick Georgi

Acked-by: Peter Stuge

[Uwe Hermann]

On Mon, Jun 01, 2009 at 09:33:05PM +0200, Peter Stuge wrote:
> Patrick Georgi wrote:
> > Hi,
> >
> > attached patch fixes an oversight in cbfstool related to bootblock 
> > handling.
> > With this patch, cbfstool reacts to a too large bootblock file by stopping 
> > with an error code. Before, it did "whatever" (besides printing a warning).
> >
> > Signed-off-by: Patrick Georgi
>
> Acked-by: Peter Stuge

This was r4329.

Uwe.