QEMU Keyboard problems in v2

[aaron lwe]

Hi,

I have the same problem when using ADLO as the payload with qemu.
I found qemu in coreboot-v2 didn't init keyboard while v3 did in
setup_onboard of vga.c.
And the ADLO code in bochs/bios/rombios.c defined COREBOOT which
caused function keyboard_init did noting.

Adding init_pc_keyboard(0x60, 0x64, &conf) for qemu in coreboot-v2
worked for me.

[Myles Watson]

> Hi,
>
> I have the same problem when using ADLO as the payload with qemu.
> I found qemu in coreboot-v2 didn't init keyboard while v3 did in
> setup_onboard of vga.c.
> And the ADLO code in bochs/bios/rombios.c defined COREBOOT which
> caused function keyboard_init did noting.
>
> Adding init_pc_keyboard(0x60, 0x64, &conf) for qemu in coreboot-v2
> worked for me.

Aaron,

Where did you add it?  Is there a reason why we don't commit the change?  It
seems like Coreboot-v2 used to initialize the keyboard correctly, otherwise
ADLO wouldn't have disabled the keyboard init when compiled for Coreboot.

I wonder why Jordan gets it to work unpatched.

Thanks,
Myles

[aaron lwe]

> Where did you add it?

I attached a patch, it adds pc keyboard init function for qemu in case
payloads assume coreboot has done the job.
Signed-off-by: Aaron Lwe
> it seems like Coreboot-v2 used to initialize the keyboard correctly, otherwise
>  ADLO wouldn't have disabled the keyboard init when compiled for Coreboot.

yes, ADLO assumes coreboot has inited keyboard so it omits that.
> I wonder why Jordan gets it to work unpatched.

maybe the payload he uses inits the keyboard?

Thanks,

[Myles Watson]

> -----Original Message-----
> From: aaron lwe [mailto:[e-mail]]
> Sent: Monday, May 05, 2008 7:41 PM
> To: Myles Watson
> Cc: Coreboot
> Subject: QEMU Keyboard problems in v2
> > Where did you add it?
>
> I attached a patch, it adds pc keyboard init function for qemu in case
> payloads assume coreboot has done the job.
> Signed-off-by: Aaron Lwe

Thanks Aaron,

It works for me.

Acked-by: Myles Watson

Rev 3280.
> > it seems like Coreboot-v2 used to initialize the keyboard correctly,
>
> otherwise
> > ADLO wouldn't have disabled the keyboard init when compiled for
>
> Coreboot.
> yes, ADLO assumes coreboot has inited keyboard so it omits that.
> > I wonder why Jordan gets it to work unpatched.
>
> maybe the payload he uses inits the keyboard?

I checked his log and it doesn't have the "Keyboard init" line.  I don't
know why it works for him.

Thanks,
Myles