Re: [coreboot] Trying to add Kconfig support for M57SLI - build error

[Harald Gutmann]

On Friday 21 August 2009 20:14:29 you wrote:
> > -----Original Message-----
> >
> > On Friday 21 August 2009 19:56:25 you wrote:
> > > > > hargut@benchvice:~/cb-v2$ make
> > > > >    GEN        build/build.h
> > > > >    CC         build/northbridge/amd/amdk8/misc_control.o
> > > > > In file included from src/northbridge/amd/amdk8/amdk8.h:6,
> > > > >                 from src/northbridge/amd/amdk8/misc_control.c:22:
> > > > > src/northbridge/amd/amdk8/amdk8_f.h:524:21: error: macro
> > > > > "hard_reset" passed 1 arguments, but takes just 0
> > > >
> > > > I'm having similar problems (at least it looks similar to me).  My
> > > > ck804_reset.c file never gets compiled.
> > >
> > > I applied your patch, and it doesn't look like you uncomment the line
> > > in src/southbridge/nvidia/Makefile.inc so that mcp55 gets built.
> >
> > Which line do you mean?
> > subdirs-y += mcp55
> > This one would be here, except you mean another line...
>
> Yes that line.  When it was commented out I got the same error you're
> getting, but when it isn't I don't get that error.
>
> Do you see the mcp55 files being built?

Oh yeah, that was a RIGHT hint!
But on a different level of the tree.
The line in src/southbridge/nvidia/Makefile.inc was right, but the line " 
subdirs-y += nvidia" in src/southbridge/Makefile.inc was commented out.

Therefor the compiler error of the starting post is now fixed. (This took quite 
long, to find that little "#" sign...)

Thanks Myles!
> Thanks,
> Myles

Trying to add Kconfig support for M57SLI - build error

[Myles Watson]

> > > subdirs-y += mcp55
> > > This one would be here, except you mean another line...
> >
> > Yes that line.  When it was commented out I got the same error you're
> > getting, but when it isn't I don't get that error.
> >
> > Do you see the mcp55 files being built?
>
> Oh yeah, that was a RIGHT hint!

Great.
> But on a different level of the tree.

Oops.  I'm glad you found it anyway.  I should have looked more closely.

Thanks,
Myles

Trying to add Kconfig support for M57SLI - build error

[Harald Gutmann]

On Friday 21 August 2009 20:22:56 Harald Gutmann wrote:
> On Friday 21 August 2009 20:14:29 you wrote:
> > > -----Original Message-----
> > >
> > > On Friday 21 August 2009 19:56:25 you wrote:
> > > > > > hargut@benchvice:~/cb-v2$ make
> > > > > >    GEN        build/build.h
> > > > > >    CC         build/northbridge/amd/amdk8/misc_control.o
> > > > > > In file included from src/northbridge/amd/amdk8/amdk8.h:6,
> > > > > >                 from src/northbridge/amd/amdk8/misc_control.c:22:
> > > > > > src/northbridge/amd/amdk8/amdk8_f.h:524:21: error: macro
> > > > > > "hard_reset" passed 1 arguments, but takes just 0
> > > > >
> > > > > I'm having similar problems (at least it looks similar to me).  My
> > > > > ck804_reset.c file never gets compiled.
> > > >
> > > > I applied your patch, and it doesn't look like you uncomment the line
> > > > in src/southbridge/nvidia/Makefile.inc so that mcp55 gets built.
> > >
> > > Which line do you mean?
> > > subdirs-y += mcp55
> > > This one would be here, except you mean another line...
> >
> > Yes that line.  When it was commented out I got the same error you're
> > getting, but when it isn't I don't get that error.
> >
> > Do you see the mcp55 files being built?
>
> Oh yeah, that was a RIGHT hint!
> But on a different level of the tree.
> The line in src/southbridge/nvidia/Makefile.inc was right, but the line "
> subdirs-y += nvidia" in src/southbridge/Makefile.inc was commented out.
>
> Therefor the compiler error of the starting post is now fixed. (This took
> quite long, to find that little "#" sign...)

Beeing glad to see a different compiler error was maybe to early to say it's 
fixed.
It "seemed" fixed for me, as there have been some mistakes in the northbridge 
Kconfig which caused different errors, but after fixing them, the starting error 
is until now there. :/
> Thanks Myles!
> > Thanks,
> > Myles