[Patch] superiotool: Add IT8703F support.

[Luc Verhaegen]

Glenn, can you run this on your Asus A7V8X and attach the output?

Thanks,

Luc Verhaegen.

[Uwe Hermann]

On Thu, Jul 09, 2009 at 06:36:59PM +0200, Luc Verhaegen wrote:
> Superiotool: Add IT8703F support.
>
> Kudos to ITE for quickly providing information.
>
> Signed-off-by: Luc Verhaegen

Looks good, but see below for minor consistency fixes.
> Index: ite.c
>
> --- ite.c	(revision 4407)
> +++ ite.c	(working copy)
> @@ -66,6 +66,44 @@
>    	{EOT}}},
>    {0x8681, "IT8671F/IT8687R", {
>    	{EOT}}},
> {0x8701, "IT8703F", {
> {NOLDN, NULL,
>  {0x20,0x21,0x23,0x24,0x26,0x29,0x2A,0x2B,EOT},
>  {0x87,0x00,0x00,0x80,0x00,0x00,0x7C,0xC0,EOT}},

^

Indent this part by one TAB also please (and wrap lines at 80 chars if
needed) to match the rest of superiotool style.
> {0x0, "Floppy Disk Controller",

Also, "Floppy disk controller" (or even just "Floppy"), i.e., only first
word capitalized, to match the conventions in rest of superiotool. The
same applies to the other LDNs ("Parallel port" etc). "Consumer IR" is
fine as "IR" is an abbreviation.

Other than that:

Acked-by: Uwe Hermann

Uwe.

[Luc Verhaegen]

On Fri, Jul 10, 2009 at 12:17:03PM +0200, Uwe Hermann wrote:
> On Thu, Jul 09, 2009 at 06:36:59PM +0200, Luc Verhaegen wrote:
> > Superiotool: Add IT8703F support.
> >
> > Kudos to ITE for quickly providing information.
> >
> > Signed-off-by: Luc Verhaegen
>
> Looks good, but see below for minor consistency fixes.
> > Index: ite.c
> >
> > --- ite.c	(revision 4407)
> > +++ ite.c	(working copy)
> > @@ -66,6 +66,44 @@
> >    	{EOT}}},
> >    {0x8681, "IT8671F/IT8687R", {
> >    	{EOT}}},
> > {0x8701, "IT8703F", {
> > {NOLDN, NULL,
> >  {0x20,0x21,0x23,0x24,0x26,0x29,0x2A,0x2B,EOT},
> >  {0x87,0x00,0x00,0x80,0x00,0x00,0x7C,0xC0,EOT}},
>             ^
>
> Indent this part by one TAB also please (and wrap lines at 80 chars if
> needed) to match the rest of superiotool style.
> > {0x0, "Floppy Disk Controller",
>
> Also, "Floppy disk controller" (or even just "Floppy"), i.e., only first
> word capitalized, to match the conventions in rest of superiotool. The
> same applies to the other LDNs ("Parallel port" etc). "Consumer IR" is
> fine as "IR" is an abbreviation.
>
> Other than that:
>
> Acked-by: Uwe Hermann
>
> Uwe.

Done.

Committed as r4424.

Thanks,

Luc Verhaegen.