Hi,
Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.
1 new defect(s) introduced to coreboot found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s)
** CID 1374242: Code maintainability issues (UNUSED_VALUE) /src/soc/intel/skylake/smihandler.c: 472 in southbridge_smi_monitor()
________________________________________________________________________________________________________ *** CID 1374242: Code maintainability issues (UNUSED_VALUE) /src/soc/intel/skylake/smihandler.c: 472 in southbridge_smi_monitor() 466 /* IOTRAP(0) SMIC */ 467 if (IOTRAP(0)) { 468 if (!(trap_cycle & (1 << 24))) { /* It's a write */ 469 printk(BIOS_DEBUG, "SMI1 command\n"); 470 /* Trapped write data */ 471 data = pcr_read32(PID_PSTH, PCR_PSTH_TRPD);
CID 1374242: Code maintainability issues (UNUSED_VALUE) Assigning value from "data & mask" to "data" here, but that stored value is overwritten before it can be used.
472 data &= mask; 473 } 474 } 475 476 printk(BIOS_DEBUG, " trapped io address = 0x%x\n", 477 trap_cycle & 0xfffc);
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...
To manage Coverity Scan email notifications for "coreboot@coreboot.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...