[patch] update superiotool support for FreeBSD

[Idwer Vollering]

Update support for FreeBSD.

Signed-off-by: Idwer Vollering

---

FreeBSD support already existed but doesn't compile without errors on my
fbsd 8.1 machine:

$ gmake
gcc -O2 -Wall -Werror -Wstrict-prototypes -Wundef -Wstrict-aliasing
-Werror-implicit-function-declaration -ansi -pedantic
-D'SUPERIOTOOL_VERSION="5728"' -DPCI_SUPPORT   -c -o superiotool.o
superiotool.c
In file included from superiotool.c:24:
superiotool.h:41:21: error: pci/pci.h: No such file or directory
superiotool.c: In function 'main':
superiotool.c:302: error: implicit declaration of function 'pci_alloc'
cc1: warnings being treated as errors
superiotool.c:302: warning: assignment makes pointer from integer without a
cast
superiotool.c:303: error: implicit declaration of function 'pci_init'
superiotool.c:304: error: implicit declaration of function 'pci_scan_bus'
gmake: *** [superiotool.o] Error 1

[Warren Turkal]

On Sunday, October 17, 2010 09:37:27 am Idwer Vollering wrote:
> Update support for FreeBSD.
>
> Signed-off-by: Idwer Vollering

A few questions:
* Would it be better set LIBS to -lz and make LDFLAGS default to $(LIBS) on 
all platforms?
* I thought that FreeBSD used GCC?
 - If so, why remove -ansi and -pedantic on FreeBSD?
 - In either case, would it be better to replace -ansi with something like -
std=c90 on all platforms and leave -pedantic? Would that be enough to work?

Thanks,
wt

[Idwer Vollering]

2010/10/18 Warren Turkal
> On Sunday, October 17, 2010 09:37:27 am Idwer Vollering wrote:
> > Update support for FreeBSD.
> >
> > Signed-off-by: Idwer Vollering

Updated patch attached.
Signed-off-by: Idwer Vollering
> A few questions:
> Would it be better set LIBS to -lz and make LDFLAGS default to $(LIBS) on
>
> all platforms?
> I thought that FreeBSD used GCC?

It does, but you need GNU make (gmake):
http://www.freebsd.org/cgi/url.cgi?ports/devel/gmake/pkg-descr to be able to
do a native compile (from trunk/ code -- from fbsd's ports is a different
story).
> If so, why remove -ansi and -pedantic on FreeBSD?

This happens when leaving -pedantic (ergo not overriding CFLAGS that's
outside of the ifeq()..endif) alone:
- patch:

Index: Makefile
===================================================================
--- Makefile    (revision 5965)
+++ Makefile    (working copy)
@@ -39,6 +39,11 @@
 ifeq ($(OS_ARCH), Darwin)
 LIBS = -framework IOKit -framework DirectIO -lpci -lz
 endif
+ifeq ($(OS_ARCH), FreeBSD)
+CFLAGS +=-I/usr/local/include
+LDFLAGS += -L/usr/local/lib
+LIBS = -lz
+endif

# Support for PCI-attached "Super I/Os" (e.g. in VIA VT82686A/B).
 CONFIG_PCI = yes

- error:

$ gmake clean ; gmake
rm -f superiotool *.o
gcc -O2 -Wall -Werror -Wstrict-prototypes -Wundef -Wstrict-aliasing
-Werror-implicit-function-declaration -ansi -pedantic
-D'SUPERIOTOOL_VERSION="5728"' -I/usr/local/include -DPCI_SUPPORT   -c -o
superiotool.o superiotool.c
cc1: warnings being treated as errors
In file included from superiotool.h:41,
                 from superiotool.c:24:
/usr/local/include/pci/pci.h:238: warning: comma at end of enumerator list
gmake: *** [superiotool.o] Error 1
> In either case, would it be better to replace -ansi with something like
>
> std=c90 on all platforms and leave -pedantic? Would that be enough to work?

cc1: error: unrecognized command line option "-std=c90"
> Thanks,
> wt

[Uwe Hermann]

On Mon, Oct 18, 2010 at 04:26:44PM +0200, Idwer Vollering wrote:
> Updated patch attached.
> Signed-off-by: Idwer Vollering

Thanks, r5980.

Uwe.

[Andriy Gapon]

on 17/10/2010 19:37 Idwer Vollering said the following:
> Update support for FreeBSD.
>
> Signed-off-by: Idwer Vollering <[e-mail] >

BTW: http://www.freebsd.org/cgi/cvsweb.cgi/ports/sysutils/superiotool/

[Idwer Vollering]

2010/10/18 Andriy Gapon
> on 17/10/2010 19:37 Idwer Vollering said the following:
> > Update support for FreeBSD.
> >
> > Signed-off-by: Idwer Vollering <[e-mail] <mailto:
>
> [e-mail]>>
>
> BTW: http://www.freebsd.org/cgi/cvsweb.cgi/ports/sysutils/superiotool/

I know of its existence, yes.
Once you have devel/gmake and devel/libpci installed from ports, you can
(with this patch applied) just run gmake. Like you can with flashrom.
>