SB600 flashrom hang

[Carl-Daniel Hailfinger]

Hi,

on my Asus M2A-VM, latest flashrom hangs while trying to access SB600 SPI.

flashrom -V
Calibrating delay loop... 365M loops per second, 100 myus = 83 us. OK.
No coreboot table found.
Found chipset "ATI(AMD) SB600", enabling flash write... SPI base address
is at 0x0
OK.
Probing for AMD Am29F002(N)BB, 256 KB: probe_jedec: id1 0x0, id2 0x0,
id1 parity violation
Probing for AMD Am29F002(N)BT, 256 KB: probe_jedec: id1 0x0, id2 0x0,
id1 parity violation
Probing for AMD Am29F016D, 2048 KB: probe_29f040b: id1 0xff, id2 0xff
Probing for AMD Am29F040B, 512 KB: probe_29f040b: id1 0x0, id2 0x0
Probing for AMD Am29LV040B, 512 KB: probe_29f040b: id1 0x0, id2 0x0
Probing for ASD AE49F2008, 256 KB: probe_jedec: id1 0x0, id2 0x0, id1
parity violation
Probing for Atmel AT25DF021, 256 KB: sb600_spi_command, cmd=9f,
writecnt=0, readcnt=3

--------it hangs here---------------
The mainboard does not have a SPI chip.

Regards,
Carl-Daniel

SB600 flashrom hang (Patch)

[Bao, Zheng]

We have tested on the LPC and SPI ROM. The timeout value is OK on our
board. You'd better test it on your board.

Signed-off-by: Zheng bao

-----Original Message-----
From: [e-mail]
[mailto:[e-mail]] On Behalf Of Carl-Daniel
Hailfinger
Sent: Tuesday, December 09, 2008 1:16 AM
To: Coreboot
Subject: [coreboot] SB600 flashrom hang

Hi,

on my Asus M2A-VM, latest flashrom hangs while trying to access SB600
SPI.

flashrom -V
Calibrating delay loop... 365M loops per second, 100 myus = 83 us. OK.
No coreboot table found.
Found chipset "ATI(AMD) SB600", enabling flash write... SPI base address
is at 0x0
OK.
Probing for AMD Am29F002(N)BB, 256 KB: probe_jedec: id1 0x0, id2 0x0,
id1 parity violation
Probing for AMD Am29F002(N)BT, 256 KB: probe_jedec: id1 0x0, id2 0x0,
id1 parity violation
Probing for AMD Am29F016D, 2048 KB: probe_29f040b: id1 0xff, id2 0xff
Probing for AMD Am29F040B, 512 KB: probe_29f040b: id1 0x0, id2 0x0
Probing for AMD Am29LV040B, 512 KB: probe_29f040b: id1 0x0, id2 0x0
Probing for ASD AE49F2008, 256 KB: probe_jedec: id1 0x0, id2 0x0, id1
parity violation
Probing for Atmel AT25DF021, 256 KB: sb600_spi_command, cmd=9f,
writecnt=0, readcnt=3

--------it hangs here---------------
The mainboard does not have a SPI chip.

Regards,
Carl-Daniel

SB600 flashrom hang (Patch)

[Bao, Zheng]

Sorry, I sent the wrong patch.
This is the patch for flashrom hanging.

Zheng

-----Original Message-----
From: [e-mail]
[mailto:[e-mail]] On Behalf Of Bao, Zheng
Sent: Monday, December 22, 2008 6:44 PM
To: Carl-Daniel Hailfinger; Coreboot
Subject: Re: [coreboot] SB600 flashrom hang (Patch)

We have tested on the LPC and SPI ROM. The timeout value is OK on our
board. You'd better test it on your board.

Signed-off-by: Zheng bao

-----Original Message-----
From: [e-mail]
[mailto:[e-mail]] On Behalf Of Carl-Daniel
Hailfinger
Sent: Tuesday, December 09, 2008 1:16 AM
To: Coreboot
Subject: [coreboot] SB600 flashrom hang

Hi,

on my Asus M2A-VM, latest flashrom hangs while trying to access SB600
SPI.

flashrom -V
Calibrating delay loop... 365M loops per second, 100 myus = 83 us. OK.
No coreboot table found.
Found chipset "ATI(AMD) SB600", enabling flash write... SPI base address
is at 0x0
OK.
Probing for AMD Am29F002(N)BB, 256 KB: probe_jedec: id1 0x0, id2 0x0,
id1 parity violation
Probing for AMD Am29F002(N)BT, 256 KB: probe_jedec: id1 0x0, id2 0x0,
id1 parity violation
Probing for AMD Am29F016D, 2048 KB: probe_29f040b: id1 0xff, id2 0xff
Probing for AMD Am29F040B, 512 KB: probe_29f040b: id1 0x0, id2 0x0
Probing for AMD Am29LV040B, 512 KB: probe_29f040b: id1 0x0, id2 0x0
Probing for ASD AE49F2008, 256 KB: probe_jedec: id1 0x0, id2 0x0, id1
parity violation
Probing for Atmel AT25DF021, 256 KB: sb600_spi_command, cmd=9f,
writecnt=0, readcnt=3

--------it hangs here---------------
The mainboard does not have a SPI chip.

Regards,
Carl-Daniel

SB600 flashrom hang (Patch)

[Peter Stuge]

Hi,

Bao, Zheng wrote:
> We have tested on the LPC and SPI ROM. The timeout value is OK on
> our board. You'd better test it on your board.
>
> Signed-off-by: Zheng bao

I would like to improve the busy wait loop. Is 1 ms the desired
timeout? In that case the myusec_delay(1000) call is good.

Is it better if the delay is longer or shorter than 1 ms?

//Peter

SB600 flashrom hang (Patch)

[Bao, Zheng]

Hi,
If the usec_delay() is called, the programming action will be unbearably
slow. I haven't got a way to solve this.

Zheng

-----Original Message-----
From: [e-mail]
[mailto:[e-mail]] On Behalf Of Peter Stuge
Sent: Tuesday, December 23, 2008 10:16 AM
To: Coreboot
Subject: Re: [coreboot] SB600 flashrom hang (Patch)

Hi,

Bao, Zheng wrote:
> We have tested on the LPC and SPI ROM. The timeout value is OK on
> our board. You'd better test it on your board.
>
> Signed-off-by: Zheng bao

I would like to improve the busy wait loop. Is 1 ms the desired
timeout? In that case the myusec_delay(1000) call is good.

Is it better if the delay is longer or shorter than 1 ms?

//Peter

SB600 flashrom hang (Patch)

[Peter Stuge]

Bao, Zheng wrote:
> If the usec_delay() is called, the programming action will be
> unbearably slow. I haven't got a way to solve this.

What is the intended timeout period?

Try using myusec_delay(3) or another low number.

//Peter

SB600 flashrom hang (Patch)

[Bao, Zheng]

myusec_delay(1) is fine. Even if we do myusec_delay(2), it will do
slowly.

Zheng

Signed-off-by: Zheng Bao

-----Original Message-----
From: coreboot-bounces+zheng.bao=[e-mail]
[mailto:coreboot-bounces+zheng.bao=[e-mail]] On Behalf Of
Peter Stuge
Sent: Tuesday, December 23, 2008 1:49 PM
To: Coreboot
Subject: Re: [coreboot] SB600 flashrom hang (Patch)

Bao, Zheng wrote:
> If the usec_delay() is called, the programming action will be
> unbearably slow. I haven't got a way to solve this.

What is the intended timeout period?

Try using myusec_delay(3) or another low number.

//Peter