New patch to review for coreboot: 4a17211 Fix romcc to compile cleanly

[Stefan Reinauer]

Stefan Reinauer ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/759

-gerrit

commit 4a17211d7305877119606e9cbef9239830ec031d
Author: Vadim Bendebury 
Date:   Tue Dec 6 22:14:57 2011 +0000

Fix romcc to compile cleanly

There have been many unused variable assignments in the romcc source
    file. They cause multiple warning messages during build process which
    in turn make it harder to see the actual error message, when they are
    present.

The fix is to remove dead code and to add -Werror to romcc compilation
    to avoid issues like this creeping in in the future.

Change-Id: I6f42684f39a4135b0fe64219b8c7f058275c9fee
    Signed-off-by: Vadim Bendebury 
---
 util/romcc/Makefile |    2 +-
 util/romcc/romcc.c  |    3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/util/romcc/Makefile b/util/romcc/Makefile
index 6543fbb..8242eb5 100644
--- a/util/romcc/Makefile
+++ b/util/romcc/Makefile
@@ -1,7 +1,7 @@
 # Move the configuration defines to makefile.conf
 CC=gcc
 CPPFLAGS=
-CFLAGS= -g -Wall $(CPPFLAGS)
+CFLAGS= -g -Wall -Werror $(CPPFLAGS)
 CPROF_FLAGS=-pg -fprofile-arcs

all: romcc test
diff --git a/util/romcc/romcc.c b/util/romcc/romcc.c
index c7ef223..7eee439 100644
--- a/util/romcc/romcc.c
+++ b/util/romcc/romcc.c
@@ -9161,8 +9161,7 @@ static void decompose_compound_types(struct compile_state *state)
 {
    struct triple *ins, *next, *first;
 #if DEBUG_DECOMPOSE_HIRES
-	FILE *fp;
-	fp = state->dbgout;
+	FILE *fp = state->dbgout;
 #endif
    first = state->first;
    ins = first;