Patch merged into coreboot/master: d7bd4eb Add support for "Butterfly" Chromebook

the following patch was just integrated into master:
commit d7bd4eb003f5b6a13943418ae0ac53248a2e34d2
Author: Stefan Reinauer 
Date:   Mon Feb 11 11:11:36 2013 -0800

Add support for "Butterfly" Chromebook

We're happy to announce coreboot support for the "Butterfly"
    Chromebook, a.k.a HP Pavilion Chromebook.

More information at:
    http://www.google.com/intl/en/chrome/devices/hp-pavilion-chromebook.html

This commit also includes support for the ENE KB3940Q embedded controller
    running on Quanta's firmware.

Change-Id: I194f847a94005218ec04eeba091c3257ac459510
    Signed-off-by: Stefan Reinauer 
    Reviewed-on: http://review.coreboot.org/2359
    Reviewed-by: Duncan Laurie 
    Tested-by: build bot (Jenkins)

Build-Tested: build bot (Jenkins) at Mon Feb 11 21:58:55 2013, giving +1
See http://review.coreboot.org/2359 for details.

-gerrit

New patch to review for coreboot: 0ae65d8 Add support for "Butterfly" Chromebook

[Peter Stuge]

Stefan Reinauer wrote:
> Date: Mon, 11 Feb 2013 21:09:57 +0100
>
> Stefan Reinauer ([e-mail]) just uploaded a new patch set

[e-mail] wrote:
> Date: Mon, 11 Feb 2013 22:02:33 +0100
>
> the following patch was just integrated into master:
> commit d7bd4eb003f5b6a13943418ae0ac53248a2e34d2

I understand that you're eager to get things in, but maybe you could
let a new board sit for more than an hour?

I just finished review and had one or two questions. I did find a few
things perhaps worth discussing..

//Peter

Merges too fast not giving a chance for proper review (was: New patch to review for coreboot: 0ae65d8 Add support for "Butterfly" Chromebook)

[Paul Menzel]

Am Montag, den 11.02.2013, 22:51 +0100 schrieb Peter Stuge:
> Stefan Reinauer wrote:
> > Date: Mon, 11 Feb 2013 21:09:57 +0100
> >
> > Stefan Reinauer ([e-mail]) just uploaded a new patch set

First congrats to the new port!
> [e-mail] wrote:
> > Date: Mon, 11 Feb 2013 22:02:33 +0100
> >
> > the following patch was just integrated into master:
> > commit d7bd4eb003f5b6a13943418ae0ac53248a2e34d2
>
> I understand that you're eager to get things in, but maybe you could
> let a new board sit for more than an hour?

Reading the latest coreboot messages coming back to the PC I thought the
same.
> I just finished review and had one or two questions. I did find a few
> things perhaps worth discussing..

I did not even have time to look at it yet.

Thanks,

Paul

Merges too fast not giving a chance for proper review (was: New patch to review for coreboot: 0ae65d8 Add support for "Butterfly" Chromebook)

[Duncan Laurie]

On Mon, Feb 11, 2013 at 2:08 PM, Paul Menzel <
[e-mail]> wrote:
> Am Montag, den 11.02.2013, 22:51 +0100 schrieb Peter Stuge:
> > Stefan Reinauer wrote:
> > > Date: Mon, 11 Feb 2013 21:09:57 +0100
> > >
> > > Stefan Reinauer ([e-mail]) just uploaded a new
>
> patch set
>
> First congrats to the new port!
> > [e-mail] wrote:
> > > Date: Mon, 11 Feb 2013 22:02:33 +0100
> > >
> > > the following patch was just integrated into master:
> > > commit d7bd4eb003f5b6a13943418ae0ac53248a2e34d2
> >
> > I understand that you're eager to get things in, but maybe you could
> > let a new board sit for more than an hour?
>
> Reading the latest coreboot messages coming back to the PC I thought the
> same.
> > I just finished review and had one or two questions. I did find a few
> > things perhaps worth discussing..
>
> I did not even have time to look at it yet.

Sorry, I should have added +1 instead of +2.

We want to make the same code that shipped on the device available, but it
doesn't necessarily need to get committed in that form and we definitely
don't want to stop discussion or feedback.

Please do add comments and we can address them in followup commits if
necessary.

-duncan

New patch to review for coreboot: 0ae65d8 Add support for "Butterfly" Chromebook

[ron minnich]

This is another case where I would kind of prefer to let the "shipping
version " if the code go in as is, then put the revs in. This is not
really a proposal for code to give out to people: it's a different
animal entirely. This is the code that's on the laptop that you can
buy today. Because a lot of this code is in read only flash (i.e. not
easily changed), it's useful to have a version in the repo that is
exactly what's on that machine.

I think it would be wonderful if we could get your comments in and do
another rev based on that, with the caveat that at that point you're
no longer building what's on the machine and there are no guarantees.

I hope that makes some non-zero amount of sense :-)

ron