[LinuxBIOS] QEMU target cleanups

[Uwe Hermann]

See patch.

Uwe.

[Stefan Reinauer]

* Uwe Hermann  [070509 10:30]:
> Drop debug.c and failover.c from the QEMU target as they're not used and
> not useful there.

Should it not rather be fixed? Since LinuxBIOS is not useful on Qemu per
se, but only an educational target, we should not drop the stuff that we
call our selling points.

Stefan

[ron minnich]

On 5/9/07, Stefan Reinauer  wrote:
> Uwe Hermann  [070509 10:30]:
> > Drop debug.c and failover.c from the QEMU target as they're not used and
> > not useful there.
>
> Should it not rather be fixed? Since LinuxBIOS is not useful on Qemu per
> se, but only an educational target, we should not drop the stuff that we
> call our selling points.

yes, that is a good point. Can we make it so we can build a failover
target for qemu? That would be very neat.

ron

[LinuxBIOS] [PATCH] Drop QEMU target's debug.c

[Uwe Hermann]

On Wed, May 09, 2007 at 09:39:34AM -0700, ron minnich wrote:
> On 5/9/07, Stefan Reinauer  wrote:
> > Uwe Hermann  [070509 10:30]:
> > > Drop debug.c and failover.c from the QEMU target as they're not used and
> > > not useful there.
> >
> > Should it not rather be fixed? Since LinuxBIOS is not useful on Qemu per
> > se, but only an educational target, we should not drop the stuff that we
> > call our selling points.
>
> yes, that is a good point. Can we make it so we can build a failover
> target for qemu? That would be very neat.

Yep, agreed. I'll leave that for someone else to implement, though.

Here's an updated patch which drops just debug.c, that's surely not
needed or used.

Uwe.

[Stefan Reinauer]

* ron minnich  [070509 18:39]:
> > Should it not rather be fixed? Since LinuxBIOS is not useful on Qemu per
> > se, but only an educational target, we should not drop the stuff that we
> > call our selling points.
>
> yes, that is a good point. Can we make it so we can build a failover
> target for qemu? That would be very neat.

This patch (wont apply, cut n pasted, so whitespace is broken) might
already be enough...

Don't have qemu here right now, so I can't test

Signed-off-by: Stefan Reinauer

Index: src/mainboard/emulation/qemu-i386/failover.c
===================================================================
--- src/mainboard/emulation/qemu-i386/failover.c        (revision 2652)
+++ src/mainboard/emulation/qemu-i386/failover.c        (working copy)
@@ -9,9 +9,6 @@

static void main(void)
 {
-  /* for now, just always assume failure */
-
-#if 0
        /* Is this a cpu reset? */
        if (cpu_init_detected()) {
                if (last_boot_normal()) {
@@ -25,5 +22,4 @@
        else if (do_normal_boot()) {
                asm("jmp __normal_image");
        }
-#endif
 }

[roger]

On Wed, 2007-05-09 at 10:49 +0200, Stefan Reinauer wrote:
> Uwe Hermann  [070509 10:30]:
> > Drop debug.c and failover.c from the QEMU target as they're not used and
> > not useful there.
>
> Should it not rather be fixed? Since LinuxBIOS is not useful on Qemu per
> se, but only an educational target, we should not drop the stuff that we
> call our selling points.

Agreed. I wouldn't call it specifically a selling point.  It's more
educational, for me anyways, seeing how LinuxBIOS should act as I've
never had easy success with my motherboards & early_serial/console_init.

Setting LinuxBIOS to boot Filo to boot Qemu, taught me also how Filo.elf
works, etc.  (I now know what I should expect to happen with my
motherboards here... neither have gotten past elfboot yet either.)

Wed May 9 13:29:32 PDT 2007

[Stefan Reinauer]

* roger  [070509 22:29]:
> > Should it not rather be fixed? Since LinuxBIOS is not useful on Qemu per
> > se, but only an educational target, we should not drop the stuff that we
> > call our selling points.
>
> Agreed. I wouldn't call it specifically a selling point.

Fallback/Normal booting? I believe it is one of the real strengths of
LinuxBIOS. Many vendors have used hardware solutions to achieve the same
thing.

[roger]

On Wed, 2007-05-09 at 10:49 +0200, Stefan Reinauer wrote:
> Uwe Hermann  [070509 10:30]:
> > Drop debug.c and failover.c from the QEMU target as they're not used and
> > not useful there.
>
> Should it not rather be fixed? Since LinuxBIOS is not useful on Qemu per
> se, but only an educational target, we should not drop the stuff that we
> call our selling points.

Unfortunately, Qemu still requires those ram patches that I know of.

Wish the dev of qemu would apply them. :-/  ... or at least apply them
with a configure switch "--use-linuxbios".  (ie. ifdef)

Wed May 9 13:35:16 PDT 2007Roger
http://www.eskimo.com/~roger/index.html
Key fingerprint = 8977 A252 2623 F567 70CD 1261 640F C963 1005 1D61

Wed May 9 13:31:20 PDT 2007