[PATCH] flashrom: SiS620 read working

[Urja Rannikko]

Hello,

This patch allows the SiS 620 chipset to detect flash roms, and read
them fully (256k atleast). The information on what to do was read from
alldatasheet.com sis 5595 datasheet and uniflash 1.40 source, note
that i looked for only SiS620.

Also is a read success (with this patch of course, for this mb)
for an ASD AE29F2008, which detects as an Winbond W29C020C,
but should work with it's routines.
(UNIFLASH.TXT: Supported Flash Chips:
"*AE29F2008 = Winbond W29C020(C)  | 256KB")

log here:
[root@localhost flashrom]# ./flashrom -r flashrom_read.bin
Calibrating delay loop... OK.
No coreboot table found.
Found chipset "SiS5595", enabling flash write... OK.
Found chip "Winbond W29C020C" (256 KB) at physical address 0xfffc0000.
Reading Flash...done
[root@localhost flashrom]# diff flashrom_read.bin ../uniflash_bios.bin
[root@localhost flashrom]#
---
uniflash_bios.bin is a backup read with uniflash + freedos boot disk.

[Paul Menzel]

Dear Urja,

Am Samstag, den 18.10.2008, 04:11 +0300 schrieb Urja Rannikko:
> This patch allows the SiS 620 chipset to detect flash roms, and read
> them fully (256k atleast).

[…]

thank you for the patch. Not being a programmer, I cannot evaluate it,
but to get it included a Signed-off-by line is needed [1].

Thanks,

Paul

[1] http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure

[Urja Rannikko]

On Sat, Oct 18, 2008 at 4:11 AM, Urja Rannikko  wrote:
> Hello,
>
> This patch allows the SiS 620 chipset to detect flash roms, and read
> them fully (256k atleast). The information on what to do was read from
> alldatasheet.com sis 5595 datasheet and uniflash 1.40 source, note
> that i looked for only SiS620.

Sorry, forgot the Signed-off by due to never sending a patch before
(but i had read the guidelines) and sending it in a hurry (to get to
sleep, time was 04:00+...).

Signed-off-by: Urja Rannikko

[Peter Stuge]

Urja Rannikko wrote:
> Signed-off-by: Urja Rannikko

Acked-by: Peter Stuge

Thanks, applied in r3668.

//Peter