DBM690T boot log needed

[Carl-Daniel Hailfinger]

Hi,

a boot log for the DBM690T with CONSOLE_LOGLEVEL=9 would be really
great. Can anyone please mail such a log to the list?

Thanks!

Regards,
Carl-Daniel

[Carl-Daniel Hailfinger]

Hi Zheng,

could you please try to get such a DBM690T log? Thanks!

If I can compare that log with my log, I might be able to find the bug
on my 690G board.

Regards,
Carl-Daniel

On 11.12.2008 17:12, Carl-Daniel Hailfinger wrote:
> Hi,
>
> a boot log for the DBM690T with CONSOLE_LOGLEVEL=9 would be really
> great. Can anyone please mail such a log to the list?
>
> Thanks!
>
> Regards,
> Carl-Daniel

[Bao, Zheng]

Attached please find the log.

Zheng

-----Original Message-----
From: Carl-Daniel Hailfinger [mailto:[e-mail]] 
Sent: Monday, December 15, 2008 10:17 AM
To: Coreboot
Cc: Bao, Zheng
Subject: Re: [coreboot] DBM690T boot log needed

Hi Zheng,

could you please try to get such a DBM690T log? Thanks!

If I can compare that log with my log, I might be able to find the bug
on my 690G board.

Regards,
Carl-Daniel

On 11.12.2008 17:12, Carl-Daniel Hailfinger wrote:
> Hi,
>
> a boot log for the DBM690T with CONSOLE_LOGLEVEL=9 would be really
> great. Can anyone please mail such a log to the list?
>
> Thanks!
>
> Regards,
> Carl-Daniel

[Bao, Zheng]

Hi, Carl,
Base on your lspci, the device id of the 690G internal Graphics is
0x791E, while code in src/southbridge/amd/rs690/rs690_gfx.c has the id
0x791F for 690T. I changed my code to 791E and it hangs exactly where
your board does. We need to figure out a way to tell which chipset we
used.

Zheng

-----Original Message-----
From: Carl-Daniel Hailfinger [mailto:[e-mail]] 
Sent: Monday, December 15, 2008 10:17 AM
To: Coreboot
Cc: Bao, Zheng
Subject: Re: [coreboot] DBM690T boot log needed

Hi Zheng,

could you please try to get such a DBM690T log? Thanks!

If I can compare that log with my log, I might be able to find the bug
on my 690G board.

Regards,
Carl-Daniel

On 11.12.2008 17:12, Carl-Daniel Hailfinger wrote:
> Hi,
>
> a boot log for the DBM690T with CONSOLE_LOGLEVEL=9 would be really
> great. Can anyone please mail such a log to the list?
>
> Thanks!
>
> Regards,
> Carl-Daniel

[Corey Osgood]

On Mon, Dec 15, 2008 at 10:19 PM, Bao, Zheng  wrote:
> Hi, Carl,
> Base on your lspci, the device id of the 690G internal Graphics is
> 0x791E, while code in src/southbridge/amd/rs690/rs690_gfx.c has the id
> 0x791F for 690T. I changed my code to 791E and it hangs exactly where
> your board does. We need to figure out a way to tell which chipset we
> used.
>
> Zheng

You can just add another driver to the file with the same ops, like:

static struct pci_driver pcie_driver __pci_driver = {
    .ops = &pcie_ops,
    .vendor = PCI_VENDOR_ID_ATI,
    .device = PCI_DEVICE_ID_ATI_RS690MT_INT_GFX,
};

static struct pci_driver pcie_driver __pci_driver = {
    .ops = &pcie_ops,
    .vendor = PCI_VENDOR_ID_ATI,
    .device = PCI_DEVICE_ID_ATI_RS690_INT_GFX,
};

Would that fix the problem?

-Corey
> -----Original Message-----
> From: Carl-Daniel Hailfinger [mailto:[e-mail]]
> Sent: Monday, December 15, 2008 10:17 AM
> To: Coreboot
> Cc: Bao, Zheng
> Subject: Re: [coreboot] DBM690T boot log needed
>
> Hi Zheng,
>
> could you please try to get such a DBM690T log? Thanks!
>
> If I can compare that log with my log, I might be able to find the bug
> on my 690G board.
>
> Regards,
> Carl-Daniel
>
> On 11.12.2008 17:12, Carl-Daniel Hailfinger wrote:
> > Hi,
> >
> > a boot log for the DBM690T with CONSOLE_LOGLEVEL=9 would be really
> > great. Can anyone please mail such a log to the list?
> >
> > Thanks!
> >
> > Regards,
> > Carl-Daniel

[Corey Osgood]

On Mon, Dec 15, 2008 at 11:46 PM, Corey Osgood wrote:
> On Mon, Dec 15, 2008 at 10:19 PM, Bao, Zheng  wrote:
> > Hi, Carl,
> > Base on your lspci, the device id of the 690G internal Graphics is
> > 0x791E, while code in src/southbridge/amd/rs690/rs690_gfx.c has the id
> > 0x791F for 690T. I changed my code to 791E and it hangs exactly where
> > your board does. We need to figure out a way to tell which chipset we
> > used.
> >
> > Zheng
>
> You can just add another driver to the file with the same ops, like:
>
> static struct pci_driver pcie_driver __pci_driver = {
>     .ops = &pcie_ops,
>     .vendor = PCI_VENDOR_ID_ATI,
>     .device = PCI_DEVICE_ID_ATI_RS690MT_INT_GFX,
> };
>
> static struct pci_driver pcie_driver __pci_driver = {
>     .ops = &pcie_ops,
>     .vendor = PCI_VENDOR_ID_ATI,
>     .device = PCI_DEVICE_ID_ATI_RS690_INT_GFX,
> };
>
> Would that fix the problem?

Just saw your other mail, you already know ;)

-Corey

Patch for 690G and 690(MT) internal graphics

[Bao, Zheng]

Hi,
I add an entry for both 791E and 791F. 
Carl, could you please review and try it on your 690G board?

Zheng

Signed-off-by: Zheng Bao

Index: src/southbridge/amd/rs690/rs690_gfx.c
===================================================================
--- src/southbridge/amd/rs690/rs690_gfx.c	(revision 223)
+++ src/southbridge/amd/rs690/rs690_gfx.c	(working copy)
@@ -211,12 +211,22 @@
    .ops_pci = &lops_pci,
 };

-static struct pci_driver pcie_driver __pci_driver = {
+/*
+ * The dev id of 690G is 791E, while the id of 690M, 690T is 791F.
+ * We should list both of them here.
+ * */
+static struct pci_driver pcie_driver_690t __pci_driver = {
    .ops = &pcie_ops,
    .vendor = PCI_VENDOR_ID_ATI,
    .device = PCI_DEVICE_ID_ATI_RS690MT_INT_GFX,
 };

+static struct pci_driver pcie_driver_690 __pci_driver = {
+	.ops = &pcie_ops,
+	.vendor = PCI_VENDOR_ID_ATI,
+	.device = PCI_DEVICE_ID_ATI_RS690_INT_GFX,
+};
+
 /* step 12 ~ step 14 from rpr */
 static void single_port_configuration(device_t nb_dev, device_t dev)
 {

-----Original Message-----
From: Carl-Daniel Hailfinger [mailto:[e-mail]] 
Sent: Monday, December 15, 2008 10:17 AM
To: Coreboot
Cc: Bao, Zheng
Subject: Re: [coreboot] DBM690T boot log needed

Hi Zheng,

could you please try to get such a DBM690T log? Thanks!

If I can compare that log with my log, I might be able to find the bug
on my 690G board.

Regards,
Carl-Daniel

On 11.12.2008 17:12, Carl-Daniel Hailfinger wrote:
> Hi,
>
> a boot log for the DBM690T with CONSOLE_LOGLEVEL=9 would be really
> great. Can anyone please mail such a log to the list?
>
> Thanks!
>
> Regards,
> Carl-Daniel

Patch for 690G and 690(MT) internal graphics

[Carl-Daniel Hailfinger]

Hi Zheng,

On 16.12.2008 04:41, Bao, Zheng wrote:
> I add an entry for both 791E and 791F. 
> Carl, could you please review and try it on your 690G board?

This is absolutely GREAT! It works perfectly. Thank you!
> Zheng
>
> Signed-off-by: Zheng Bao

Acked-by: Carl-Daniel Hailfinger

and committed in revision 3816.

I have attached my Asus M2A-VM boot log. Together with the ncHT fixup,
it boots until elfboot. I'll post a cleaned up HT fixup soon.

Regards,
Carl-Daniel

Patch for 690G and 690(MT) internal graphics

[Bao, Zheng]

It's truly great.

It is greater if you send a patch with signed-off-by and I will try on
my 690t board.

Thanks.

Zheng

-----Original Message-----
From: Carl-Daniel Hailfinger [mailto:[e-mail]] 
Sent: Wednesday, December 17, 2008 10:17 AM
To: Bao, Zheng
Cc: Coreboot
Subject: Re: [coreboot] Patch for 690G and 690(MT) internal graphics

Hi Zheng,

On 16.12.2008 04:41, Bao, Zheng wrote:
> I add an entry for both 791E and 791F. 
> Carl, could you please review and try it on your 690G board?

This is absolutely GREAT! It works perfectly. Thank you!
> Zheng
>
> Signed-off-by: Zheng Bao

Acked-by: Carl-Daniel Hailfinger

and committed in revision 3816.

I have attached my Asus M2A-VM boot log. Together with the ncHT fixup,
it boots until elfboot. I'll post a cleaned up HT fixup soon.

Regards,
Carl-Daniel