Updated coreboot build environment for Windows

[Scott Duplichan]

I have maintained a coreboot build environment for Windows for a while:
http://notabs.org/coreboot/windows-build.htm

Though maintaining it has never been a priority for me,
the website log files show quite a few people download it.
For this reason I am trying to improve this project. The 
recently submitted patches get the Windows hosted coreboot
build environment working well enough for abuild to pass
for all builds using gcc: x86, ARM, and AARCH64. There is
no clang or riscv support.

There is one patch I haven't been able to submit. For Windows
hosted building, file util/nvidia/cbootimage/src/set.c needs
to fopen binary files using "rb" instead of "r". This file
is part of a git 'submodule'. How do build and upload a patch
for this file?

Thanks,
Scott

[Peter Stuge]

Scott Duplichan wrote:
> There is one patch I haven't been able to submit. For Windows
> hosted building, file util/nvidia/cbootimage/src/set.c needs
> to fopen binary files using "rb" instead of "r". This file
> is part of a git 'submodule'. How do build and upload a patch
> for this file?

It's a two-step process.

First, commit and push the change to the submodule repo. Do this by
changing the file in your working directory as usual, committing as
usual and then pushing that commit through whatever channel applies
to that particular repository. (Maybe also our gerrit. I don't know.)

Once your commit is available in the public nvidia-cbootimage
repository, cd into util/nvidia/cbootimage, fetch the new commit into
the submodule repo, then - still in cbootimage/ - git checkout the
commit you want to be referenced by coreboot.git going forward.

Then cd .. and git commit cbootimage, in order to create a new commit
in coreboot.git which switches it to use the new submodule commit.

Finally push that to gerrit for review as usual.

//Peter

[Scott Duplichan]

Peter Stuge [mailto:[e-mail]] wrote:

]Sent: Saturday, December 13, 2014 05:15 PM
]To: [e-mail]
]Subject: Re: [coreboot] Updated coreboot build environment for Windows
]
]Scott Duplichan wrote:
]> There is one patch I haven't been able to submit. For Windows
]> hosted building, file util/nvidia/cbootimage/src/set.c needs
]> to fopen binary files using "rb" instead of "r". This file
]> is part of a git 'submodule'. How do build and upload a patch
]> for this file?
]
]It's a two-step process.
]
]First, commit and push the change to the submodule repo. Do this by
]changing the file in your working directory as usual, committing as
]usual and then pushing that commit through whatever channel applies
]to that particular repository. (Maybe also our gerrit. I don't know.)
]
]Once your commit is available in the public nvidia-cbootimage
]repository, cd into util/nvidia/cbootimage, fetch the new commit into
]the submodule repo, then - still in cbootimage/ - git checkout the
]commit you want to be referenced by coreboot.git going forward.
]
]Then cd .. and git commit cbootimage, in order to create a new commit
]in coreboot.git which switches it to use the new submodule commit.
]
]Finally push that to gerrit for review as usual.
]
]
]//Peter

Thanks Peter, it worked.
http://review.coreboot.org/#/c/7795/

Thanks,
Scott

[Patrick Georgi]

Am 13.12.2014 um 15:14 schrieb Peter Stuge:
> Finally push that to gerrit for review as usual.

... and ideally also push it upstream.

They want it as mail, linux-style to [e-mail], with
some note that it's for the cbootimage repository.

Patrick

[Peter Stuge]

Peter Stuge wrote:
> First, commit and push the change to the submodule repo. Do this by
> changing the file in your working directory as usual, committing as
> usual and then pushing that commit through whatever channel applies
> to that particular repository. (Maybe also our gerrit. I don't know.)

Patrick Georgi wrote:
> ... and ideally also push it upstream.
>
> They want it as mail, linux-style to [e-mail],
> with some note that it's for the cbootimage repository.

Right, that's the "channel" I was refering to. I didn't know if this
tool is ours or from elsewhere.

//Peter

[Peter Stuge]

Peter Stuge wrote:
> Peter Stuge wrote:
> > First, commit and push the change to the submodule repo. Do this by
> > changing the file in your working directory as usual, committing as
> > usual and then pushing that commit through whatever channel applies
> > to that particular repository. (Maybe also our gerrit. I don't know.)
>
> Patrick Georgi wrote:
> > ... and ideally also push it upstream.
> >
> > They want it as mail, linux-style to [e-mail],
> > with some note that it's for the cbootimage repository.
>
> Right, that's the "channel" I was refering to. I didn't know if this
> tool is ours or from elsewhere.

To clarify, it is important to wait until the neccessary change has
been included upstream before changing the refered-to commit in
coreboot.git - otherwise Scott is the only person in the world who
has this particular commit. Maybe the cbootimage maintainers will
make some change to the commit or rebase it onto some local changes
of theirs before they publish it in their repo.

It's important that coreboot.git references a commit hash which is
actually available in the public submodule repo. Since that's not a
repo of ours we have to wait until the change is available there.

//Peter

[Scott Duplichan]

Peter Stuge [mailto:[e-mail]] wrote:

]Sent: Sunday, December 14, 2014 02:43 PM
]To: [e-mail]
]Subject: Re: [coreboot] Updated coreboot build environment for Windows
]
]Peter Stuge wrote:
]> Peter Stuge wrote:
]> > First, commit and push the change to the submodule repo. Do this by
]> > changing the file in your working directory as usual, committing as
]> > usual and then pushing that commit through whatever channel applies
]> > to that particular repository. (Maybe also our gerrit. I don't know.)
]> 
]> Patrick Georgi wrote:
]> > ... and ideally also push it upstream.
]> > 
]> > They want it as mail, linux-style to [e-mail],
]> > with some note that it's for the cbootimage repository.
]> 
]> Right, that's the "channel" I was refering to. I didn't know if this
]> tool is ours or from elsewhere.
]
]To clarify, it is important to wait until the neccessary change has
]been included upstream before changing the refered-to commit in
]coreboot.git - otherwise Scott is the only person in the world who
]has this particular commit. Maybe the cbootimage maintainers will
]make some change to the commit or rebase it onto some local changes
]of theirs before they publish it in their repo.
]
]It's important that coreboot.git references a commit hash which is
]actually available in the public submodule repo. Since that's not a
]repo of ours we have to wait until the change is available there.

Hello Peter. Thanks for explaining. Sounds like I did things out of
sequence. The change is now in the NVIDIA cbootimage repository at
github.com/NVIDIA/cbootimage. What steps are needed to get the change
into the coreboot repository?

Thanks,
Scott

]//Peter

[Patrick Georgi]

Am 2014-12-16 12:56, schrieb Scott Duplichan:
> Hello Peter. Thanks for explaining. Sounds like I did things out of
> sequence.

submodules are a bit convoluted...
> The change is now in the NVIDIA cbootimage repository at
> github.com/NVIDIA/cbootimage. What steps are needed to get the change
> into the coreboot repository?

We automatically update our mirrors. From there, we just need to adapt 
the
commit the submodule points to, see #7827.

Patrick

[Scott Duplichan]

Patrick Georgi [mailto:[e-mail]] wrote:

]Sent: Sunday, December 14, 2014 09:38 AM
]To: [e-mail]
]Subject: Re: [coreboot] Updated coreboot build environment for Windows
]
]Am 13.12.2014 um 15:14 schrieb Peter Stuge:
]> Finally push that to gerrit for review as usual.
]... and ideally also push it upstream.
]
]They want it as mail, linux-style to [e-mail], with
]some note that it's for the cbootimage repository.

OK, here it is,
http://thread.gmane.org/gmane.linux.ports.tegra/20348

Thanks,
Scott

]
]Patrick