[Fwd: [patch][v2] cs5536 usb port4 configuration]

[Marc Jones]

This patch seems to have fallen through the cracks.
ACKs?

-------- Original Message --------
Subject: [patch][v2] cs5536 usb port4 configuration
Date: Wed, 04 Jun 2008 13:21:46 -0600
From: Marc Jones 
To: Coreboot

This patch uses byte pointer and the MMIO read and write functions.

Marc

[Carl-Daniel Hailfinger]

On 12.07.2008 01:26, Marc Jones wrote:
> This patch seems to have fallen through the cracks.
> ACKs?

I'm not sure whether the code in v2 should deviate from the code in v3.
Ron committed the following in r689 to v3 (excerpted):

Index: southbridge/amd/cs5536/cs5536.c
===================================================================
--- southbridge/amd/cs5536/cs5536.c	(Revision 688)
+++ southbridge/amd/cs5536/cs5536.c	(Revision 689)
@@ -395,18 +395,19 @@
    }
 }

-#define HCCPARAMS		0x08
-#define IPREG04			0xA0
+/* the /sizeof(u32) is to convert byte offsets into u32 offsets */
+#define HCCPARAMS		(0x08/sizeof(u32))
+#define IPREG04			(0xA0/sizeof(u32))
 #define USB_HCCPW_SET		(1 << 1)
 #define UOCCAP			0x00
 #define APU_SET			(1 << 15)
-#define UOCMUX			0x04
+#define UOCMUX			(0x04/sizeof(u32))
 #define PMUX_HOST		0x02
 #define PMUX_DEVICE		0x03
 #define PUEN_SET		(1 << 2)
-#define UDCDEVCTL		0x404
+#define UDCDEVCTL		(0x404/sizeof(u32))
 #define UDC_SD_SET		(1 << 10)
-#define UOCCTL			0x0C
+#define UOCCTL			(0x0C/sizeof(u32))
 #define PADEN_SET		(1 << 7)

/**

I do not have a strong opinion either way. What do you think?

Regards,
Carl-Daniel

[Marc Jones]

Carl-Daniel Hailfinger wrote:
> On 12.07.2008 01:26, Marc Jones wrote:
> > This patch seems to have fallen through the cracks.
> > ACKs?
>
> I'm not sure whether the code in v2 should deviate from the code in v3.
> Ron committed the following in r689 to v3 (excerpted):

...
> I do not have a strong opinion either way. What do you think?

I think that the v2 should only change what needs changing. v3 can get 
all the makeover it likes.

Marc

[ron minnich]

my patch was not really good. We need to do v3 right. Let me know
which patch to use and I'll test it.

ron

[Carl-Daniel Hailfinger]

On 12.07.2008 01:50, ron minnich wrote:
> my patch was not really good. We need to do v3 right. Let me know
> which patch to use and I'll test it.

OK, then I'd say we use Marc's variant for v2 and v3.

Regards,
Carl-Daniel