[LinuxBIOS] CS5536 vs. CS5536 LX

[Uwe Hermann]

Hi,

we have two similar directories in svn:

src/southbridge/amd/cs5536
src/southbridge/amd/cs5536_lx

Why do we have two? Are they substantially different? Why? IMHO one of
them should be removed and/or merged into the other one. Feasible?

Uwe.

[Indrek Kruusa]

Ühel kenal päeval (esmaspäev 21 mai 2007 4:12 pm) kirjutas Uwe Hermann:
> Hi,
>
> we have two similar directories in svn:
>
> src/southbridge/amd/cs5536
> src/southbridge/amd/cs5536_lx
>
> Why do we have two? Are they substantially different? Why? IMHO one of
> them should be removed and/or merged into the other one. Feasible?

cs5536_lx  were created (by Ron) due to the fact that at the beginning we 
haven't found a good way to unify GX2/CS5536 and LX/CS5536 configurations.
Currently it seems to be obsolete.

Indrek

[Stefan Reinauer]

* Indrek Kruusa  [070521 15:33]:
> Ühel kenal päeval (esmaspäev 21 mai 2007 4:12 pm) kirjutas Uwe Hermann:
> > Why do we have two? Are they substantially different? Why? IMHO one of
> > them should be removed and/or merged into the other one. Feasible?
>
> cs5536_lx  were created (by Ron) due to the fact that at the beginning we 
> haven't found a good way to unify GX2/CS5536 and LX/CS5536 configurations.
> Currently it seems to be obsolete.

What's the reason? No GX1 with 5536 available anymore?

[Indrek Kruusa]

Ühel kenal päeval (esmaspäev 21 mai 2007 5:49 pm) kirjutas Stefan Reinauer:
> Indrek Kruusa  [070521 15:33]:
> > Ühel kenal päeval (esmaspäev 21 mai 2007 4:12 pm) kirjutas Uwe Hermann:
> > > Why do we have two? Are they substantially different? Why? IMHO one of
> > > them should be removed and/or merged into the other one. Feasible?
> >
> > cs5536_lx  were created (by Ron) due to the fact that at the beginning we
> > haven't found a good way to unify GX2/CS5536 and LX/CS5536
> > configurations. Currently it seems to be obsolete.
>
> What's the reason? No GX1 with 5536 available anymore?

Haven't followed the discussion nor latest changes though. I just grep'ed the 
source :)

Indrek

[Marc Jones]

Uwe Hermann wrote:
> Hi,
>
> we have two similar directories in svn:
>
> src/southbridge/amd/cs5536
> src/southbridge/amd/cs5536_lx
>
> Why do we have two? Are they substantially different? Why? IMHO one of
> them should be removed and/or merged into the other one. Feasible?
>
> Uwe.

cs5536_lx should be removed. It is no longer required with the updates 
to cs5536 and the GX/LX northbridge files. I am working with Indrek to 
get the dbe61 mainboard working without it.

Marc

[Uwe Hermann]

On Mon, May 21, 2007 at 04:56:20PM -0600, Marc Jones wrote:
> > we have two similar directories in svn:
> >
> > src/southbridge/amd/cs5536
> > src/southbridge/amd/cs5536_lx
> >
> > Why do we have two? Are they substantially different? Why? IMHO one of
> > them should be removed and/or merged into the other one. Feasible?
>
> cs5536_lx should be removed. It is no longer required with the updates 
> to cs5536 and the GX/LX northbridge files. I am working with Indrek to 
> get the dbe61 mainboard working without it.

OK, great! Can you please look over the cs5536_lx code if there are some
parts which are still useful and could be merged into the cs5536 code?

Anyway, as soon as the dbe61 is fixed to not use the cs5536_lx code
any more I think we'll drop it.

Thanks, Uwe.

[Indrek Kruusa]

Ühel kenal päeval (teisipäev 22 mai 2007 1:17 pm) kirjutas Uwe Hermann:
> On Mon, May 21, 2007 at 04:56:20PM -0600, Marc Jones wrote:
> > > we have two similar directories in svn:
> > >
> > > src/southbridge/amd/cs5536
> > > src/southbridge/amd/cs5536_lx
> > >
> > > Why do we have two? Are they substantially different? Why? IMHO one of
> > > them should be removed and/or merged into the other one. Feasible?
> >
> > cs5536_lx should be removed. It is no longer required with the updates
> > to cs5536 and the GX/LX northbridge files. I am working with Indrek to
> > get the dbe61 mainboard working without it.
>
> OK, great! Can you please look over the cs5536_lx code if there are some
> parts which are still useful and could be merged into the cs5536 code?
>
> Anyway, as soon as the dbe61 is fixed to not use the cs5536_lx code
> any more I think we'll drop it.

You can drop it right now. Marc has prepared the CAR patch for dbe61 which 
also removes the link to cs5536_lx. As our target remains broken til the 
final CAR patch you don't need to hold cs5536_lx for us.

thanks,
Indrek

[Marc Jones]

Indrek Kruusa wrote:
> Ühel kenal päeval (teisipäev 22 mai 2007 1:17 pm) kirjutas Uwe Hermann:
> > On Mon, May 21, 2007 at 04:56:20PM -0600, Marc Jones wrote:
> > > > we have two similar directories in svn:
> > > >
> > > > src/southbridge/amd/cs5536
> > > > src/southbridge/amd/cs5536_lx
> > > >
> > > > Why do we have two? Are they substantially different? Why? IMHO one of
> > > > them should be removed and/or merged into the other one. Feasible?
> > >
> > > cs5536_lx should be removed. It is no longer required with the updates
> > > to cs5536 and the GX/LX northbridge files. I am working with Indrek to
> > > get the dbe61 mainboard working without it.
> >
> > OK, great! Can you please look over the cs5536_lx code if there are some
> > parts which are still useful and could be merged into the cs5536 code?
> >
> > Anyway, as soon as the dbe61 is fixed to not use the cs5536_lx code
> > any more I think we'll drop it.
>
> You can drop it right now. Marc has prepared the CAR patch for dbe61 which 
> also removes the link to cs5536_lx. As our target remains broken til the 
> final CAR patch you don't need to hold cs5536_lx for us.
>
> thanks,
> Indrek

Uwe,

I think we have everything we need from cs5536_lx. It can be dropped at 
your convenience.

Marc