Hi,
I've extended the ite.c part to include dumping the environmental controller register contents too. It's amazingly easy to add such things. Only IT8716f (that's the only datasheet I have at the moment).
Signed-off-by: Ronald Hoogenboom hoogenboom30@zonnet.nl
On Thursday 21 February 2008, Ronald Hoogenboom wrote:
Hi,
I've extended the ite.c part to include dumping the environmental controller register contents too. It's amazingly easy to add such things. Only IT8716f (that's the only datasheet I have at the moment).
Signed-off-by: Ronald Hoogenboom hoogenboom30@zonnet.nl
Longopts means you can alternatively type the long name. "superiotool --dump --'dump ec too' " would look a little silly, so I suggest to call it "ec-dump", OK?
Otherwise Ack by me, but I'd like to hear from Carl-Daniel or Uwe, too.
Torsten
On Fri, Feb 22, 2008 at 12:34:09AM +0100, Torsten Duwe wrote:
I suggest to call it "ec-dump"
I like dumpec, dump-ec or ecdump. Bikeshed though.
Acked-by: Peter Stuge peter@stuge.se
On 22.02.2008 04:17, Peter Stuge wrote:
On Fri, Feb 22, 2008 at 12:34:09AM +0100, Torsten Duwe wrote:
I suggest to call it "ec-dump"
I like dumpec, dump-ec or ecdump. Bikeshed though.
We already have --dump, so I'd like the new option not to have an existing option as prefix, especially considering the fact that superiotool may be linked against libraries which can't handle that.
But since we are painting the bikeshed, here's my take: --ec-dump or --ecdump. Especially since someone (hint, hint) could extend superiotool to dump Super I/O GPIO configuration as well.
Acked-by: Peter Stuge peter@stuge.se
Regards, Carl-Daniel
On Fri, 2008-02-22 at 00:34 +0100, Torsten Duwe wrote:
Longopts means you can alternatively type the long name. "superiotool --dump --'dump ec too' " would look a little silly, so I suggest to call it "ec-dump", OK?
OK, sorry, but I didn't put more than 2 seconds in the option parsing bit. The short option is always less typing anyway ;->>.
Otherwise Ack by me, but I'd like to hear from Carl-Daniel or Uwe, too.
Torsten
Ronald.
On 21.02.2008 19:05, Ronald Hoogenboom wrote:
Hi,
I've extended the ite.c part to include dumping the environmental controller register contents too. It's amazingly easy to add such things.
While I agree with you that adding that dumping capability was easy, I consider the actual implementation an abuse of the existing dumping functionality, but it's a clever abuse, so I'm not going to veto it. The dumping capability part of the patch is Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Only IT8716f (that's the only datasheet I have at the moment).
I checked the data sheets of the whole IT87[012] series and although the environment controller is sometimes called fan controller, the location of the register is the same for all models.
Signed-off-by: Ronald Hoogenboom hoogenboom30@zonnet.nl
There is one problem I'd like to solve before committing: The name of the parameter. While "--ec-dump" or "--ecdump" sound great at first, both of them have the problem that the acronym "EC" is ambiguous in the context of Super I/O chips. It can either mean "Environment Controller" or "Embedded Controller". In the future, superiotool will be able to dump settings of both types of these devices, so I fear the parameter has to be replaced by something like "--environ-dump".
Thoughts? We should wait with the commit until there is consensus about the name of the long option.
Regards, Carl-Daniel
On Fri, 2008-02-22 at 23:15 +0100, Carl-Daniel Hailfinger wrote:
There is one problem I'd like to solve before committing: The name of the parameter. While "--ec-dump" or "--ecdump" sound great at first, both of them have the problem that the acronym "EC" is ambiguous in the context of Super I/O chips. It can either mean "Environment Controller" or "Embedded Controller". In the future, superiotool will be able to dump settings of both types of these devices, so I fear the parameter has to be replaced by something like "--environ-dump".
How about --envctl-dump or maybe (to emphasize the term 'long' option) --environmental-controller-configuration-dump. I should have spend more than 2 seconds when copying the new option from the existing --dump, maybe we wouldn't have had to reach consensus in the first place. I'll be more careful in the future.
Ronald.
PS. do you want me to re-generate the patch with changed long option?
On Friday 22 February 2008, Ronald Hoogenboom wrote:
How about --envctl-dump or maybe (to emphasize the term 'long' option) --environmental-controller-configuration-dump.
Nah, that'd be the long long option ;-)
PS. do you want me to re-generate the patch with changed long option?
Once we agree on the name, yes please. It makes it easier for the Signed-off-by. I find it hard to sign-off other people's work, or modify it after they "signed" it.
Torsten
I have 2 versions to throw in.
On Friday 22 February 2008, Carl-Daniel Hailfinger wrote:
It can either mean "Environment Controller" or "Embedded Controller". In the future, superiotool will be able to dump settings of both types of these devices, so I fear the parameter has to be replaced by something like "--environ-dump".
--env-dump, because I consider that a common abbreviation ("man 1 env").
Thoughts? We should wait with the commit until there is consensus about the name of the long option.
OTOH the whole thing is about voltages, fans and temperature sensors, right? Then there's a package called lm-sensors, so why not --sensors or --sensors-dump? "Environment" is also quite ambiguous, and the -s is still available, so --sensors* would be my favourite.
Torsten
On Fri, 2008-02-22 at 23:48 +0100, Torsten Duwe wrote:
OTOH the whole thing is about voltages, fans and temperature sensors, right? Then there's a package called lm-sensors, so why not --sensors or --sensors-dump? "Environment" is also quite ambiguous, and the -s is still available, so --sensors* would be my favourite.
The term Environmental Controller comes straight from the ITE datasheet. This 'sensors' thing might again be confused with only the read-out of the sensors itself, like lm-sensors (which I omitted from the list, as I'm only interrested in the settable configuration stuff). It's not only the sensors, but more the parameters for automatic control of fans by these sensors and the masking of interrupts that might be generated, that is of importance for the BIOS to set-up properly.
I still like --ec-dump best...
Torsten
Ronald.
On 22.02.2008 23:48, Torsten Duwe wrote:
I have 2 versions to throw in.
On Friday 22 February 2008, Carl-Daniel Hailfinger wrote:
It can either mean "Environment Controller" or "Embedded Controller". In the future, superiotool will be able to dump settings of both types of these devices, so I fear the parameter has to be replaced by something like "--environ-dump".
--env-dump, because I consider that a common abbreviation ("man 1 env").
Because of "man 1 env" and the completely different meaning of it, I'd call it "--envctl-dump".
Thoughts? We should wait with the commit until there is consensus about the name of the long option.
OTOH the whole thing is about voltages, fans and temperature sensors, right? Then there's a package called lm-sensors, so why not --sensors or --sensors-dump? "Environment" is also quite ambiguous, and the -s is still available, so --sensors* would be my favourite.
"--sensors-fan-voltage-controller-dump"? Older ITE datasheets call this thin a "Fan Controller".
Maybe we should wait for input on the name until monday before this is committed.
Regards, Carl-Daniel
On Fri, Feb 22, 2008 at 6:21 PM, Carl-Daniel Hailfinger < c-d.hailfinger.devel.2006@gmx.net> wrote:
On 22.02.2008 23:48, Torsten Duwe wrote:
I have 2 versions to throw in.
On Friday 22 February 2008, Carl-Daniel Hailfinger wrote:
It can either mean "Environment Controller" or "Embedded Controller". In the future, superiotool will be able to dump settings of both types of these devices, so I fear the parameter has to be replaced by something like "--environ-dump".
--env-dump, because I consider that a common abbreviation ("man 1 env").
Because of "man 1 env" and the completely different meaning of it, I'd call it "--envctl-dump".
Thoughts? We should wait with the commit until there is consensus about the name of the long option.
OTOH the whole thing is about voltages, fans and temperature sensors,
right?
Then there's a package called lm-sensors, so why not --sensors or --sensors-dump? "Environment" is also quite ambiguous, and the -s is
still
available, so --sensors* would be my favourite.
"--sensors-fan-voltage-controller-dump"? Older ITE datasheets call this thin a "Fan Controller".
Maybe we should wait for input on the name until monday before this is committed.
Regards, Carl-Daniel
Why not something more generic, like --advanced-dump, --adv-dump, --extra-dump, or something better. That way we cover all bases, without getting into the extremely long options. In the future, when we start messing with embedded controllers, it could cover that as well, the embedded controller also probably has its paws on the same controls anyway. Heck, if we really wanted, it could cover GPIOs too, so we end up with all the info you can get in one shot.
-Corey
Quoting Corey Osgood corey.osgood@gmail.com:
On Fri, Feb 22, 2008 at 6:21 PM, Carl-Daniel Hailfinger < c-d.hailfinger.devel.2006@gmx.net> wrote:
On 22.02.2008 23:48, Torsten Duwe wrote:
I have 2 versions to throw in.
On Friday 22 February 2008, Carl-Daniel Hailfinger wrote:
It can either mean "Environment Controller" or "Embedded Controller". In the future, superiotool will be able to dump settings of both types of these devices, so I fear the parameter has to be replaced by something like "--environ-dump".
--env-dump, because I consider that a common abbreviation ("man 1 env").
Because of "man 1 env" and the completely different meaning of it, I'd call it "--envctl-dump".
Thoughts? We should wait with the commit until there is consensus about the name of the long option.
OTOH the whole thing is about voltages, fans and temperature sensors,
right?
Then there's a package called lm-sensors, so why not --sensors or --sensors-dump? "Environment" is also quite ambiguous, and the -s is
still
available, so --sensors* would be my favourite.
"--sensors-fan-voltage-controller-dump"? Older ITE datasheets call this thin a "Fan Controller".
Maybe we should wait for input on the name until monday before this is committed.
Regards, Carl-Daniel
Why not something more generic, like --advanced-dump, --adv-dump, --extra-dump, or something better. That way we cover all bases, without getting into the extremely long options. In the future, when we start messing with embedded controllers, it could cover that as well, the embedded controller also probably has its paws on the same controls anyway. Heck, if we really wanted, it could cover GPIOs too, so we end up with all the info you can get in one shot.
-Corey
I like your idea Corey. On smsc it would great to be able to dump all of the "Runtime Registers" (GPIO's are there also).....
Thanks - Joe
On Saturday 23 February 2008, Corey Osgood wrote:
On Fri, Feb 22, 2008 at 6:21 PM, Carl-Daniel Hailfinger <
Maybe we should wait for input on the name until monday before this is committed.
Why not something more generic, like --advanced-dump, --adv-dump, --extra-dump, or something better. That way we cover all bases, without getting into the extremely long options. In the future, when we start messing with embedded controllers, it could cover that as well, [...]
In order to reach consensus, I hereby join the "--extra-dump" crowd. Anyone wants to discuss this further?
Torsten
On Mon, Feb 25, 2008 at 11:26:13AM +0100, Torsten Duwe wrote:
On Saturday 23 February 2008, Corey Osgood wrote:
On Fri, Feb 22, 2008 at 6:21 PM, Carl-Daniel Hailfinger <
Maybe we should wait for input on the name until monday before this is committed.
Why not something more generic, like --advanced-dump, --adv-dump, --extra-dump, or something better. That way we cover all bases, without getting into the extremely long options. In the future, when we start messing with embedded controllers, it could cover that as well, [...]
In order to reach consensus, I hereby join the "--extra-dump" crowd. Anyone wants to discuss this further?
I like --extra-dump.
Ronald, can you please repost the patch with that rename (and a Signed-off-by, of course) and also fix the following issues:
- Add your name/email to the list of contributors in README.
- Update the manpage and README to document the new option.
- Make all lines shorter than 80 characters in the code and docs.
If there are no further comments on the new patch, I'll test it on 1-2 ITE boxes and commit.
Thanks, Uwe.
On Mon, 2008-02-25 at 14:57 +0100, Uwe Hermann wrote:
Ronald, can you please repost the patch with that rename (and a Signed-off-by, of course) and also fix the following issues:
Add your name/email to the list of contributors in README.
Update the manpage and README to document the new option.
Make all lines shorter than 80 characters in the code and docs.
If there are no further comments on the new patch, I'll test it on 1-2 ITE boxes and commit.
Please find attached the patched patch, patched to suit the above requirements.
This patch adds support to dump other registers than the primary pnp-style configuration registers, using the new option -e/--extra-dump. This patch only adds dumping of the Environmental Controller configuration registers for the IT8716f chip.
Signed-off-by: Ronald Hoogenboom hoogenboom30@zonnet.nl
Regards, Ronald.
On 25.02.2008 23:13, Ronald Hoogenboom wrote:
On Mon, 2008-02-25 at 14:57 +0100, Uwe Hermann wrote:
Ronald, can you please repost the patch with that rename (and a Signed-off-by, of course) and also fix the following issues:
Add your name/email to the list of contributors in README.
Update the manpage and README to document the new option.
Make all lines shorter than 80 characters in the code and docs.
If there are no further comments on the new patch, I'll test it on 1-2 ITE boxes and commit.
Please find attached the patched patch, patched to suit the above requirements.
This patch adds support to dump other registers than the primary pnp-style configuration registers, using the new option -e/--extra-dump. This patch only adds dumping of the Environmental Controller configuration registers for the IT8716f chip.
Signed-off-by: Ronald Hoogenboom hoogenboom30@zonnet.nl
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Thanks, r3117.
Regards, Carl-Daniel
-
Carl-Daniel Hailfinger -
Corey Osgood -
joe＠smittys.pointclark.net -
Peter Stuge -
Ronald Hoogenboom -
Torsten Duwe -
Uwe Hermann