Patrick Georgi (patrick@georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1250
-gerrit
commit 05ca672a0521ce81886e1bd4bfecfc81970507e6 Author: Patrick Georgi patrick.georgi@secunet.com Date: Fri Jul 20 11:55:19 2012 +0200
Drop VGA_BRIDGE_SETUP config option
It defaults to true, and isn't disabled anywhere in the tree. I also couldn't think of a case where it's actually useful.
Change-Id: I126a47625d5294f3cfff225629f2a948a83c9b7e Signed-off-by: Patrick Georgi patrick.georgi@secunet.com --- src/devices/Kconfig | 7 ------- src/devices/device.c | 5 ----- src/northbridge/amd/gx2/Kconfig | 2 +- 3 files changed, 1 insertions(+), 13 deletions(-)
diff --git a/src/devices/Kconfig b/src/devices/Kconfig index 5168819..cec2048 100644 --- a/src/devices/Kconfig +++ b/src/devices/Kconfig @@ -18,13 +18,6 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ##
-config VGA_BRIDGE_SETUP - bool "Setup bridges on path to VGA adapter" - default y - help - Allow bridges to set up legacy decoding ranges for VGA. Don't disable - this unless you're sure you don't want the briges setup for VGA. - # TODO: Explain differences (if any) for onboard cards. config VGA_ROM_RUN bool "Run VGA Option ROMs" diff --git a/src/devices/device.c b/src/devices/device.c index c378078..d3f9b52 100644 --- a/src/devices/device.c +++ b/src/devices/device.c @@ -705,7 +705,6 @@ static void avoid_fixed_resources(struct device *dev) } }
-#if CONFIG_VGA_BRIDGE_SETUP device_t vga_pri = 0; static void set_vga_bridge_bits(void) { @@ -781,8 +780,6 @@ static void set_vga_bridge_bits(void) } }
-#endif - /** * Assign the computed resources to the devices on the bus. * @@ -964,9 +961,7 @@ void dev_configure(void) struct device *root; struct device *child;
-#if CONFIG_VGA_BRIDGE_SETUP set_vga_bridge_bits(); -#endif
printk(BIOS_INFO, "Allocating resources...\n");
diff --git a/src/northbridge/amd/gx2/Kconfig b/src/northbridge/amd/gx2/Kconfig index ae532bd..5140409 100644 --- a/src/northbridge/amd/gx2/Kconfig +++ b/src/northbridge/amd/gx2/Kconfig @@ -24,7 +24,7 @@ config NORTHBRIDGE_AMD_GX2 choice prompt "Framebuffer size" default GX2_VIDEO_MB_8MB - depends on NORTHBRIDGE_AMD_GX2 && VGA_BRIDGE_SETUP + depends on NORTHBRIDGE_AMD_GX2
config GX2_VIDEO_MB_4MB bool "4MB"
-
Patrick Georgi