What is the way to add a VGA ROM space in target\xx\xx\Config.lb

[Bao, Zheng]

In a Config.lb like this 
(in coreboot-v2/targets/amd/serengeti_cheetah_fam10/Config.lb):

## 
## This file is part of the coreboot project. 
## 
## Copyright (C) 2007 Advanced Micro Devices, Inc. 
## 
## This program is free software; you can redistribute it and/or modify 
## it under the terms of the GNU General Public License as published by 
## the Free Software Foundation; either version 2 of the License, or 
## (at your option) any later version. 
## 
## This program is distributed in the hope that it will be useful, 
## but WITHOUT ANY WARRANTY; without even the implied warranty of 
## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the 
## GNU General Public License for more details. 
## 
## You should have received a copy of the GNU General Public License 
## along with this program; if not, write to the Free Software 
## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301
USA 
##

# Sample config file for 
# the amd cheetah_fam10 
# This will make a target directory of ./serengeti_cheetah_fam10

target serengeti_cheetah_fam10 
mainboard amd/serengeti_cheetah_fam10 
# Request this level of debugging output 
        option  CONFIG_DEFAULT_CONSOLE_LOGLEVEL=9 
# At a maximum only compile in this level of debugging 
        option  CONFIG_MAXIMUM_CONSOLE_LOGLEVEL=9

# 512KB ROM 
option CONFIG_ROM_SIZE=1024*1024

# Cheetah Family 10 
#romimage "normal" 
#       1MB ROM 
#       option CONFIG_ROM_SIZE = 0x100000 
#       option CONFIG_USE_FAILOVER_IMAGE=0 
#       option CONFIG_USE_FALLBACK_IMAGE=0 
#       option CONFIG_ROM_IMAGE_SIZE=0x20000 
#       option CONFIG_ROM_IMAGE_SIZE=0x30000 
#       option CONFIG_XIP_ROM_SIZE=0x40000 
#       option COREBOOT_EXTRA_VERSION="$(shell cat
../../VERSION)_Normal" 
#       payload ../payload.elf 
#end

romimage "fallback" 
        option CONFIG_USE_FAILOVER_IMAGE=0 
        option CONFIG_USE_FALLBACK_IMAGE=1 
#       option CONFIG_ROM_IMAGE_SIZE=0x13800 
#       option CONFIG_ROM_IMAGE_SIZE=0x19800 
        option CONFIG_ROM_IMAGE_SIZE=0x7f000 
#       option CONFIG_ROM_IMAGE_SIZE=0x15800 
        option CONFIG_XIP_ROM_SIZE=0x80000 
        option COREBOOT_EXTRA_VERSION="$(shell cat
../../VERSION)_Fallback" 
        payload ../payload.elf 
end

romimage "failover" 
        option CONFIG_USE_FAILOVER_IMAGE=1 
        option CONFIG_USE_FALLBACK_IMAGE=0 
        option CONFIG_ROM_IMAGE_SIZE=CONFIG_FAILOVER_SIZE 
        option CONFIG_XIP_ROM_SIZE=CONFIG_FAILOVER_SIZE 
        option COREBOOT_EXTRA_VERSION="$(shell cat
../../VERSION)_Failover" 
end

#buildrom ./coreboot.rom CONFIG_ROM_SIZE "normal" "fallback" "failover" 
buildrom ./coreboot.rom CONFIG_ROM_SIZE "fallback" "failover"

############end####################

We want to get a space about 50K for VGA ROM like dbm690t does. I tried
CONFIG_ROM_SIZE, CONFIG_ROM_IMAGE_SIZE, but they both don't work. What
can we do?

Zheng

What is the way to add a VGA ROM space in target\xx\xx\Config.lb

[Ward Vandewege]

Hi Zheng,

On Wed, Jul 15, 2009 at 05:55:12PM +0800, Bao, Zheng wrote:
> We want to get a space about 50K for VGA ROM like dbm690t does. I tried
> CONFIG_ROM_SIZE, CONFIG_ROM_IMAGE_SIZE, but they both don't work. What
> can we do?

Look at the example in pcengines/alix.1c:

## CONFIG_ROM_SIZE is the total number of bytes allocated for coreboot use
## (normal AND fallback images and payloads). Leave 36k for VSA.
option CONFIG_ROM_SIZE = (512 * 1024) - (36 * 1024)

So, CONFIG_ROM_SIZE is the place to do that.

Thanks,
Ward.

What is the way to add a VGA ROM space intarget\xx\xx\Config.lb

[Bao, Zheng]

I have tried the CONFIG_ROM_SIZE, but it doesn't work. I worked in
serengeti_cheetah_fam10. I put "-60416" after CONFIG_ROM_SIZE=1024*1024.
But the building fails. Please see the build.log I attached.

Thanks.

Zheng

-----Original Message-----
From: Ward Vandewege [mailto:[e-mail]] 
Sent: Wednesday, July 15, 2009 8:51 PM
To: Bao, Zheng
Cc: Coreboot; Carl-Daniel Hailfinger
Subject: Re: [coreboot] What is the way to add a VGA ROM space
intarget\xx\xx\Config.lb

Hi Zheng,

On Wed, Jul 15, 2009 at 05:55:12PM +0800, Bao, Zheng wrote:
> We want to get a space about 50K for VGA ROM like dbm690t does. I

tried
> CONFIG_ROM_SIZE, CONFIG_ROM_IMAGE_SIZE, but they both don't work. What
> can we do?

Look at the example in pcengines/alix.1c:

## CONFIG_ROM_SIZE is the total number of bytes allocated for coreboot
use
## (normal AND fallback images and payloads). Leave 36k for VSA.
option CONFIG_ROM_SIZE = (512 * 1024) - (36 * 1024)

So, CONFIG_ROM_SIZE is the place to do that.

Thanks,
Ward.

What is the way to add a VGA ROM spaceintarget\xx\xx\Config.lb

[Myles Watson]

> I have tried the CONFIG_ROM_SIZE, but it doesn't work. I worked in
> serengeti_cheetah_fam10. I put "-60416" after CONFIG_ROM_SIZE=1024*1024.
> But the building fails. Please see the build.log I attached.

Have you tried a multiple of 1024?  Maybe something like 964*1024 if you
want 60K.

Thanks,
Myles

What is the way to add a VGA ROM spaceintarget\xx\xx\Config.lb

[Bao, Zheng]

Only if I tried 64*1024, the building will be no error. But the
coreboot.rom is still 1MB exactly.

Zheng

-----Original Message-----
From: Myles Watson [mailto:[e-mail]] 
Sent: Thursday, July 16, 2009 10:29 AM
To: Bao, Zheng; 'Coreboot'
Subject: RE: [coreboot] What is the way to add a VGA ROM
spaceintarget\xx\xx\Config.lb
> I have tried the CONFIG_ROM_SIZE, but it doesn't work. I worked in
> serengeti_cheetah_fam10. I put "-60416" after

CONFIG_ROM_SIZE=1024*1024.
> But the building fails. Please see the build.log I attached.

Have you tried a multiple of 1024?  Maybe something like 964*1024 if you
want 60K.

Thanks,
Myles

What is the way to add a VGA ROM spaceintarget\xx\xx\Config.lb

[Myles Watson]

> Only if I tried 64*1024, the building will be no error. But the
> coreboot.rom is still 1MB exactly.

I tried it with your Config.lb, except:

option CONFIG_ROM_SIZE = 960*1024
option CONFIG_FALLBACK_SIZE = CONFIG_ROM_SIZE

Then it worked for me.

Thanks,
Myles

What is the way to add a VGA ROM spaceintarget\xx\xx\Config.lb

[Myles Watson]

On Wed, Jul 15, 2009 at 9:37 PM, Myles Watson  wrote:
> > Only if I tried 64*1024, the building will be no error. But the
> > coreboot.rom is still 1MB exactly.
>
> I tried it with your Config.lb, except:
>
> option CONFIG_ROM_SIZE = 960*1024

This builds a 968K image, so you'll probably have to pad your ROM.

Myles

What is the way to add a VGA ROM spaceintarget\xx\xx\Config.lb

[Bao, Zheng]

In my case, it should be

CONFIG_FALLBACK_SIZE = CONFIG_ROM_SIZE-CONFIG_FAILOVER_SIZE

It works now.

Thanks.

Zheng

________________________________

From: Myles Watson [mailto:[e-mail]] 
Sent: Thursday, July 16, 2009 11:46 AM
To: Bao, Zheng; Coreboot
Subject: Re: [coreboot] What is the way to add a VGA ROM
spaceintarget\xx\xx\Config.lb

On Wed, Jul 15, 2009 at 9:37 PM, Myles Watson  wrote:
> Only if I tried 64*1024, the building will be no error. But the
> coreboot.rom is still 1MB exactly.

I tried it with your Config.lb, except:

option CONFIG_ROM_SIZE = 960*1024

This builds a 968K image, so you'll probably have to pad your ROM.

Myles