r3336 build service

[coreboot information]

Dear coreboot readers!

This is the automated build check service of coreboot.

The developer "jcrouse" checked in revision 3336 to
the coreboot source repository and caused the following 
changes:

Change Log:
libpayload:  Fix curses subwindows

This fixes subwindows in curses so that they draw and refresh correctly.

Signed-off-by: Jordan Crouse 
Acked-by: Myles Watson

Build Log:
Compilation of via:epia-cn is still broken
See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=3336&device=epia-cn&...

If something broke during this checkin please be a pain 
in jcrouse's neck until the issue is fixed.

If this issue is not fixed within 24h the revision should 
be backed out.

Best regards,
     coreboot automatic build system

[Myles Watson]

> -----Original Message-----
> From: coreboot-bounces+mylesgw=[e-mail] [mailto:coreboot-
> bounces+mylesgw=[e-mail]] On Behalf Of coreboot information
> Sent: Tuesday, May 20, 2008 3:05 PM
> To: coreboot mailinglist
> Subject: [coreboot] r3336 build service
>
> Dear coreboot readers!
>
> This is the automated build check service of coreboot.
>
> The developer "jcrouse" checked in revision 3336 to
> the coreboot source repository and caused the following
> changes:

It doesn't seem like changes to trunk/payloads should affect v2.  In other
words it doesn't seem like the v2 revision should increment and there
shouldn't be a need for a build test of v2.  Is this on purpose?

Thanks,
Myles
> Change Log:
> libpayload:  Fix curses subwindows
>
> This fixes subwindows in curses so that they draw and refresh correctly.

[Jordan Crouse]

On 20/05/08 15:13 -0600, Myles Watson wrote:
> > -----Original Message-----
> > From: coreboot-bounces+mylesgw=[e-mail] [mailto:coreboot-
> > bounces+mylesgw=[e-mail]] On Behalf Of coreboot information
> > Sent: Tuesday, May 20, 2008 3:05 PM
> > To: coreboot mailinglist
> > Subject: [coreboot] r3336 build service
> >
> > Dear coreboot readers!
> >
> > This is the automated build check service of coreboot.
> >
> > The developer "jcrouse" checked in revision 3336 to
> > the coreboot source repository and caused the following
> > changes:
>
> It doesn't seem like changes to trunk/payloads should affect v2.  In other
> words it doesn't seem like the v2 revision should increment and there
> shouldn't be a need for a build test of v2.  Is this on purpose?

Yes - by special request of Uwe, the payload code lives in the main trunk,
so any change to the trunk bumps the revision number.

Jordan

[Myles Watson]

> -----Original Message-----
> From: Jordan Crouse [mailto:[e-mail]]
> Sent: Tuesday, May 20, 2008 3:16 PM
> To: Myles Watson
> Cc: 'coreboot mailinglist'
> Subject: Re: r3336 build service
>
> On 20/05/08 15:13 -0600, Myles Watson wrote:
> > > -----Original Message-----
> > > From: coreboot-bounces+mylesgw=[e-mail]
>
> [mailto:coreboot-
> > > bounces+mylesgw=[e-mail]] On Behalf Of coreboot
>
> information
> > > Sent: Tuesday, May 20, 2008 3:05 PM
> > > To: coreboot mailinglist
> > > Subject: [coreboot] r3336 build service
> > >
> > > Dear coreboot readers!
> > >
> > > This is the automated build check service of coreboot.
> > >
> > > The developer "jcrouse" checked in revision 3336 to
> > > the coreboot source repository and caused the following
> > > changes:
> >
> > It doesn't seem like changes to trunk/payloads should affect v2.  In
>
> other
> > words it doesn't seem like the v2 revision should increment and there
> > shouldn't be a need for a build test of v2.  Is this on purpose?
>
> Yes - by special request of Uwe, the payload code lives in the main trunk,
> so any change to the trunk bumps the revision number.

OK.  The downside is that flashrom and payload updates make it seem like the
v2 tree is much more actively developed than it is, and makes it harder to
know when to bump (or not bump) revisions in buildrom.

Myles

[Uwe Hermann]

On Tue, May 20, 2008 at 03:15:47PM -0600, Jordan Crouse wrote:
> On 20/05/08 15:13 -0600, Myles Watson wrote:
> > > -----Original Message-----
> > > From: coreboot-bounces+mylesgw=[e-mail] [mailto:coreboot-
> > > bounces+mylesgw=[e-mail]] On Behalf Of coreboot information
> > > Sent: Tuesday, May 20, 2008 3:05 PM
> > > To: coreboot mailinglist
> > > Subject: [coreboot] r3336 build service
> > >
> > > Dear coreboot readers!
> > >
> > > This is the automated build check service of coreboot.
> > >
> > > The developer "jcrouse" checked in revision 3336 to
> > > the coreboot source repository and caused the following
> > > changes:
> >
> > It doesn't seem like changes to trunk/payloads should affect v2.  In other
> > words it doesn't seem like the v2 revision should increment and there
> > shouldn't be a need for a build test of v2.  Is this on purpose?
>
> Yes - by special request of Uwe, the payload code lives in the main trunk,
> so any change to the trunk bumps the revision number.

The autobuild scripts could be changed to only trigger on actual v2
changes though.

Uwe.

[Stefan Reinauer]

Myles Watson wrote:
> > -----Original Message-----
> > From: coreboot-bounces+mylesgw=[e-mail] [mailto:coreboot-
> > bounces+mylesgw=[e-mail]] On Behalf Of coreboot information
> > Sent: Tuesday, May 20, 2008 3:05 PM
> > To: coreboot mailinglist
> > Subject: [coreboot] r3336 build service
> >
> > Dear coreboot readers!
> >
> > This is the automated build check service of coreboot.
> >
> > The developer "jcrouse" checked in revision 3336 to
> > the coreboot source repository and caused the following
> > changes:
>
> It doesn't seem like changes to trunk/payloads should affect v2.  In other
> words it doesn't seem like the v2 revision should increment and there
> shouldn't be a need for a build test of v2.  Is this on purpose?

No, it happened on user request. The initial idea was to have separate
repositories for all separate projects.