It's incredibly annoying to have to reset the BIOS options after every coreboot test run, so I've "fixed" the problem with errors when building with OPTION_TABLE deselected, but I'm not exactly 100% sure it's the right fix. I'd REALLY appreciate it if someone checks ;) Also, I've removed "select OPTION_TABLE" from all the mainboard Kconfigs (the new option defaults to y), but I'm not sure if there are any chipsets where the option table is absolutely required.
Thanks, Corey
On Wed, Dec 17, 2008 at 1:11 AM, Corey Osgood corey.osgood@gmail.comwrote:
It's incredibly annoying to have to reset the BIOS options after every coreboot test run, so I've "fixed" the problem with errors when building with OPTION_TABLE deselected, but I'm not exactly 100% sure it's the right fix. I'd REALLY appreciate it if someone checks ;) Also, I've removed "select OPTION_TABLE" from all the mainboard Kconfigs (the new option defaults to y), but I'm not sure if there are any chipsets where the option table is absolutely required.
Oops, OPTION_TABLE already had an entry with a help. Remove that, and use that help since it was way better then mine. IMO, this is where OPTION_TABLE belongs, perhaps with "depends EXPERT".
-Corey
Corey Osgood wrote:
Move OPTION_TABLE to a menu config option, and default it to enabled.
Fantastic. I would be even happier if it defaulted to disabled.
Acked-by: Peter Stuge peter@stuge.se
On Wed, Dec 17, 2008 at 8:40 PM, Peter Stuge peter@stuge.se wrote:
Corey Osgood wrote:
Move OPTION_TABLE to a menu config option, and default it to enabled.
Fantastic. I would be even happier if it defaulted to disabled.
Acked-by: Peter Stuge peter@stuge.se
r1078, thanks!
-Corey